Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2012-01-17 Thread Dirk Behme
Dear Wolfgang and all, On 17.01.2012 10:52, Wolfgang Denk wrote: Dear Zach Sadecki, In message <4f149ccb.6070...@itwatchdogs.com> you wrote: This patch will also fix a problem with mx28 boards that are depending on the OCOTP bits to set the MAC address (like the Denx m28 board). Now it simpl

Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2012-01-17 Thread Wolfgang Denk
Dear Zach Sadecki, In message <4f149ccb.6070...@itwatchdogs.com> you wrote: > This patch will also fix a problem with mx28 boards that are depending > on the OCOTP bits to set the MAC address (like the Denx m28 board). Now > it simply fails with a "Warning: failed to set MAC address" if there's

Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2012-01-16 Thread Zach Sadecki
This patch will also fix a problem with mx28 boards that are depending on the OCOTP bits to set the MAC address (like the Denx m28 board). Now it simply fails with a "Warning: failed to set MAC address" if there's no environment variable instead of using the OCOTP bits like it should. This pa

Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2012-01-16 Thread Wolfgang Denk
Dear Philip Balister, In message <4f142f52@balister.org> you wrote: > > > I'm not going to pull that patch. > > > > Please explain which actual problem you're trying to fix. > > For u-boot for an overo based product that uses the SMSC911x ethernet > chip (with MAC address set via EEPROM conn

Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2012-01-16 Thread Philip Balister
On 01/13/2012 02:19 PM, Wolfgang Denk wrote: > Dear Eric Miao, > > In message <1313559224-4627-1-git-send-email-eric.m...@linaro.org> you wrote: >> Ignore the return value of eth_getenv_enetaddr_by_index(), and if it >> fails, fall back to use dev->enetaddr, which could be filled up by >> the ethe

Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2012-01-15 Thread Eric Miao
On Mon, Jan 16, 2012 at 3:03 PM, Eric Miao wrote: > On Sat, Jan 14, 2012 at 3:19 AM, Wolfgang Denk wrote: >> Dear Eric Miao, >> >> In message <1313559224-4627-1-git-send-email-eric.m...@linaro.org> you wrote: >>> Ignore the return value of eth_getenv_enetaddr_by_index(), and if it >>> fails, fall

Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2012-01-15 Thread Eric Miao
On Sat, Jan 14, 2012 at 3:19 AM, Wolfgang Denk wrote: > Dear Eric Miao, > > In message <1313559224-4627-1-git-send-email-eric.m...@linaro.org> you wrote: >> Ignore the return value of eth_getenv_enetaddr_by_index(), and if it >> fails, fall back to use dev->enetaddr, which could be filled up by >>

Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2012-01-13 Thread Wolfgang Denk
Dear Eric Miao, In message <1313559224-4627-1-git-send-email-eric.m...@linaro.org> you wrote: > Ignore the return value of eth_getenv_enetaddr_by_index(), and if it > fails, fall back to use dev->enetaddr, which could be filled up by > the ethernet device driver. > > Actually, this is the origina

Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2012-01-11 Thread Stefan Roese
On Wednesday 17 August 2011 07:33:44 Eric Miao wrote: > Ignore the return value of eth_getenv_enetaddr_by_index(), and if it > fails, fall back to use dev->enetaddr, which could be filled up by > the ethernet device driver. > > Actually, this is the original behavior, and was later changed by > co

Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2012-01-11 Thread Stefan Roese
On Thursday 12 January 2012 06:12:19 Simon Glass wrote: > On Wed, Jan 11, 2012 at 4:23 AM, Dirk Behme wrote: > > On 17.08.2011 08:22, Simon Glass wrote: > >> On Tue, Aug 16, 2011 at 10:33 PM, Eric Miao wrote: > >>> Ignore the return value of eth_getenv_enetaddr_by_index(), and if it > >>> fails,

Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2012-01-11 Thread Simon Glass
On Wed, Jan 11, 2012 at 4:23 AM, Dirk Behme wrote: > On 17.08.2011 08:22, Simon Glass wrote: >> >> On Tue, Aug 16, 2011 at 10:33 PM, Eric Miao wrote: >>> >>> Ignore the return value of eth_getenv_enetaddr_by_index(), and if it >>> fails, fall back to use dev->enetaddr, which could be filled up by

Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2012-01-11 Thread Dirk Behme
On 17.08.2011 08:22, Simon Glass wrote: On Tue, Aug 16, 2011 at 10:33 PM, Eric Miao wrote: Ignore the return value of eth_getenv_enetaddr_by_index(), and if it fails, fall back to use dev->enetaddr, which could be filled up by the ethernet device driver. Actually, this is the original behavior

Re: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2011-08-16 Thread Simon Glass
On Tue, Aug 16, 2011 at 10:33 PM, Eric Miao wrote: > Ignore the return value of eth_getenv_enetaddr_by_index(), and if it > fails, fall back to use dev->enetaddr, which could be filled up by > the ethernet device driver. > > Actually, this is the original behavior, and was later changed by > commi

[U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

2011-08-16 Thread Eric Miao
Ignore the return value of eth_getenv_enetaddr_by_index(), and if it fails, fall back to use dev->enetaddr, which could be filled up by the ethernet device driver. Actually, this is the original behavior, and was later changed by commit 48506a2cde2458fa1f8c5993afc98e5a4617e1d3. Signed-off-by: Eri