Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper

2019-11-26 Thread Ondřej Jirman
Hello, On Fri, Sep 13, 2019 at 07:40:22PM -0500, Joe Hershberger wrote: > Part of the env cleanup moved this out of the environment code and into > the net code. However, this helper is sometimes needed even when the net > stack isn't included. > > Move the helper to lib/net_utils.c like it's sim

Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper

2019-09-18 Thread Ondřej Jirman
Hello, On Tue, Sep 17, 2019 at 09:22:20PM +, Joe Hershberger wrote: > Hi Simon, > > On Sat, Sep 14, 2019 at 1:55 PM Simon Goldschmidt > wrote: > > > > Joe Hershberger schrieb am Sa., 14. Sep. 2019, > > 20:46: > > > > > On Sat, Sep 14, 2019 at 1:32 PM Tom Rini wrote: > > > > > > > > On Sat

Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper

2019-09-18 Thread Ondřej Jirman
On Sat, Sep 14, 2019 at 02:29:11PM -0400, Tom Rini wrote: > On Sat, Sep 14, 2019 at 04:05:44PM +0200, Ondřej Jirman wrote: > > Hi, > > > > On Fri, Sep 13, 2019 at 07:40:22PM -0500, Joe Hershberger wrote: > > > Part of the env cleanup moved this out of the environment code and into > > > the net co

Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper

2019-09-17 Thread Simon Goldschmidt
Joe Hershberger schrieb am Di., 17. Sep. 2019, 23:22: > Hi Simon, > > On Sat, Sep 14, 2019 at 1:55 PM Simon Goldschmidt > wrote: > > > > Joe Hershberger schrieb am Sa., 14. Sep. 2019, > > 20:46: > > > > > On Sat, Sep 14, 2019 at 1:32 PM Tom Rini wrote: > > > > > > > > On Sat, Sep 14, 2019 at 0

Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper

2019-09-17 Thread Joe Hershberger
Hi Simon, On Sat, Sep 14, 2019 at 1:55 PM Simon Goldschmidt wrote: > > Joe Hershberger schrieb am Sa., 14. Sep. 2019, > 20:46: > > > On Sat, Sep 14, 2019 at 1:32 PM Tom Rini wrote: > > > > > > On Sat, Sep 14, 2019 at 04:05:44PM +0200, Ondřej Jirman wrote: > > > > Hi, > > > > > > > > On Fri, Sep

Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper

2019-09-14 Thread Simon Goldschmidt
Joe Hershberger schrieb am Sa., 14. Sep. 2019, 20:46: > On Sat, Sep 14, 2019 at 1:32 PM Tom Rini wrote: > > > > On Sat, Sep 14, 2019 at 04:05:44PM +0200, Ondřej Jirman wrote: > > > Hi, > > > > > > On Fri, Sep 13, 2019 at 07:40:22PM -0500, Joe Hershberger wrote: > > > > Part of the env cleanup mo

Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper

2019-09-14 Thread Joe Hershberger
On Sat, Sep 14, 2019 at 1:32 PM Tom Rini wrote: > > On Sat, Sep 14, 2019 at 04:05:44PM +0200, Ondřej Jirman wrote: > > Hi, > > > > On Fri, Sep 13, 2019 at 07:40:22PM -0500, Joe Hershberger wrote: > > > Part of the env cleanup moved this out of the environment code and into > > > the net code. Howe

Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper

2019-09-14 Thread Tom Rini
On Sat, Sep 14, 2019 at 04:05:44PM +0200, Ondřej Jirman wrote: > Hi, > > On Fri, Sep 13, 2019 at 07:40:22PM -0500, Joe Hershberger wrote: > > Part of the env cleanup moved this out of the environment code and into > > the net code. However, this helper is sometimes needed even when the net > > sta

Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper

2019-09-14 Thread Ondřej Jirman
Hi, On Fri, Sep 13, 2019 at 07:40:22PM -0500, Joe Hershberger wrote: > Part of the env cleanup moved this out of the environment code and into > the net code. However, this helper is sometimes needed even when the net > stack isn't included. > > Move the helper to lib/net_utils.c like it's simila

Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper

2019-09-14 Thread Heinrich Schuchardt
On 9/14/19 2:40 AM, Joe Hershberger wrote: Part of the env cleanup moved this out of the environment code and into the net code. However, this helper is sometimes needed even when the net stack isn't included. Move the helper to lib/net_utils.c like it's similarly-purposed string_to_ip(). Also r

[U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper

2019-09-13 Thread Joe Hershberger
Part of the env cleanup moved this out of the environment code and into the net code. However, this helper is sometimes needed even when the net stack isn't included. Move the helper to lib/net_utils.c like it's similarly-purposed string_to_ip(). Also rename the moved function to similar naming.