Re: [U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-09-03 Thread Joe Hershberger
On Mon, Aug 26, 2019 at 2:18 AM Stefan Roese wrote: > > With commit c6d07bf440bc ("net/macb: increase RX buffer size for GEM") > ethernet support does not work any more with d-cache enabled on the > AT91SAM. The reason is, that MACB_RX_BUFFER_SIZE was changed from 4096 > to 128 but this change

Re: [U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-08-26 Thread Bin Meng
On Mon, Aug 26, 2019 at 3:18 PM Stefan Roese wrote: > > With commit c6d07bf440bc ("net/macb: increase RX buffer size for GEM") > ethernet support does not work any more with d-cache enabled on the > AT91SAM. The reason is, that MACB_RX_BUFFER_SIZE was changed from 4096 > to 128 but this change

[U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-08-26 Thread Stefan Roese
With commit c6d07bf440bc ("net/macb: increase RX buffer size for GEM") ethernet support does not work any more with d-cache enabled on the AT91SAM. The reason is, that MACB_RX_BUFFER_SIZE was changed from 4096 to 128 but this change was not refected in the rx_buffer flush and invalidate functions,

Re: [U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-08-23 Thread Ramon Fried
> > > Should it be: > > > > > >flush_dcache_range(macb->rx_buffer_dma, macb->rx_buffer_dma + > > > ALIGN(macb->rx_buffer_size * > > > MACB_RX_RING_SIZE, PKTALIGN)); > > > > Yes, this looks correct. v2 will follow soon. > > > > Thanks, > > Stefan > The entire

Re: [U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-08-23 Thread Ramon Fried
On Fri, Aug 23, 2019 at 1:37 PM Stefan Roese wrote: > > Hi Bin, > > On 23.08.19 11:22, Bin Meng wrote: > > On Fri, Aug 23, 2019 at 5:17 PM Bin Meng wrote: > >> > >> Hi Stefan, > >> > >> On Fri, Aug 23, 2019 at 5:02 PM Stefan Roese wrote: > >>> > >>> With commit c6d07bf440bc ("net/macb: increase

Re: [U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-08-23 Thread Ramon Fried
On Fri, Aug 23, 2019 at 12:22 PM Bin Meng wrote: > > On Fri, Aug 23, 2019 at 5:17 PM Bin Meng wrote: > > > > Hi Stefan, > > > > On Fri, Aug 23, 2019 at 5:02 PM Stefan Roese wrote: > > > > > > With commit c6d07bf440bc ("net/macb: increase RX buffer size for GEM") > > > ethernet support does not

Re: [U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-08-23 Thread Stefan Roese
Hi Bin, On 23.08.19 11:22, Bin Meng wrote: On Fri, Aug 23, 2019 at 5:17 PM Bin Meng wrote: Hi Stefan, On Fri, Aug 23, 2019 at 5:02 PM Stefan Roese wrote: With commit c6d07bf440bc ("net/macb: increase RX buffer size for GEM") ethernet support does not work any more with d-cache enabled on

Re: [U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-08-23 Thread Bin Meng
On Fri, Aug 23, 2019 at 5:17 PM Bin Meng wrote: > > Hi Stefan, > > On Fri, Aug 23, 2019 at 5:02 PM Stefan Roese wrote: > > > > With commit c6d07bf440bc ("net/macb: increase RX buffer size for GEM") > > ethernet support does not work any more with d-cache enabled on the > > AT91SAM. The reason

Re: [U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-08-23 Thread Bin Meng
Hi Stefan, On Fri, Aug 23, 2019 at 5:02 PM Stefan Roese wrote: > > With commit c6d07bf440bc ("net/macb: increase RX buffer size for GEM") > ethernet support does not work any more with d-cache enabled on the > AT91SAM. The reason is, that MACB_RX_BUFFER_SIZE was changed from 4096 > to 128 but

[U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-08-23 Thread Stefan Roese
With commit c6d07bf440bc ("net/macb: increase RX buffer size for GEM") ethernet support does not work any more with d-cache enabled on the AT91SAM. The reason is, that MACB_RX_BUFFER_SIZE was changed from 4096 to 128 but this change was not refected in the rx_buffer flush and invalidate functions,