Re: [U-Boot] [PATCH] omap3evm: Set environment variable 'ethaddr'

2011-09-03 Thread Premi, Sanjeev
> From: Wolfgang Denk [w...@denx.de] > Sent: Saturday, September 03, 2011 3:37 AM > To: Premi, Sanjeev > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH] omap3evm: Set environment variable 'ethaddr' > > Dear "Premi, Sanjeev", > > In message

Re: [U-Boot] [PATCH] omap3evm: Set environment variable 'ethaddr'

2011-09-02 Thread Wolfgang Denk
Dear "Premi, Sanjeev", In message you wrote: > > > Your patch always and unconditionally overwrites any existing > > "ethaddr" settings. This is not acceptable. > > For the EVM, MAC address is always probed from the chip. Hence, I > assumed it safe to set the ethaddr - without checking for env

Re: [U-Boot] [PATCH] omap3evm: Set environment variable 'ethaddr'

2011-09-02 Thread Premi, Sanjeev
> -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Friday, September 02, 2011 7:14 PM > To: Premi, Sanjeev > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH] omap3evm: Set environment > variable 'ethaddr' > > Dear Sanje

Re: [U-Boot] [PATCH] omap3evm: Set environment variable 'ethaddr'

2011-09-02 Thread Wolfgang Denk
Dear Sanjeev Premi, In message <1314967433-14199-1-git-send-email-pr...@ti.com> you wrote: > It is now responsibility of the board specific init > code to set the environment variable corresponding > to the MAC address. > > Signed-off-by: Sanjeev Premi This looks all wrong to me. In U-Boot, th

[U-Boot] [PATCH] omap3evm: Set environment variable 'ethaddr'

2011-09-02 Thread Sanjeev Premi
It is now responsibility of the board specific init code to set the environment variable corresponding to the MAC address. Signed-off-by: Sanjeev Premi --- Tested on omap3evm at against latest master at: bd061a5 : Merge branch 'master' of git://git.denx.de/u-boot-sh board/ti/evm/evm.c | 10