Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-09-02 Thread Marek Vasut
On 09/03/2018 01:35 AM, Simon Glass wrote: > Hi Marek, > > On 2 September 2018 at 12:24, Marek Vasut wrote: >> On 09/02/2018 03:07 AM, Simon Glass wrote: >>> Hi Marek, >>> >>> On 1 September 2018 at 16:43, Marek Vasut wrote: On 09/01/2018 11:45 PM, Simon Glass wrote: > Hi Marek, >

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-09-02 Thread Simon Glass
Hi Marek, On 2 September 2018 at 12:24, Marek Vasut wrote: > On 09/02/2018 03:07 AM, Simon Glass wrote: >> Hi Marek, >> >> On 1 September 2018 at 16:43, Marek Vasut wrote: >>> On 09/01/2018 11:45 PM, Simon Glass wrote: Hi Marek, On 30 August 2018 at 03:25, Marek Vasut wrote:

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-09-02 Thread Marek Vasut
On 09/02/2018 03:07 AM, Simon Glass wrote: > Hi Marek, > > On 1 September 2018 at 16:43, Marek Vasut wrote: >> On 09/01/2018 11:45 PM, Simon Glass wrote: >>> Hi Marek, >>> >>> On 30 August 2018 at 03:25, Marek Vasut wrote: On 08/30/2018 02:29 AM, Simon Glass wrote: > Hi Marek,

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-09-01 Thread Simon Glass
Hi Marek, On 1 September 2018 at 16:43, Marek Vasut wrote: > On 09/01/2018 11:45 PM, Simon Glass wrote: >> Hi Marek, >> >> On 30 August 2018 at 03:25, Marek Vasut wrote: >>> >>> On 08/30/2018 02:29 AM, Simon Glass wrote: Hi Marek, >>> >>> Hi, >>> >>> [...] >>> >> If you have both EHCI

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-09-01 Thread Marek Vasut
On 09/01/2018 11:45 PM, Simon Glass wrote: > Hi Marek, > > On 30 August 2018 at 03:25, Marek Vasut wrote: >> >> On 08/30/2018 02:29 AM, Simon Glass wrote: >>> Hi Marek, >> >> Hi, >> >> [...] >> > If you have both EHCI and a xHCI controller which can occupy the same > BFD, then how would

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-09-01 Thread Simon Glass
Hi Marek, On 30 August 2018 at 03:25, Marek Vasut wrote: > > On 08/30/2018 02:29 AM, Simon Glass wrote: > > Hi Marek, > > Hi, > > [...] > > >>> If you have both EHCI and a xHCI controller which can occupy the same > >>> BFD, then how would you supply in the DT options needed by the > >>>

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-30 Thread Marek Vasut
On 08/30/2018 02:29 AM, Simon Glass wrote: > Hi Marek, Hi, [...] >>> If you have both EHCI and a xHCI controller which can occupy the same >>> BFD, then how would you supply in the DT options needed by the >>> controller itself? Don't you need two nodes in that case? >> >> For the PHY case,

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-29 Thread Simon Glass
Hi Marek, On 23 August 2018 at 06:58, Marek Vasut wrote: > On 08/23/2018 12:45 PM, Simon Glass wrote: > [...] Why is pci_bus_find_devfn() failing? >>> >>> Because this function is a hack to force-bind drivers to PCI devices >>> which are described in the DT with a compatible string. This

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-23 Thread Marek Vasut
On 08/23/2018 12:45 PM, Simon Glass wrote: [...] >>> Why is pci_bus_find_devfn() failing? >> >> Because this function is a hack to force-bind drivers to PCI devices >> which are described in the DT with a compatible string. This does not >> apply to this case. > > pci_bus_find_devfn() does not

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-23 Thread Simon Glass
Hi Marek, On 22 August 2018 at 14:19, Marek Vasut wrote: > On 08/22/2018 08:08 PM, Simon Glass wrote: > [...] >>> This is explained in the patch description and the thread again. Please >>> read the thread before replying. Take a look at the r8a7794.dtsi and its >>> PCI bindings, there are PCI

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-23 Thread Marek Vasut
On 08/23/2018 04:11 AM, Bin Meng wrote: > Hi Marek, Hello Bin, > On Wed, Aug 22, 2018 at 5:57 PM, Marek Vasut wrote: >> On 08/22/2018 04:14 AM, Bin Meng wrote: >> [...] >> I said in the previous discussion I am willing to update the >> documentation to match the implementation, but

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-22 Thread Bin Meng
Hi Marek, On Wed, Aug 22, 2018 at 5:57 PM, Marek Vasut wrote: > On 08/22/2018 04:14 AM, Bin Meng wrote: > [...] > I said in the previous discussion I am willing to update the > documentation to match the implementation, but that's about it. > >> So far almost all PCI device

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-22 Thread Marek Vasut
On 08/22/2018 08:08 PM, Simon Glass wrote: [...] >> This is explained in the patch description and the thread again. Please >> read the thread before replying. Take a look at the r8a7794.dtsi and its >> PCI bindings, there are PCI controller subnodes which add extra >> information for PCI devices

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-22 Thread Simon Glass
Hi Marek, On 20 August 2018 at 14:15, Marek Vasut wrote: > > On 08/20/2018 09:29 PM, Simon Glass wrote: > [...] > > > So what is the conclusion here ? Patch the design document and apply > > this patch as is ? > > > > I think we should see Simon's comments before we move

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-22 Thread Marek Vasut
On 08/22/2018 04:14 AM, Bin Meng wrote: [...] I said in the previous discussion I am willing to update the documentation to match the implementation, but that's about it. > So far almost all PCI device drivers in U-Boot supports both > scenarios, except PCI UART which

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-21 Thread Bin Meng
Hi Marek, On Tue, Aug 21, 2018 at 6:28 PM, Marek Vasut wrote: > On 08/21/2018 09:16 AM, Bin Meng wrote: >> Hi Marek, >> >> On Tue, Aug 21, 2018 at 1:43 PM, Marek Vasut wrote: >>> On 08/21/2018 06:56 AM, Bin Meng wrote: >>> [...] The proposal I made is: * Keep

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-21 Thread Marek Vasut
On 08/21/2018 08:29 PM, Simon Glass wrote: > Hi Marek, > > On 21 August 2018 at 12:26, Marek Vasut wrote: >> >> On 08/21/2018 07:32 PM, Simon Glass wrote: >>> Hi Bin, >>> >>> On 20 August 2018 at 21:46, Bin Meng wrote: Hi Simon, On Tue, Aug 21, 2018 at 3:29 AM, Simon Glass

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-21 Thread Simon Glass
Hi Marek, On 21 August 2018 at 12:26, Marek Vasut wrote: > > On 08/21/2018 07:32 PM, Simon Glass wrote: > > Hi Bin, > > > > On 20 August 2018 at 21:46, Bin Meng wrote: > >> Hi Simon, > >> > >> On Tue, Aug 21, 2018 at 3:29 AM, Simon Glass wrote: > >>> Hi Marek, > >>> > >>> On 20 August 2018 at

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-21 Thread Marek Vasut
On 08/21/2018 07:32 PM, Simon Glass wrote: > Hi Bin, > > On 20 August 2018 at 21:46, Bin Meng wrote: >> Hi Simon, >> >> On Tue, Aug 21, 2018 at 3:29 AM, Simon Glass wrote: >>> Hi Marek, >>> >>> On 20 August 2018 at 12:42, Marek Vasut wrote: On 08/20/2018 06:57 PM, Simon Glass wrote:

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-21 Thread Simon Glass
Hi Bin, On 20 August 2018 at 21:46, Bin Meng wrote: > Hi Simon, > > On Tue, Aug 21, 2018 at 3:29 AM, Simon Glass wrote: >> Hi Marek, >> >> On 20 August 2018 at 12:42, Marek Vasut wrote: >>> >>> On 08/20/2018 06:57 PM, Simon Glass wrote: >>> > Hi Bin, >>> > >>> > On 16 August 2018 at 19:51, Bin

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-21 Thread Marek Vasut
On 08/21/2018 09:16 AM, Bin Meng wrote: > Hi Marek, > > On Tue, Aug 21, 2018 at 1:43 PM, Marek Vasut wrote: >> On 08/21/2018 06:56 AM, Bin Meng wrote: >> [...] >>> The proposal I made is: >>> >>> * Keep pci-uclass driver's post_bind() and child_post_bind() only for >>> Sandbox

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-21 Thread Bin Meng
Hi Marek, On Tue, Aug 21, 2018 at 1:43 PM, Marek Vasut wrote: > On 08/21/2018 06:56 AM, Bin Meng wrote: > [...] >> The proposal I made is: >> >> * Keep pci-uclass driver's post_bind() and child_post_bind() only for >> Sandbox configuration >> * Keep the call to

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-20 Thread Marek Vasut
On 08/21/2018 06:56 AM, Bin Meng wrote: [...] > The proposal I made is: > > * Keep pci-uclass driver's post_bind() and child_post_bind() only for > Sandbox configuration > * Keep the call to pci_bus_find_devfn() in pci_bind_bus_devices() only > for Sandbox configuration

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-20 Thread Bin Meng
Hi Marek, On Tue, Aug 21, 2018 at 12:30 PM, Marek Vasut wrote: > On 08/21/2018 06:15 AM, Bin Meng wrote: > [...] > >>> From what I understand, Marek and Bin are discussing whether a >>> compatible string is needed to bind a driver. >>> >>> Generally it is. But with PCI and USB we

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-20 Thread Marek Vasut
On 08/21/2018 06:15 AM, Bin Meng wrote: [...] >> From what I understand, Marek and Bin are discussing whether a >> compatible string is needed to bind a driver. >> >> Generally it is. But with PCI and USB we have a search mechanism which >> can be used instead. >> >>

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-20 Thread Bin Meng
Hi Marek, On Tue, Aug 21, 2018 at 12:02 PM, Marek Vasut wrote: > On 08/21/2018 05:46 AM, Bin Meng wrote: >> Hi Simon, >> >> On Tue, Aug 21, 2018 at 3:29 AM, Simon Glass wrote: >>> Hi Marek, >>> >>> On 20 August 2018 at 12:42, Marek Vasut wrote: On 08/20/2018 06:57 PM, Simon Glass

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-20 Thread Marek Vasut
On 08/21/2018 05:46 AM, Bin Meng wrote: > Hi Simon, > > On Tue, Aug 21, 2018 at 3:29 AM, Simon Glass wrote: >> Hi Marek, >> >> On 20 August 2018 at 12:42, Marek Vasut wrote: >>> >>> On 08/20/2018 06:57 PM, Simon Glass wrote: Hi Bin, On 16 August 2018 at 19:51, Bin Meng wrote:

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-20 Thread Bin Meng
Hi Simon, On Tue, Aug 21, 2018 at 3:29 AM, Simon Glass wrote: > Hi Marek, > > On 20 August 2018 at 12:42, Marek Vasut wrote: >> >> On 08/20/2018 06:57 PM, Simon Glass wrote: >> > Hi Bin, >> > >> > On 16 August 2018 at 19:51, Bin Meng wrote: >> >> Hi Marek, >> >> >> >> On Thu, Aug 16, 2018 at

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-20 Thread Marek Vasut
On 08/20/2018 09:29 PM, Simon Glass wrote: [...] > So what is the conclusion here ? Patch the design document and apply > this patch as is ? > I think we should see Simon's comments before we move forward. The proposal I made before should come in a series, not just

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-20 Thread Simon Glass
Hi Marek, On 20 August 2018 at 12:42, Marek Vasut wrote: > > On 08/20/2018 06:57 PM, Simon Glass wrote: > > Hi Bin, > > > > On 16 August 2018 at 19:51, Bin Meng wrote: > >> Hi Marek, > >> > >> On Thu, Aug 16, 2018 at 7:47 PM, Marek Vasut wrote: > >>> On 08/15/2018 01:25 PM, Tom Rini wrote: >

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-20 Thread Marek Vasut
On 08/20/2018 06:57 PM, Simon Glass wrote: > Hi Bin, > > On 16 August 2018 at 19:51, Bin Meng wrote: >> Hi Marek, >> >> On Thu, Aug 16, 2018 at 7:47 PM, Marek Vasut wrote: >>> On 08/15/2018 01:25 PM, Tom Rini wrote: On Wed, Aug 15, 2018 at 06:19:25PM +0800, Bin Meng wrote: > Hi Marek,

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-20 Thread Simon Glass
Hi Bin, On 16 August 2018 at 19:51, Bin Meng wrote: > Hi Marek, > > On Thu, Aug 16, 2018 at 7:47 PM, Marek Vasut wrote: >> On 08/15/2018 01:25 PM, Tom Rini wrote: >>> On Wed, Aug 15, 2018 at 06:19:25PM +0800, Bin Meng wrote: Hi Marek, On Wed, Aug 15, 2018 at 5:22 PM, Marek Vasut

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-20 Thread Marek Vasut
On 08/20/2018 09:18 AM, Bin Meng wrote: > Hi Marek, > > On Fri, Aug 17, 2018 at 6:27 PM, Marek Vasut wrote: >> On 08/17/2018 03:51 AM, Bin Meng wrote: >>> Hi Marek, >>> >>> On Thu, Aug 16, 2018 at 7:47 PM, Marek Vasut wrote: On 08/15/2018 01:25 PM, Tom Rini wrote: > On Wed, Aug 15,

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-20 Thread Bin Meng
Hi Marek, On Fri, Aug 17, 2018 at 6:27 PM, Marek Vasut wrote: > On 08/17/2018 03:51 AM, Bin Meng wrote: >> Hi Marek, >> >> On Thu, Aug 16, 2018 at 7:47 PM, Marek Vasut wrote: >>> On 08/15/2018 01:25 PM, Tom Rini wrote: On Wed, Aug 15, 2018 at 06:19:25PM +0800, Bin Meng wrote: > Hi

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-17 Thread Marek Vasut
On 08/17/2018 03:51 AM, Bin Meng wrote: > Hi Marek, > > On Thu, Aug 16, 2018 at 7:47 PM, Marek Vasut wrote: >> On 08/15/2018 01:25 PM, Tom Rini wrote: >>> On Wed, Aug 15, 2018 at 06:19:25PM +0800, Bin Meng wrote: Hi Marek, On Wed, Aug 15, 2018 at 5:22 PM, Marek Vasut wrote: >

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-16 Thread Bin Meng
Hi Marek, On Thu, Aug 16, 2018 at 7:47 PM, Marek Vasut wrote: > On 08/15/2018 01:25 PM, Tom Rini wrote: >> On Wed, Aug 15, 2018 at 06:19:25PM +0800, Bin Meng wrote: >>> Hi Marek, >>> >>> On Wed, Aug 15, 2018 at 5:22 PM, Marek Vasut wrote: On 08/14/2018 11:40 AM, Bin Meng wrote: > Hi

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-16 Thread Marek Vasut
On 08/15/2018 01:25 PM, Tom Rini wrote: > On Wed, Aug 15, 2018 at 06:19:25PM +0800, Bin Meng wrote: >> Hi Marek, >> >> On Wed, Aug 15, 2018 at 5:22 PM, Marek Vasut wrote: >>> On 08/14/2018 11:40 AM, Bin Meng wrote: Hi Marek, On Tue, Aug 14, 2018 at 4:55 PM, Marek Vasut wrote:

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-15 Thread Marek Vasut
On 08/15/2018 12:19 PM, Bin Meng wrote: > Hi Marek, > > On Wed, Aug 15, 2018 at 5:22 PM, Marek Vasut wrote: >> On 08/14/2018 11:40 AM, Bin Meng wrote: >>> Hi Marek, >>> >>> On Tue, Aug 14, 2018 at 4:55 PM, Marek Vasut wrote: On 08/14/2018 03:46 AM, Bin Meng wrote: > Hi Marek, >

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-15 Thread Tom Rini
On Wed, Aug 15, 2018 at 06:19:25PM +0800, Bin Meng wrote: > Hi Marek, > > On Wed, Aug 15, 2018 at 5:22 PM, Marek Vasut wrote: > > On 08/14/2018 11:40 AM, Bin Meng wrote: > >> Hi Marek, > >> > >> On Tue, Aug 14, 2018 at 4:55 PM, Marek Vasut wrote: > >>> On 08/14/2018 03:46 AM, Bin Meng wrote: >

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-15 Thread Bin Meng
Hi Marek, On Wed, Aug 15, 2018 at 5:22 PM, Marek Vasut wrote: > On 08/14/2018 11:40 AM, Bin Meng wrote: >> Hi Marek, >> >> On Tue, Aug 14, 2018 at 4:55 PM, Marek Vasut wrote: >>> On 08/14/2018 03:46 AM, Bin Meng wrote: Hi Marek, On Mon, Aug 13, 2018 at 9:46 PM, Marek Vasut

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-15 Thread Marek Vasut
On 08/14/2018 11:40 AM, Bin Meng wrote: > Hi Marek, > > On Tue, Aug 14, 2018 at 4:55 PM, Marek Vasut wrote: >> On 08/14/2018 03:46 AM, Bin Meng wrote: >>> Hi Marek, >>> >>> On Mon, Aug 13, 2018 at 9:46 PM, Marek Vasut wrote: On 08/13/2018 04:24 AM, Bin Meng wrote: > Hi Marek, >

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-15 Thread Marek Vasut
On 08/14/2018 11:35 AM, Bin Meng wrote: [...] >> I think knowing where Linux does this >> would be instructive to figure out where we need to have some additional >> logic added OR we can make some cost/benefit analysis to see if it makes >> more sense overall to add compatibles

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-14 Thread Tom Rini
On Tue, Aug 14, 2018 at 10:34:23AM +0800, Bin Meng wrote: > Hi Tom, > > On Tue, Aug 14, 2018 at 1:16 AM, Tom Rini wrote: > > On Mon, Aug 13, 2018 at 06:07:14PM +0200, Marek Vasut wrote: > >> On 08/13/2018 03:39 PM, Tom Rini wrote: > >> [...] > >> > >> Next step is to upstream the DT > >>

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-14 Thread Bin Meng
Hi Marek, On Tue, Aug 14, 2018 at 4:55 PM, Marek Vasut wrote: > On 08/14/2018 03:46 AM, Bin Meng wrote: >> Hi Marek, >> >> On Mon, Aug 13, 2018 at 9:46 PM, Marek Vasut wrote: >>> On 08/13/2018 04:24 AM, Bin Meng wrote: Hi Marek, On Fri, Aug 10, 2018 at 8:38 PM, Marek Vasut

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-14 Thread Bin Meng
Hi Marek, On Tue, Aug 14, 2018 at 4:54 PM, Marek Vasut wrote: > On 08/14/2018 04:34 AM, Bin Meng wrote: >> Hi Tom, >> >> On Tue, Aug 14, 2018 at 1:16 AM, Tom Rini wrote: >>> On Mon, Aug 13, 2018 at 06:07:14PM +0200, Marek Vasut wrote: On 08/13/2018 03:39 PM, Tom Rini wrote: [...]

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-14 Thread Marek Vasut
On 08/14/2018 04:34 AM, Bin Meng wrote: > Hi Tom, > > On Tue, Aug 14, 2018 at 1:16 AM, Tom Rini wrote: >> On Mon, Aug 13, 2018 at 06:07:14PM +0200, Marek Vasut wrote: >>> On 08/13/2018 03:39 PM, Tom Rini wrote: >>> [...] >>> >>> Next step is to upstream the DT >>> changes to Linux

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-14 Thread Marek Vasut
On 08/14/2018 03:46 AM, Bin Meng wrote: > Hi Marek, > > On Mon, Aug 13, 2018 at 9:46 PM, Marek Vasut wrote: >> On 08/13/2018 04:24 AM, Bin Meng wrote: >>> Hi Marek, >>> >>> On Fri, Aug 10, 2018 at 8:38 PM, Marek Vasut wrote: On 08/10/2018 02:01 PM, Tom Rini wrote: > On Wed, Aug 08,

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-13 Thread Bin Meng
Hi Tom, On Tue, Aug 14, 2018 at 1:16 AM, Tom Rini wrote: > On Mon, Aug 13, 2018 at 06:07:14PM +0200, Marek Vasut wrote: >> On 08/13/2018 03:39 PM, Tom Rini wrote: >> [...] >> >> Next step is to upstream the DT >> changes to Linux kernel, then sync the changes to U-Boot to satisfy >>

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-13 Thread Bin Meng
Hi Marek, On Mon, Aug 13, 2018 at 9:46 PM, Marek Vasut wrote: > On 08/13/2018 04:24 AM, Bin Meng wrote: >> Hi Marek, >> >> On Fri, Aug 10, 2018 at 8:38 PM, Marek Vasut wrote: >>> On 08/10/2018 02:01 PM, Tom Rini wrote: On Wed, Aug 08, 2018 at 09:37:25PM +0200, Marek Vasut wrote: > On

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-13 Thread Tom Rini
On Mon, Aug 13, 2018 at 06:07:14PM +0200, Marek Vasut wrote: > On 08/13/2018 03:39 PM, Tom Rini wrote: > [...] > > Next step is to upstream the DT > changes to Linux kernel, then sync the changes to U-Boot to satisfy > this obsession - using exactly the same DT as Linux. > >>> >

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-13 Thread Marek Vasut
On 08/13/2018 03:39 PM, Tom Rini wrote: [...] Next step is to upstream the DT changes to Linux kernel, then sync the changes to U-Boot to satisfy this obsession - using exactly the same DT as Linux. >>> >>> This is not gonna happen. >>> >>> Sorry, you're really just wasting my time

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-13 Thread Marek Vasut
On 08/13/2018 04:24 AM, Bin Meng wrote: > Hi Marek, > > On Fri, Aug 10, 2018 at 8:38 PM, Marek Vasut wrote: >> On 08/10/2018 02:01 PM, Tom Rini wrote: >>> On Wed, Aug 08, 2018 at 09:37:25PM +0200, Marek Vasut wrote: On 08/08/2018 05:32 PM, Bin Meng wrote: > Hi Marek, > > On Wed,

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-13 Thread Marek Vasut
On 08/13/2018 04:07 AM, Bin Meng wrote: [...] > Sorry this is terribly wrong. Imagine someone > writes another OS, and all he has is the device tree spec. He follows > the spec and writes some codes to parse a valid DT, and it's done. How > his OS makes use of the DT is his

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-13 Thread Tom Rini
On Mon, Aug 13, 2018 at 10:07:03AM +0800, Bin Meng wrote: > Hi Marek, > > On Fri, Aug 10, 2018 at 6:32 PM, Marek Vasut wrote: > > On 08/10/2018 05:42 AM, Bin Meng wrote: > >> Hi Marek, > >> > >> On Thu, Aug 9, 2018 at 6:25 PM, Marek Vasut wrote: > >>> On 08/09/2018 11:41 AM, Bin Meng wrote: >

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-12 Thread Bin Meng
Hi Marek, On Fri, Aug 10, 2018 at 8:38 PM, Marek Vasut wrote: > On 08/10/2018 02:01 PM, Tom Rini wrote: >> On Wed, Aug 08, 2018 at 09:37:25PM +0200, Marek Vasut wrote: >>> On 08/08/2018 05:32 PM, Bin Meng wrote: Hi Marek, On Wed, Aug 8, 2018 at 10:33 PM, Marek Vasut wrote: >

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-12 Thread Bin Meng
Hi Marek, On Fri, Aug 10, 2018 at 6:32 PM, Marek Vasut wrote: > On 08/10/2018 05:42 AM, Bin Meng wrote: >> Hi Marek, >> >> On Thu, Aug 9, 2018 at 6:25 PM, Marek Vasut wrote: >>> On 08/09/2018 11:41 AM, Bin Meng wrote: >>> >>> [...] >>> Sorry this is a hack to current U-Boot

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-10 Thread Marek Vasut
On 08/10/2018 02:01 PM, Tom Rini wrote: > On Wed, Aug 08, 2018 at 09:37:25PM +0200, Marek Vasut wrote: >> On 08/08/2018 05:32 PM, Bin Meng wrote: >>> Hi Marek, >>> >>> On Wed, Aug 8, 2018 at 10:33 PM, Marek Vasut wrote: On 08/08/2018 03:39 PM, Bin Meng wrote: > Hi Marek, > > On

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-10 Thread Tom Rini
On Wed, Aug 08, 2018 at 09:37:25PM +0200, Marek Vasut wrote: > On 08/08/2018 05:32 PM, Bin Meng wrote: > > Hi Marek, > > > > On Wed, Aug 8, 2018 at 10:33 PM, Marek Vasut wrote: > >> On 08/08/2018 03:39 PM, Bin Meng wrote: > >>> Hi Marek, > >>> > >>> On Wed, Aug 8, 2018 at 9:24 PM, Marek Vasut

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-10 Thread Marek Vasut
On 08/10/2018 05:42 AM, Bin Meng wrote: > Hi Marek, > > On Thu, Aug 9, 2018 at 6:25 PM, Marek Vasut wrote: >> On 08/09/2018 11:41 AM, Bin Meng wrote: >> >> [...] >> >>> Sorry this is a hack to current U-Boot implementation, not fix. >> >> I am waiting for a better solution or

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-09 Thread Bin Meng
Hi Marek, On Thu, Aug 9, 2018 at 6:25 PM, Marek Vasut wrote: > On 08/09/2018 11:41 AM, Bin Meng wrote: > > [...] > >> Sorry this is a hack to current U-Boot implementation, not fix. > > I am waiting for a better solution or suggestion ... > >> The fix should be adding

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-09 Thread Marek Vasut
On 08/09/2018 11:41 AM, Bin Meng wrote: [...] > Sorry this is a hack to current U-Boot implementation, not fix. I am waiting for a better solution or suggestion ... > The fix should be adding "ehci-pci" compatible string in the r8a7794.dtsi. Wrong. The DT is

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-09 Thread Bin Meng
Hi Marek, On Thu, Aug 9, 2018 at 3:54 PM, Marek Vasut wrote: > On 08/09/2018 04:37 AM, Bin Meng wrote: >> Hi Marek, >> >> On Thu, Aug 9, 2018 at 8:36 AM, Marek Vasut wrote: >>> On 08/09/2018 01:24 AM, Bin Meng wrote: Hi Marek, On Thu, Aug 9, 2018 at 3:37 AM, Marek Vasut wrote:

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-09 Thread Marek Vasut
On 08/09/2018 04:37 AM, Bin Meng wrote: > Hi Marek, > > On Thu, Aug 9, 2018 at 8:36 AM, Marek Vasut wrote: >> On 08/09/2018 01:24 AM, Bin Meng wrote: >>> Hi Marek, >>> >>> On Thu, Aug 9, 2018 at 3:37 AM, Marek Vasut wrote: On 08/08/2018 05:32 PM, Bin Meng wrote: > Hi Marek, > >

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-08 Thread Bin Meng
Hi Marek, On Thu, Aug 9, 2018 at 8:36 AM, Marek Vasut wrote: > On 08/09/2018 01:24 AM, Bin Meng wrote: >> Hi Marek, >> >> On Thu, Aug 9, 2018 at 3:37 AM, Marek Vasut wrote: >>> On 08/08/2018 05:32 PM, Bin Meng wrote: Hi Marek, On Wed, Aug 8, 2018 at 10:33 PM, Marek Vasut wrote:

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-08 Thread Marek Vasut
On 08/09/2018 01:24 AM, Bin Meng wrote: > Hi Marek, > > On Thu, Aug 9, 2018 at 3:37 AM, Marek Vasut wrote: >> On 08/08/2018 05:32 PM, Bin Meng wrote: >>> Hi Marek, >>> >>> On Wed, Aug 8, 2018 at 10:33 PM, Marek Vasut wrote: On 08/08/2018 03:39 PM, Bin Meng wrote: > Hi Marek, >

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-08 Thread Bin Meng
Hi Marek, On Thu, Aug 9, 2018 at 3:37 AM, Marek Vasut wrote: > On 08/08/2018 05:32 PM, Bin Meng wrote: >> Hi Marek, >> >> On Wed, Aug 8, 2018 at 10:33 PM, Marek Vasut wrote: >>> On 08/08/2018 03:39 PM, Bin Meng wrote: Hi Marek, On Wed, Aug 8, 2018 at 9:24 PM, Marek Vasut wrote:

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-08 Thread Marek Vasut
On 08/08/2018 05:32 PM, Bin Meng wrote: > Hi Marek, > > On Wed, Aug 8, 2018 at 10:33 PM, Marek Vasut wrote: >> On 08/08/2018 03:39 PM, Bin Meng wrote: >>> Hi Marek, >>> >>> On Wed, Aug 8, 2018 at 9:24 PM, Marek Vasut wrote: On 08/08/2018 03:14 PM, Bin Meng wrote: > Hi Marek, >

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-08 Thread Bin Meng
Hi Marek, On Wed, Aug 8, 2018 at 10:33 PM, Marek Vasut wrote: > On 08/08/2018 03:39 PM, Bin Meng wrote: >> Hi Marek, >> >> On Wed, Aug 8, 2018 at 9:24 PM, Marek Vasut wrote: >>> On 08/08/2018 03:14 PM, Bin Meng wrote: Hi Marek, On Wed, Aug 8, 2018 at 9:03 PM, Marek Vasut wrote:

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-08 Thread Marek Vasut
On 08/08/2018 03:39 PM, Bin Meng wrote: > Hi Marek, > > On Wed, Aug 8, 2018 at 9:24 PM, Marek Vasut wrote: >> On 08/08/2018 03:14 PM, Bin Meng wrote: >>> Hi Marek, >>> >>> On Wed, Aug 8, 2018 at 9:03 PM, Marek Vasut wrote: The PCI controller can have DT subnodes describing extra properties

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-08 Thread Bin Meng
Hi Marek, On Wed, Aug 8, 2018 at 9:24 PM, Marek Vasut wrote: > On 08/08/2018 03:14 PM, Bin Meng wrote: >> Hi Marek, >> >> On Wed, Aug 8, 2018 at 9:03 PM, Marek Vasut wrote: >>> The PCI controller can have DT subnodes describing extra properties >>> of particular PCI devices, ie. a PHY attached

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-08 Thread Marek Vasut
On 08/08/2018 03:14 PM, Bin Meng wrote: > Hi Marek, > > On Wed, Aug 8, 2018 at 9:03 PM, Marek Vasut wrote: >> The PCI controller can have DT subnodes describing extra properties >> of particular PCI devices, ie. a PHY attached to an EHCI controller >> on a PCI bus. This patch parses those DT

Re: [U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-08 Thread Bin Meng
Hi Marek, On Wed, Aug 8, 2018 at 9:03 PM, Marek Vasut wrote: > The PCI controller can have DT subnodes describing extra properties > of particular PCI devices, ie. a PHY attached to an EHCI controller > on a PCI bus. This patch parses those DT subnodes and assigns a node > to the PCI device

[U-Boot] [PATCH] pci: Support parsing PCI controller DT subnodes

2018-08-08 Thread Marek Vasut
The PCI controller can have DT subnodes describing extra properties of particular PCI devices, ie. a PHY attached to an EHCI controller on a PCI bus. This patch parses those DT subnodes and assigns a node to the PCI device instance, so that the driver can extract details from that node and ie.