Re: [U-Boot] [PATCH] pci: mx6: fix occasional link failures

2014-08-20 Thread Stefano Babic
Hi Tim, On 08/08/2014 07:57, Tim Harvey wrote: > According to the IMX6 reference manuals, REF_SSP_EN (Reference clock enable > for SS function) must remain deasserted until the reference clock is running > at the appropriate frequency. > > Without this patch we find a high link failure rate (>5%)

Re: [U-Boot] [PATCH] pci: mx6: fix occasional link failures

2014-08-10 Thread Marek Vasut
On Saturday, August 09, 2014 at 09:11:49 PM, Fabio Estevam wrote: > On Sat, Aug 9, 2014 at 12:37 PM, Fabio Estevam wrote: > > Ok, so with the debug patch applied I let it running overnight and it > > ran 39k+ times without PCI linkup failures. > > > > I agree with your comments and now I am doing

Re: [U-Boot] [PATCH] pci: mx6: fix occasional link failures

2014-08-09 Thread Fabio Estevam
On Sat, Aug 9, 2014 at 12:37 PM, Fabio Estevam wrote: > Ok, so with the debug patch applied I let it running overnight and it > ran 39k+ times without PCI linkup failures. > > I agree with your comments and now I am doing as you suggested: > > Running top of tree u-boot-imx with only Tim's patch

Re: [U-Boot] [PATCH] pci: mx6: fix occasional link failures

2014-08-09 Thread Fabio Estevam
Hi Marek, On Sat, Aug 9, 2014 at 8:51 AM, Marek Vasut wrote: > Well you do realize that this addition changes the timing of the code and also > generates writes on the AXI bus, right? I would be much fonder of your testing > if you did it with a pristine code and monitored the number of successf

Re: [U-Boot] [PATCH] pci: mx6: fix occasional link failures

2014-08-09 Thread Marek Vasut
On Friday, August 08, 2014 at 05:35:23 PM, Fabio Estevam wrote: > On Fri, Aug 8, 2014 at 10:33 AM, Marek Vasut wrote: > > Can you guys test it on FSL hardware ? > > Sure, I am running u-boot-imx with Tim's patch applied and this > additional debug patch that shows the number of reboots and PCI >

Re: [U-Boot] [PATCH] pci: mx6: fix occasional link failures

2014-08-08 Thread Fabio Estevam
On Fri, Aug 8, 2014 at 10:33 AM, Marek Vasut wrote: > Can you guys test it on FSL hardware ? Sure, I am running u-boot-imx with Tim's patch applied and this additional debug patch that shows the number of reboots and PCI linkups: drivers/pci/pcie_imx.c | 13 + 1 file changed, 13 in

Re: [U-Boot] [PATCH] pci: mx6: fix occasional link failures

2014-08-08 Thread Marek Vasut
On Friday, August 08, 2014 at 03:02:27 PM, Fabio Estevam wrote: > Hi Tim, > > On Fri, Aug 8, 2014 at 2:57 AM, Tim Harvey wrote: > > According to the IMX6 reference manuals, REF_SSP_EN (Reference clock > > enable for SS function) must remain deasserted until the reference clock > > is running at t

Re: [U-Boot] [PATCH] pci: mx6: fix occasional link failures

2014-08-08 Thread Fabio Estevam
Hi Tim, On Fri, Aug 8, 2014 at 2:57 AM, Tim Harvey wrote: > According to the IMX6 reference manuals, REF_SSP_EN (Reference clock enable > for SS function) must remain deasserted until the reference clock is running > at the appropriate frequency. > > Without this patch we find a high link failure

Re: [U-Boot] [PATCH] pci: mx6: fix occasional link failures

2014-08-08 Thread Marek Vasut
On Friday, August 08, 2014 at 07:57:29 AM, Tim Harvey wrote: > According to the IMX6 reference manuals, REF_SSP_EN (Reference clock enable > for SS function) must remain deasserted until the reference clock is > running at the appropriate frequency. > > Without this patch we find a high link failu

[U-Boot] [PATCH] pci: mx6: fix occasional link failures

2014-08-07 Thread Tim Harvey
According to the IMX6 reference manuals, REF_SSP_EN (Reference clock enable for SS function) must remain deasserted until the reference clock is running at the appropriate frequency. Without this patch we find a high link failure rate (>5%) on certain IMX6 boards at various temperatures. Signed-o