[U-Boot] [PATCH] powerpc/85xx: fix null pointer dereference when initializing the SGMII TBI PHY

2011-10-04 Thread Timur Tabi
Function dtsec_configure_serdes() needs to know where the TBI PHY registers are in order to configure SGMII for proper SerDes operation. During SGMII initialzation, fm_eth_init_mac() passing NULL for 'phyregs' when it called init_dtsec(), because it was believed that phyregs was not used. In fact,

Re: [U-Boot] [PATCH] powerpc/85xx: fix null pointer dereference when initializing the SGMII TBI PHY

2011-10-04 Thread Kumar Gala
On Oct 4, 2011, at 4:44 PM, Timur Tabi wrote: > Function dtsec_configure_serdes() needs to know where the TBI PHY registers > are in order to configure SGMII for proper SerDes operation. > > During SGMII initialzation, fm_eth_init_mac() passing NULL for 'phyregs' when > it called init_dtsec(), b

Re: [U-Boot] [PATCH] powerpc/85xx: fix null pointer dereference when initializing the SGMII TBI PHY

2011-10-04 Thread Tabi Timur-B04825
Kumar Gala wrote: >> > Note: I'm not sure of my change to struct fm_mdio. It works, but it >> > doesn't >> > smell right. > What exactly is the concern? Nothing specific, just a gut feeling. -- Timur Tabi Linux kernel developer at Freescale ___ U-

Re: [U-Boot] [PATCH] powerpc/85xx: fix null pointer dereference when initializing the SGMII TBI PHY

2011-10-07 Thread Kumar Gala
On Oct 4, 2011, at 4:44 PM, Timur Tabi wrote: > Function dtsec_configure_serdes() needs to know where the TBI PHY registers > are in order to configure SGMII for proper SerDes operation. > > During SGMII initialzation, fm_eth_init_mac() passing NULL for 'phyregs' when > it called init_dtsec(), b