Re: [U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support

2010-10-13 Thread Eibach, Dirk
Hi Dirk, Hi Stefan, ... snip +/* Gbit PHYs */ +#define CONFIG_BITBANGMII /* bit-bang MII PHY management*/ + +#define CONFIG_SYS_MDIO_PIN (0x8000 13) /* our MDIO is GPIO0 */ +#define CONFIG_SYS_MDC_PIN (0x8000 7) /* our MDC is GPIO7 */

Re: [U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support

2010-10-13 Thread Stefan Roese
Hi Dirk, On Wednesday 13 October 2010 09:25:33 Eibach, Dirk wrote: +#define MDIO_ACTIVE out32(GPIO0_TCR, in32(GPIO0_TCR) | CONFIG_SYS_MDIO_PIN) Use out_be32() accessors here and below. Just being curious: why? Because of the included memory barriers in the in/out_be32()

Re: [U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support

2010-10-13 Thread Eibach, Dirk
... snip +/* Gbit PHYs */ +#define CONFIG_BITBANGMII /* bit-bang MII PHY management*/ + +#define CONFIG_SYS_MDIO_PIN (0x8000 13) /* our MDIO is GPIO0 */ +#define CONFIG_SYS_MDC_PIN (0x8000 7) /* our MDC is GPIO7 */ + +#define

Re: [U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support

2010-10-13 Thread Wolfgang Denk
Dear Eibach, Dirk, In message 48d3d52125c49b43ae880038e2e5314bb5b...@srv101.gdsys.de you wrote: To make this work, drivers/net/phy/miiphybb.c would have to include asm/io.h somehow. What would be the right way to achieve this? This is a pretty clear indication that this processor or even

Re: [U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support

2010-10-13 Thread Stefan Roese
On Wednesday 13 October 2010 10:23:26 Eibach, Dirk wrote: + +#define MDIO_ACTIVE out32(GPIO0_TCR, in32(GPIO0_TCR) | CONFIG_SYS_MDIO_PIN) Use out_be32() accessors here and below. Please fix and resubmit. Thanks. To make this work, drivers/net/phy/miiphybb.c would have to

[U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support

2010-10-12 Thread Dirk Eibach
Board support for the Guntermann Drunck CATCenter Io. Signed-off-by: Dirk Eibach eib...@gdsys.de --- MAKEALL |1 + Makefile |3 + board/gdsys/io/Makefile | 51 ++ board/gdsys/io/config.mk | 24 + board/gdsys/io/io.c | 231

Re: [U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support

2010-10-12 Thread Wolfgang Denk
Dear Dirk Eibach, In message 1286890387-11491-1-git-send-email-eib...@gdsys.de you wrote: Board support for the Guntermann Drunck CATCenter Io. Signed-off-by: Dirk Eibach eib...@gdsys.de --- MAKEALL |1 + Makefile |3 + board/gdsys/io/Makefile |

Re: [U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support

2010-10-12 Thread Stefan Roese
Hi Dirk, On Tuesday 12 October 2010 15:33:07 Dirk Eibach wrote: Board support for the Guntermann Drunck CATCenter Io. Apart from Wolfgangs comments, some more from myself below. diff --git a/include/configs/io.h b/include/configs/io.h new file mode 100644 index 000..53dce7d ---