[U-Boot] [PATCH] ppc4xx: Fix msg "initialization as root-complex failed" upon PCIe scan

2009-10-02 Thread Stefan Roese
This message is printed upon PCIe bus scan, not only upon error, but also if no PCIe device is detected at all. Since this is not an error, let's remove this message in this case. We already have the message "link is not up." if there is no PCIe device present. Signed-off-by: Stefan Roese --- bo

Re: [U-Boot] [PATCH] ppc4xx: Fix msg "initialization as root-complex failed" upon PCIe scan

2009-10-02 Thread Wolfgang Denk
Dear Stefan Roese, In message <1254486916-3040-1-git-send-email...@denx.de> you wrote: > This message is printed upon PCIe bus scan, not only upon error, but also > if no PCIe device is detected at all. Since this is not an error, let's > remove this message in this case. We already have the messa

Re: [U-Boot] [PATCH] ppc4xx: Fix msg "initialization as root-complex failed" upon PCIe scan

2009-10-02 Thread Stefan Roese
Hi Wolfgang, On Friday 02 October 2009 14:41:58 Wolfgang Denk wrote: > But looking at this patch, it seems that larger parts in this > (supposedly) board-specific code are actually more or less identical. > > Should we not factor out such common code? Yes, this could (should) be done. But there

Re: [U-Boot] [PATCH] ppc4xx: Fix msg "initialization as root-complex failed" upon PCIe scan

2009-10-03 Thread Wolfgang Denk
Dear Stefan Roese, In message <200910021450.19551...@denx.de> you wrote: > > > But looking at this patch, it seems that larger parts in this > > (supposedly) board-specific code are actually more or less identical. > > > > Should we not factor out such common code? > > Yes, this could (should)

Re: [U-Boot] [PATCH] ppc4xx: Fix msg "initialization as root-complex failed" upon PCIe scan

2009-10-07 Thread Stefan Roese
On Friday 02 October 2009 14:35:16 Stefan Roese wrote: > This message is printed upon PCIe bus scan, not only upon error, but also > if no PCIe device is detected at all. Since this is not an error, let's > remove this message in this case. We already have the message > "link is not up." if there i