Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-13 Thread Simon Glass
Hi Rob, On 13 August 2017 at 12:07, Rob Clark wrote: > On Sun, Aug 13, 2017 at 11:35 AM, Simon Glass wrote: >> Hi Rob, >> >> On 6 August 2017 at 05:58, Rob Clark wrote: >>> >>> On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: >>> > On 4 August 2017 at 07:16, Bin Meng wrote: >>> >> Hi Rob, >

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-13 Thread Rob Clark
On Sun, Aug 13, 2017 at 11:35 AM, Simon Glass wrote: > Hi Rob, > > On 6 August 2017 at 05:58, Rob Clark wrote: >> >> On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: >> > On 4 August 2017 at 07:16, Bin Meng wrote: >> >> Hi Rob, >> >> >> >> On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: >>

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-13 Thread Simon Glass
Hi Rob, On 6 August 2017 at 05:58, Rob Clark wrote: > > On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: > > On 4 August 2017 at 07:16, Bin Meng wrote: > >> Hi Rob, > >> > >> On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: > >>> stdin might not be set, which would cause iomux_doenv() to fai

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-06 Thread Rob Clark
On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: > On 4 August 2017 at 07:16, Bin Meng wrote: >> Hi Rob, >> >> On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: >>> stdin might not be set, which would cause iomux_doenv() to fail >>> therefore causing probe_usb_keyboard() to fail. Furthermore i

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-06 Thread Bin Meng
Hi Rob, On Sun, Aug 6, 2017 at 6:41 PM, Rob Clark wrote: > On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: >> On 4 August 2017 at 07:16, Bin Meng wrote: >>> Hi Rob, >>> >>> On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: stdin might not be set, which would cause iomux_doenv() to fail

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-06 Thread Rob Clark
On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: > On 4 August 2017 at 07:16, Bin Meng wrote: >> Hi Rob, >> >> On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: >>> stdin might not be set, which would cause iomux_doenv() to fail >>> therefore causing probe_usb_keyboard() to fail. Furthermore i

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-05 Thread Simon Glass
On 4 August 2017 at 07:16, Bin Meng wrote: > Hi Rob, > > On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: >> stdin might not be set, which would cause iomux_doenv() to fail >> therefore causing probe_usb_keyboard() to fail. Furthermore if we do >> have iomux enabled, the sensible thing (in terms

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-04 Thread Bin Meng
Hi Rob, On Fri, Aug 4, 2017 at 8:51 PM, Rob Clark wrote: > stdin might not be set, which would cause iomux_doenv() to fail > therefore causing probe_usb_keyboard() to fail. Furthermore if we do > have iomux enabled, the sensible thing (in terms of user experience) > would be to simply add oursel

[U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-04 Thread Rob Clark
stdin might not be set, which would cause iomux_doenv() to fail therefore causing probe_usb_keyboard() to fail. Furthermore if we do have iomux enabled, the sensible thing (in terms of user experience) would be to simply add ourselves to the list of stdin devices. This fixes an issue with usbkbd