Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-10-13 Thread Remy Bohmer
Hi, 2010/10/11 Mike Frysinger vap...@gentoo.org: On Friday, August 13, 2010 06:25:05 Sergei Shtylyov wrote: Remy Bohmer wrote: Sergei, do you agree that I apply this patch?     Well, if it's based on the Linux code... although it still does look wrong... I don't know. :-) do you have a

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-10-11 Thread Mike Frysinger
On Friday, August 13, 2010 06:25:05 Sergei Shtylyov wrote: Remy Bohmer wrote: Sergei, do you agree that I apply this patch? Well, if it's based on the Linux code... although it still does look wrong... I don't know. :-) do you have a board you could test on ? otherwise, it seems this

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-13 Thread Sergei Shtylyov
Hello. Remy Bohmer wrote: Mike Frysinger wrote: --- a/drivers/usb/musb/musb_hcd.c +++ b/drivers/usb/musb/musb_hcd.c } else { - if (!toggle) - writew(MUSB_RXCSR_CLRDATATOG, musbr-rxcsr); - else { + if (!toggle) { +

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-12 Thread Remy Bohmer
Hi, 2010/8/10 Mike Frysinger vap...@gentoo.org: On Tue, Aug 10, 2010 at 6:26 AM, Sergei Shtylyov wrote: Mike Frysinger wrote: --- a/drivers/usb/musb/musb_hcd.c +++ b/drivers/usb/musb/musb_hcd.c        } else { -               if (!toggle) -                      

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-12 Thread Remy Bohmer
Hi Mike, 2010/8/9 Mike Frysinger vap...@gentoo.org: From: Bryan Wu bryan...@analog.com This is a change similar to what is already in the Linux driver.  We should only program the CLRDATATOG bit when the current mode indicates that it is needed. Signed-off-by: Bryan Wu bryan...@analog.com

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-12 Thread Mike Frysinger
On Thu, Aug 12, 2010 at 2:08 PM, Remy Bohmer wrote: 2010/8/9 Mike Frysinger: From: Bryan Wu bryan...@analog.com This is a change similar to what is already in the Linux driver.  We should only program the CLRDATATOG bit when the current mode indicates that it is needed. Signed-off-by:

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-10 Thread Sergei Shtylyov
Hello. Mike Frysinger wrote: From: Bryan Wu bryan...@analog.com This is a change similar to what is already in the Linux driver. We should only program the CLRDATATOG bit when the current mode indicates that it is needed. Signed-off-by: Bryan Wu bryan...@analog.com Signed-off-by: Cliff

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-10 Thread Mike Frysinger
On Tue, Aug 10, 2010 at 6:26 AM, Sergei Shtylyov wrote: Mike Frysinger wrote: --- a/drivers/usb/musb/musb_hcd.c +++ b/drivers/usb/musb/musb_hcd.c        } else { -               if (!toggle) -                       writew(MUSB_RXCSR_CLRDATATOG, musbr-rxcsr); -               else { +        

[U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-09 Thread Mike Frysinger
From: Bryan Wu bryan...@analog.com This is a change similar to what is already in the Linux driver. We should only program the CLRDATATOG bit when the current mode indicates that it is needed. Signed-off-by: Bryan Wu bryan...@analog.com Signed-off-by: Cliff Cai cliff@analog.com