Re: [U-Boot] [PATCH] usb: storage: Fix overwritten in usb_stor_set_max_xfer_blk()

2017-10-01 Thread Marek Vasut
On 10/01/2017 03:18 PM, Bin Meng wrote: > Hi Marek, > > On Fri, Sep 29, 2017 at 5:36 PM, Marek Vasut wrote: >> On 09/29/2017 11:26 AM, Bin Meng wrote: >>> Hi Marek, >>> >>> On Fri, Sep 29, 2017 at 10:30 AM, Marek Vasut wrote: On 09/29/2017 01:36 AM, Bin Meng

Re: [U-Boot] [PATCH] usb: storage: Fix overwritten in usb_stor_set_max_xfer_blk()

2017-10-01 Thread Bin Meng
Hi Marek, On Fri, Sep 29, 2017 at 5:36 PM, Marek Vasut wrote: > On 09/29/2017 11:26 AM, Bin Meng wrote: >> Hi Marek, >> >> On Fri, Sep 29, 2017 at 10:30 AM, Marek Vasut wrote: >>> On 09/29/2017 01:36 AM, Bin Meng wrote: Hi Marek, On Thu, Sep 28, 2017

Re: [U-Boot] [PATCH] usb: storage: Fix overwritten in usb_stor_set_max_xfer_blk()

2017-09-29 Thread Marek Vasut
On 09/29/2017 11:26 AM, Bin Meng wrote: > Hi Marek, > > On Fri, Sep 29, 2017 at 10:30 AM, Marek Vasut wrote: >> On 09/29/2017 01:36 AM, Bin Meng wrote: >>> Hi Marek, >>> >>> On Thu, Sep 28, 2017 at 11:24 PM, Marek Vasut wrote: On 09/28/2017 06:50 AM, Bin Meng

Re: [U-Boot] [PATCH] usb: storage: Fix overwritten in usb_stor_set_max_xfer_blk()

2017-09-29 Thread Bin Meng
Hi Marek, On Fri, Sep 29, 2017 at 10:30 AM, Marek Vasut wrote: > On 09/29/2017 01:36 AM, Bin Meng wrote: >> Hi Marek, >> >> On Thu, Sep 28, 2017 at 11:24 PM, Marek Vasut wrote: >>> On 09/28/2017 06:50 AM, Bin Meng wrote: The stored 'blk' value is overwritten

Re: [U-Boot] [PATCH] usb: storage: Fix overwritten in usb_stor_set_max_xfer_blk()

2017-09-28 Thread Marek Vasut
On 09/29/2017 01:36 AM, Bin Meng wrote: > Hi Marek, > > On Thu, Sep 28, 2017 at 11:24 PM, Marek Vasut wrote: >> On 09/28/2017 06:50 AM, Bin Meng wrote: >>> The stored 'blk' value is overwritten to 'size / 512' before it can >>> be used in usb_stor_set_max_xfer_blk(). This is not

Re: [U-Boot] [PATCH] usb: storage: Fix overwritten in usb_stor_set_max_xfer_blk()

2017-09-28 Thread Bin Meng
Hi Marek, On Thu, Sep 28, 2017 at 11:24 PM, Marek Vasut wrote: > On 09/28/2017 06:50 AM, Bin Meng wrote: >> The stored 'blk' value is overwritten to 'size / 512' before it can >> be used in usb_stor_set_max_xfer_blk(). This is not what we want. >> In fact, when 'size' exceeds the

Re: [U-Boot] [PATCH] usb: storage: Fix overwritten in usb_stor_set_max_xfer_blk()

2017-09-28 Thread Marek Vasut
On 09/28/2017 06:50 AM, Bin Meng wrote: > The stored 'blk' value is overwritten to 'size / 512' before it can > be used in usb_stor_set_max_xfer_blk(). This is not what we want. > In fact, when 'size' exceeds the upper limit (USHRT_MAX * 512), we > should simply assign 'size' to the upper limit. >

[U-Boot] [PATCH] usb: storage: Fix overwritten in usb_stor_set_max_xfer_blk()

2017-09-27 Thread Bin Meng
The stored 'blk' value is overwritten to 'size / 512' before it can be used in usb_stor_set_max_xfer_blk(). This is not what we want. In fact, when 'size' exceeds the upper limit (USHRT_MAX * 512), we should simply assign 'size' to the upper limit. Reported-by: Coverity (CID: 167250)