Re: [U-Boot] [PATCH] usb: sunxi: ohci: make ohci_t the first member in private data

2018-06-18 Thread Tom Rini
On Mon, Jun 18, 2018 at 11:45:23AM +0530, Jagan Teki wrote: > On Mon, Jun 18, 2018 at 6:44 AM, Marek Vasut wrote: > > On 06/17/2018 06:13 PM, Vasily Khoruzhick wrote: > >> ohci-hcd casts priv_data pointer to (ohci_t *), thus it must be > >> the first member in private data struct. > >> > >> Fixes

Re: [U-Boot] [PATCH] usb: sunxi: ohci: make ohci_t the first member in private data

2018-06-18 Thread Vasily Khoruzhick
On Mon, Jun 18, 2018 at 12:39 AM, Jagan Teki wrote: >> >From what I see in the other thread, the USB never worked with the >> series. If the controller returns 0s as EHCI version, something is >> obviously broken and I don't even understand how that could be an >> acceptable positive test result.

Re: [U-Boot] [PATCH] usb: sunxi: ohci: make ohci_t the first member in private data

2018-06-18 Thread Jagan Teki
On Mon, Jun 18, 2018 at 12:49 PM, Marek Vasut wrote: > On 06/18/2018 08:15 AM, Jagan Teki wrote: >> On Mon, Jun 18, 2018 at 6:44 AM, Marek Vasut wrote: >>> On 06/17/2018 06:13 PM, Vasily Khoruzhick wrote: ohci-hcd casts priv_data pointer to (ohci_t *), thus it must be the first member i

Re: [U-Boot] [PATCH] usb: sunxi: ohci: make ohci_t the first member in private data

2018-06-18 Thread Marek Vasut
On 06/18/2018 08:15 AM, Jagan Teki wrote: > On Mon, Jun 18, 2018 at 6:44 AM, Marek Vasut wrote: >> On 06/17/2018 06:13 PM, Vasily Khoruzhick wrote: >>> ohci-hcd casts priv_data pointer to (ohci_t *), thus it must be >>> the first member in private data struct. >>> >>> Fixes 831cc98b1 ("usb: sunxi:

Re: [U-Boot] [PATCH] usb: sunxi: ohci: make ohci_t the first member in private data

2018-06-17 Thread Jagan Teki
On Mon, Jun 18, 2018 at 6:44 AM, Marek Vasut wrote: > On 06/17/2018 06:13 PM, Vasily Khoruzhick wrote: >> ohci-hcd casts priv_data pointer to (ohci_t *), thus it must be >> the first member in private data struct. >> >> Fixes 831cc98b1 ("usb: sunxi: Simplify ccm reg base code") >> >> Signed-off-by

Re: [U-Boot] [PATCH] usb: sunxi: ohci: make ohci_t the first member in private data

2018-06-17 Thread Marek Vasut
On 06/17/2018 06:13 PM, Vasily Khoruzhick wrote: > ohci-hcd casts priv_data pointer to (ohci_t *), thus it must be > the first member in private data struct. > > Fixes 831cc98b1 ("usb: sunxi: Simplify ccm reg base code") > > Signed-off-by: Vasily Khoruzhick Sigh, I really wonder how (or if at a

[U-Boot] [PATCH] usb: sunxi: ohci: make ohci_t the first member in private data

2018-06-17 Thread Vasily Khoruzhick
ohci-hcd casts priv_data pointer to (ohci_t *), thus it must be the first member in private data struct. Fixes 831cc98b1 ("usb: sunxi: Simplify ccm reg base code") Signed-off-by: Vasily Khoruzhick --- drivers/usb/host/ohci-sunxi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi