Re: [U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Hi, 2010/12/1 Lei Wen : > Since the ether may not be the only one usb gadget would be used > in the uboot, it is neccessary to do the register each time the > eth begin to work to make usb gadget driver less confussed when > we want to use two different usb gadget at the same time. > > Usb gadget

Re: [U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Hi Vitaly, On Fri, Dec 3, 2010 at 12:34 AM, Vitaly Kuzmichev wrote: > Hi Lei, > > Lei Wen wrote: >> Since the ether may not be the only one usb gadget would be used >> in the uboot, it is neccessary to do the register each time the >> eth begin to work to make usb gadget driver less confussed whe

Re: [U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Hi Lei, Lei Wen wrote: > Since the ether may not be the only one usb gadget would be used > in the uboot, it is neccessary to do the register each time the > eth begin to work to make usb gadget driver less confussed when > we want to use two different usb gadget at the same time. > > Usb gadget

[U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Since the ether may not be the only one usb gadget would be used in the uboot, it is neccessary to do the register each time the eth begin to work to make usb gadget driver less confussed when we want to use two different usb gadget at the same time. Usb gadget driver could simple ignore the regis

Re: [U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Hi Vitaly, On Wed, Dec 1, 2010 at 12:41 AM, Vitaly Kuzmichev wrote: > Hi Lei, > > Lei Wen wrote: >> [...] For current ether.c state, there is no usb_gadget_unregister_driver in it. Even it has, we still need usb_gadget_register_driver call in each eth_init(). >>> >>> Yes, if we do

Re: [U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Hi Lei, Lei Wen wrote: > [...] >>> For current ether.c state, there is no usb_gadget_unregister_driver in >>> it. Even it has, we still need >>> usb_gadget_register_driver call in each eth_init(). >> >> Yes, if we do 'unregister' we should do 'register' somewhere before. If >> we do 'register' we

Re: [U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Hi Vitaly, On Tue, Nov 30, 2010 at 11:13 PM, Vitaly Kuzmichev wrote: > Hi Lei, > > Lei Wen wrote: >> Hi Vitaly, >> [...] >>> And additional calling of usb_gadget_unregister_driver will at most >>> return an error. >>> >> >> For current ether.c state, there is no usb_gadget_unregister_driver in >>

Re: [U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Hi Lei, Lei Wen wrote: > Hi Vitaly, > [...] >> And additional calling of usb_gadget_unregister_driver will at most >> return an error. >> > > For current ether.c state, there is no usb_gadget_unregister_driver in > it. Even it has, we still need > usb_gadget_register_driver call in each eth_init(

Re: [U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Hi Vitaly, On Mon, Nov 29, 2010 at 9:56 PM, Vitaly Kuzmichev wrote: > Hi Lei, > > Lei Wen wrote: >> Hi Vitaly, >> [...] +     if (usb_gadget_register_driver(ð_driver) < 0) +             goto fail; >>> >>> You probably need then at least to remove usb_gadget_register_driver >>> call from

Re: [U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Vitaly Kuzmichev wrote: > Hi Lei, > > Lei Wen wrote: >> Hi Vitaly, >> [...] + if (usb_gadget_register_driver(ð_driver) < 0) + goto fail; >>> >>> You probably need then at least to remove usb_gadget_register_driver >>> call from usb_eth_initialize. And add usb_gadget_unreg

Re: [U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Hi Lei, Lei Wen wrote: > Hi Vitaly, > [...] >>> + if (usb_gadget_register_driver(ð_driver) < 0) >>> + goto fail; >> >> You probably need then at least to remove usb_gadget_register_driver >> call from usb_eth_initialize. And add usb_gadget_unregister_driver in >> usb_eth_halt. > >

Re: [U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Hi Vitaly, On Sat, Nov 27, 2010 at 2:23 AM, Vitaly Kuzmichev wrote: > Hi Lei, > > Lei Wen wrote: >> Since the ether may not be the only one usb gadget would be used >> in the uboot, it is neccessary to do the register each time the >> eth begin to work to make usb gadget driver less confussed whe

Re: [U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Hi Lei, Lei Wen wrote: > Since the ether may not be the only one usb gadget would be used > in the uboot, it is neccessary to do the register each time the > eth begin to work to make usb gadget driver less confussed when > we want to use two different usb gadget at the same time. > [...] > @@ -17

[U-Boot] [PATCH] usb_ether: register usb ethernet gadget at each eth init

Since the ether may not be the only one usb gadget would be used in the uboot, it is neccessary to do the register each time the eth begin to work to make usb gadget driver less confussed when we want to use two different usb gadget at the same time. Usb gadget driver could simple ignore the regis