Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-09-17 Thread Eric Nelson
Hi Anatolij, I hate to come in late to the discussion, but while testing [1] with cache enabled, I started down the path of fixing up code paths within drivers/video/cfb_console.c that are followed by SABRE Lite as you did in [2]. [1] [PATCH V2 0/2] i.MX6: mx6qsabrelite: Add splash

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-07-19 Thread Mike Frysinger
On Tuesday 05 June 2012 03:28:40 Anatolij Gustschin wrote: On Sat, 28 Apr 2012 17:04:07 +0200 Anatolij Gustschin wrote: Data cache flushing is required for frame buffer in RAM to fix the distorted console text output. Currently this text distortion is observed with cfb on beageboard and

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-07-19 Thread Marek Vasut
Dear Mike Frysinger, On Tuesday 05 June 2012 03:28:40 Anatolij Gustschin wrote: On Sat, 28 Apr 2012 17:04:07 +0200 Anatolij Gustschin wrote: Data cache flushing is required for frame buffer in RAM to fix the distorted console text output. Currently this text distortion is observed

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-07-19 Thread Mike Frysinger
On Thursday 19 July 2012 11:49:20 Marek Vasut wrote: Dear Mike Frysinger, On Tuesday 05 June 2012 03:28:40 Anatolij Gustschin wrote: On Sat, 28 Apr 2012 17:04:07 +0200 Anatolij Gustschin wrote: Data cache flushing is required for frame buffer in RAM to fix the distorted console text

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-06-05 Thread Anatolij Gustschin
On Sat, 28 Apr 2012 17:04:07 +0200 Anatolij Gustschin ag...@denx.de wrote: Data cache flushing is required for frame buffer in RAM to fix the distorted console text output. Currently this text distortion is observed with cfb on beageboard and N900 when running with data cache enabled.

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-30 Thread Anatolij Gustschin
Hi, On Mon, 30 Apr 2012 04:25:50 +0200 Marek Vasut ma...@denx.de wrote: ... observed with cfb on beageboard and N900 when running with data cache enabled. beagleboard ;-) Thanks for catching that!! ... @@ -553,6 +557,8 @@ static void video_drawchars(int xx, int yy, unsigned char *s,

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-30 Thread Marek Vasut
Dear Anatolij Gustschin, Hi, On Mon, 30 Apr 2012 04:25:50 +0200 Marek Vasut ma...@denx.de wrote: ... observed with cfb on beageboard and N900 when running with data cache enabled. beagleboard ;-) Thanks for catching that!! ... @@ -553,6 +557,8 @@ static void

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-30 Thread Anatolij Gustschin
Hi, On Mon, 30 Apr 2012 17:21:51 +0200 Marek Vasut ma...@denx.de wrote: ... Can't you have SRAM cached too? ;-) I do not know. But who will put the framebuffer into SRAM? It is not big enough. Someone who has small LCD and wants to save dram bandwidth (oh, this sentence sounds

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-30 Thread Anatolij Gustschin
Hi Mike, On Sat, 28 Apr 2012 14:16:39 -0400 Mike Frysinger vap...@gentoo.org wrote: On Saturday 28 April 2012 11:04:07 Anatolij Gustschin wrote: +static int cfb_fb_is_in_dram(void) +{ + bd_t *bd = gd-bd; + ulong start, end; + int i; + + for (i = 0; i CONFIG_NR_DRAM_BANKS;

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-30 Thread Marek Vasut
Dear Anatolij Gustschin, Hi, On Mon, 30 Apr 2012 17:21:51 +0200 Marek Vasut ma...@denx.de wrote: ... Can't you have SRAM cached too? ;-) I do not know. But who will put the framebuffer into SRAM? It is not big enough. Someone who has small LCD and wants to save dram

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-30 Thread Anatolij Gustschin
Hi Simon, On Sun, 29 Apr 2012 22:56:01 -0700 Simon Glass s...@chromium.org wrote: ... Regarding this patch, can I suggest also looking at this possibly more generic patch that I originally did for Tegra? The series is here: http://patchwork.ozlabs.org/user/bundle/2869/ and in particular

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-30 Thread Mike Frysinger
On Monday 30 April 2012 11:32:21 Anatolij Gustschin wrote: On Sat, 28 Apr 2012 14:16:39 -0400 Mike Frysinger wrote: On Saturday 28 April 2012 11:04:07 Anatolij Gustschin wrote: +static int cfb_fb_is_in_dram(void) +{ + bd_t *bd = gd-bd; + ulong start, end; + int i; + + for

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-29 Thread Marek Vasut
Dear Anatolij Gustschin, Data cache flushing is required for frame buffer in RAM to fix the distorted console text output. Currently this text distortion is observed with cfb on beageboard and N900 when running with data cache enabled. beagleboard ;-) Reported-by: Pali Rohár

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-29 Thread Simon Glass
Hi, On Sun, Apr 29, 2012 at 7:25 PM, Marek Vasut ma...@denx.de wrote: Dear Anatolij Gustschin, Data cache flushing is required for frame buffer in RAM to fix the distorted console text output. Currently this text distortion is observed with cfb on beageboard and N900 when running with

[U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-28 Thread Anatolij Gustschin
Data cache flushing is required for frame buffer in RAM to fix the distorted console text output. Currently this text distortion is observed with cfb on beageboard and N900 when running with data cache enabled. Reported-by: Pali Rohár pali.ro...@gmail.com Signed-off-by: Anatolij Gustschin

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-28 Thread Pali Rohár
On Saturday 28 April 2012 17:04:07 you wrote: Data cache flushing is required for frame buffer in RAM to fix the distorted console text output. Currently this text distortion is observed with cfb on beageboard and N900 when running with data cache enabled. Reported-by: Pali Rohár

Re: [U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

2012-04-28 Thread Mike Frysinger
On Saturday 28 April 2012 11:04:07 Anatolij Gustschin wrote: +static int cfb_fb_is_in_dram(void) +{ + bd_t *bd = gd-bd; + ulong start, end; + int i; + + for (i = 0; i CONFIG_NR_DRAM_BANKS; ++i) { +#if defined(CONFIG_ARM) || defined(CONFIG_AVR32) || defined(COFNIG_NDS32)