Re: [U-Boot] [PATCH] x86: Use microcode update from device tree for all processors

2018-06-11 Thread Bin Meng
Hi Ivan, On Sat, Apr 21, 2018 at 1:47 AM, Ivan Gorinov wrote: > Hi Bin, > > On Wed, Apr 18, 2018 at 07:05:28PM -0600, Bin Meng wrote: >> >> > >> >> > If there is no ROM image, ucode_base and ucode_size are not initialized >> >> > and >> >> > the microcode update data from DTB applied by microcod

Re: [U-Boot] [PATCH] x86: Use microcode update from device tree for all processors

2018-04-20 Thread Ivan Gorinov
Hi Bin, On Wed, Apr 18, 2018 at 07:05:28PM -0600, Bin Meng wrote: > >> > > >> > If there is no ROM image, ucode_base and ucode_size are not initialized > >> > and > >> > the microcode update data from DTB applied by microcode_update_intel() > >> > to the > >> > bootstrap CPU is not used by the m

Re: [U-Boot] [PATCH] x86: Use microcode update from device tree for all processors

2018-04-18 Thread Bin Meng
Hi Ivan, On Thu, Apr 19, 2018 at 8:11 AM, Ivan Gorinov wrote: > Hi Bin, > > On Wed, Apr 18, 2018 at 06:48:59AM -0600, Bin Meng wrote: >> >> I don't understand what the bug is here. The AP microcode update is >> >> done in sipi_vector.S. >> > >> > I have found how it works. When a ROM image is bui

Re: [U-Boot] [PATCH] x86: Use microcode update from device tree for all processors

2018-04-18 Thread Ivan Gorinov
Hi Bin, On Wed, Apr 18, 2018 at 06:48:59AM -0600, Bin Meng wrote: > >> I don't understand what the bug is here. The AP microcode update is > >> done in sipi_vector.S. > > > > I have found how it works. When a ROM image is built, the binman tool > > looks for symbol '_dt_ucode_base_size' and update

Re: [U-Boot] [PATCH] x86: Use microcode update from device tree for all processors

2018-04-18 Thread Bin Meng
Hi Ivan, On Wed, Apr 18, 2018 at 2:29 AM, Ivan Gorinov wrote: > On Thu, Apr 05, 2018 at 09:31:34AM -0600, Bin Meng wrote: >> > The microcode update data block encoded in Device Tree is used by >> > the bootstrap processor (BSP) but not passed to the other CPUs (AP). >> >> I don't understand what

Re: [U-Boot] [PATCH] x86: Use microcode update from device tree for all processors

2018-04-17 Thread Ivan Gorinov
On Thu, Apr 05, 2018 at 09:31:34AM -0600, Bin Meng wrote: > > The microcode update data block encoded in Device Tree is used by > > the bootstrap processor (BSP) but not passed to the other CPUs (AP). > > I don't understand what the bug is here. The AP microcode update is > done in sipi_vector.S.

Re: [U-Boot] [PATCH] x86: Use microcode update from device tree for all processors

2018-04-05 Thread Bin Meng
Hi Ivan, On Thu, Apr 5, 2018 at 7:07 AM, Ivan Gorinov wrote: > The microcode update data block encoded in Device Tree is used by > the bootstrap processor (BSP) but not passed to the other CPUs (AP). > I don't understand what the bug is here. The AP microcode update is done in sipi_vector.S. >

Re: [U-Boot] [PATCH] x86: Use microcode update from device tree for all processors

2018-04-05 Thread Andy Shevchenko
On Wed, 2018-04-04 at 16:07 -0700, Ivan Gorinov wrote: > The microcode update data block encoded in Device Tree is used by > the bootstrap processor (BSP) but not passed to the other CPUs (AP). BSP abbreviation is confusing. AP is even more looking to preceding words. I don't see either where they

[U-Boot] [PATCH] x86: Use microcode update from device tree for all processors

2018-04-04 Thread Ivan Gorinov
The microcode update data block encoded in Device Tree is used by the bootstrap processor (BSP) but not passed to the other CPUs (AP). If the bootstrap processor successfully performs a microcode update from Device Tree, use the same data block for the other processors. Signed-off-by: Ivan Gorino