Re: [U-Boot] [PATCH 0/5] New environment code

2010-12-08 Thread Mike Frysinger
On Saturday, July 17, 2010 15:45:43 Wolfgang Denk wrote: TODO: - drop default env as implemented now; provide a text file based initialization instead (eventually using several text files to incrementally build it from common blocks) and a tool to convert it into a binary blob /

Re: [U-Boot] [PATCH 0/5] New environment code

2010-12-08 Thread Wolfgang Denk
Dear Mike Frysinger, In message 201012080456.41492.vap...@gentoo.org you wrote: seems that some todo items are missing, or not well implied. for example, it seems that gd-env_addr needs to be punted, and these functions get a _f appended to their name since they only work on

Re: [U-Boot] [PATCH 0/5] New environment code

2010-12-08 Thread Mike Frysinger
On Wednesday, December 08, 2010 05:04:42 Wolfgang Denk wrote: Mike Frysinger wrote: seems that some todo items are missing, or not well implied. for example, it seems that gd-env_addr needs to be punted, and these functions get a _f appended to their name since they only work on

Re: [U-Boot] [PATCH 0/5] New environment code

2010-10-20 Thread Mike Frysinger
On Saturday, July 17, 2010 15:45:43 Wolfgang Denk wrote: The following patch series adds some utilities (qsort and hash table based database functions) and uses these to reimplement the code used for the internal handling of environment variables. seems to break autocompletion

Re: [U-Boot] [PATCH 0/5] New environment code

2010-10-20 Thread Wolfgang Denk
Dear Mike Frysinger, In message 201010200408.15020.vap...@gentoo.org you wrote: The following patch series adds some utilities (qsort and hash table based database functions) and uses these to reimplement the code used for the internal handling of environment variables. seems to break

Re: [U-Boot] [PATCH 0/5] New environment code

2010-07-18 Thread Wolfgang Denk
Dear Reinhard Meyer, In message 4c4291ee.5060...@emk-elektronik.de you wrote: But, how does the timing look in the current implementation when the CRC calculation is done only in the saveenv command? I don't know. Much better for the old code, obviously. But you still have the efforts for

[U-Boot] [PATCH 0/5] New environment code

2010-07-17 Thread Wolfgang Denk
The following patch series adds some utilities (qsort and hash table based database functions) and uses these to reimplement the code used for the internal handling of environment variables. Motivation: * Old environment code used a pessimizing implementation: - variable lookup used linear

Re: [U-Boot] [PATCH 0/5] New environment code

2010-07-17 Thread Wolfgang Denk
In message 1279395948-25864-1-git-send-email...@denx.de you wrote: The following patch series adds some utilities (qsort and hash table based database functions) and uses these to reimplement the code used for the internal handling of environment variables. Note: the patches are also available

Re: [U-Boot] [PATCH 0/5] New environment code

2010-07-17 Thread Reinhard Meyer
Wolfgang Denk wrote: The following patch series adds some utilities (qsort and hash table based database functions) and uses these to reimplement the code used for the internal handling of environment variables. Motivation: * Old environment code used a pessimizing implementation: -

Re: [U-Boot] [PATCH 0/5] New environment code

2010-07-17 Thread Mike Frysinger
On Saturday, July 17, 2010 16:56:43 Reinhard Meyer wrote: Wolfgang Denk wrote: Disadvantages: - Image size grows by typically 5...7 KiB (might shrink a bit again on systems with redundant environment with a following patch series) Looking at the patches I can't really see where

Re: [U-Boot] [PATCH 0/5] New environment code

2010-07-17 Thread Wolfgang Denk
Dear Reinhard Meyer, In message 4c42190b.8060...@emk-elektronik.de you wrote: how many users are out there that have such huge environments that speed is of any concern? This is not so much a question of huge environments. Even with small environments (say, 2 kb) speed may quickly become an

Re: [U-Boot] [PATCH 0/5] New environment code

2010-07-17 Thread Wolfgang Denk
Dear Mike Frysinger, In message 201007171728.27716.vap...@gentoo.org you wrote: i wonder if we could #ifdef the sorting/hashing. i tend to agree with The sorting does not take much: - size lib/qsort.o textdata bss dec hex filename 264 0

Re: [U-Boot] [PATCH 0/5] New environment code

2010-07-17 Thread Mike Frysinger
On Saturday, July 17, 2010 17:41:57 Wolfgang Denk wrote: Mike Frysinger wrote: Reinhard that it is very common for boards to be deployed with a small env, so i wonder if the normal runtime experience is actually faster, or if the difference is about the same as system noise: boot u-boot,

Re: [U-Boot] [PATCH 0/5] New environment code

2010-07-17 Thread Reinhard Meyer
Wolfgang Denk wrote: Just to give a datapoint for speed: measured on TQM5200 (MPC5200 at 400 MHz, environment size 16 kB): OLD implementation: = sete ttt 'date;for i in 0 1 2 3 4 5 6 7 8 9 ; do for j in 0 1 2 3 4 5 6 7 8 9 ; do for k in 0 1 2 3 4 5 6 7 8 9 ; do run tt ; done ; done