[U-Boot] [PATCH 01/11] ext4: Split write support into its own file

2012-12-26 Thread Simon Glass
This code seems to be entirely othogonal, so remove the #ifdef and put the condition in the Makefile instead. Signed-off-by: Simon Glass --- fs/ext4/Makefile |2 +- fs/ext4/ext4_write.c | 996 ++ fs/ext4/ext4fs.c | 963 ---

Re: [U-Boot] [PATCH 01/11] ext4: Split write support into its own file

2013-02-07 Thread Lukasz Majewski
Hi Simon, > > > This code seems to be entirely othogonal, so remove the #ifdef and > > put the condition in the Makefile instead. > > I'm fully with you in respect of cleaning/refactoring the ext4 u-boot > code. > > I will test this change when I only find some time ... > Are you doing any wo

Re: [U-Boot] [PATCH 01/11] ext4: Split write support into its own file

2013-02-07 Thread Simon Glass
Hi Lukasz, On Thu, Feb 7, 2013 at 3:35 AM, Lukasz Majewski wrote: > Hi Simon, > >> >> > This code seems to be entirely othogonal, so remove the #ifdef and >> > put the condition in the Makefile instead. >> >> I'm fully with you in respect of cleaning/refactoring the ext4 u-boot >> code. >> >> I w

Re: [U-Boot] [PATCH 01/11] ext4: Split write support into its own file

2013-02-07 Thread Lukasz Majewski
Hi Simon, > Hi Lukasz, > > On Thu, Feb 7, 2013 at 3:35 AM, Lukasz Majewski > wrote: > > Hi Simon, > > > >> > >> > This code seems to be entirely othogonal, so remove the #ifdef > >> > and put the condition in the Makefile instead. > >> > >> I'm fully with you in respect of cleaning/refactoring t

Re: [U-Boot] [PATCH 01/11] ext4: Split write support into its own file

2013-03-01 Thread Tom Rini
On Wed, Dec 26, 2012 at 11:53:28AM -0800, Simon Glass wrote: > This code seems to be entirely othogonal, so remove the #ifdef and put > the condition in the Makefile instead. > > Signed-off-by: Simon Glass Reveiwed-by: Tom Rini -- Tom signature.asc Description: Digital signature __

Re: [U-Boot] [PATCH 01/11] ext4: Split write support into its own file

2012-12-27 Thread Lukasz Majewski
Hi Simon, > This code seems to be entirely othogonal, so remove the #ifdef and put > the condition in the Makefile instead. I'm fully with you in respect of cleaning/refactoring the ext4 u-boot code. I will test this change when I only find some time ... -- Best regards, Lukasz Majewski Sams