Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

2009-07-23 Thread Ben Warren
Jean-Christophe PLAGNIOL-VILLARD wrote: > On 22:24 Wed 22 Jul , Ben Warren wrote: > >> Jean-Christophe PLAGNIOL-VILLARD wrote: >> > -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) > -OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) > +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) $(

Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

2009-07-23 Thread Jean-Christophe PLAGNIOL-VILLARD
On 22:24 Wed 22 Jul , Ben Warren wrote: > Jean-Christophe PLAGNIOL-VILLARD wrote: > >>>-SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) > >>>-OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) > >>>+SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c) > >>>+OBJS := $(addprefix $(obj),$(S

Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

2009-07-22 Thread Ben Warren
Eric Bénard wrote: > Ben Warren wrote : >> This patch has many coding style violations that haven't been >> addressed, so it can't go in. I"m not a fan of the piece-meal PHY >> implementation > > coding style violations should be fixed in v3 / > http://www.mail-archive.com/u-boot@lists.denx.de/

Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

2009-07-22 Thread Eric Bénard
Ben Warren wrote : > This patch has many coding style violations that haven't been addressed, > so it can't go in. I"m not a fan of the piece-meal PHY implementation coding style violations should be fixed in v3 / http://www.mail-archive.com/u-boot@lists.denx.de/msg18068.html Eric

Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

2009-07-22 Thread Ben Warren
Jean-Christophe PLAGNIOL-VILLARD wrote: >>> >>> -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) >>> -OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) >>> +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c) >>> +OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y)) >>> >>> al

Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

2009-07-22 Thread Jean-Christophe PLAGNIOL-VILLARD
> > > > -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) > > -OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) > > +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c) > > +OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y)) > > > > all: $(obj).depend $(LIB) > > > >

Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

2009-07-18 Thread Wolfgang Denk
Dear Eric Benard, In message <1247947830-22602-1-git-send-email-e...@eukrea.com> you wrote: > CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR > flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII > mode. > > Signed-off-by: Eric Benard > --- Your subject li

[U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

2009-07-18 Thread Eric Benard
CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII mode. Signed-off-by: Eric Benard --- MAINTAINERS |6 +- MAKEALL |3 +- Makefile|

Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

2009-07-18 Thread Jean-Christophe PLAGNIOL-VILLARD
On 19:14 Sat 18 Jul , Eric Bénard wrote: > Jean-Christophe PLAGNIOL-VILLARD wrote : > >> + > >> +cpuat91_ram_config \ > >> +cpuat91_config:unconfig > >> +@if [ "$(findstring _ram_,$@)" ] ; then \ > >> +echo "#define CONFIG_CPUAT91_RAM 1" >> ./include/config.h ; \ > > what is

Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

2009-07-18 Thread Eric Bénard
Jean-Christophe PLAGNIOL-VILLARD wrote : >> + >> +cpuat91_ram_config \ >> +cpuat91_config:unconfig >> +@if [ "$(findstring _ram_,$@)" ] ; then \ >> +echo "#define CONFIG_CPUAT91_RAM 1" >> ./include/config.h ; \ > what is this ram config? the ram config allows to generate a

Re: [U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

2009-07-18 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:24 Thu 16 Jul , Eric Benard wrote: > CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR > flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII > mode. > > Signed-off-by: Eric Benard > --- > MAINTAINERS |6 +- > MAKEALL

[U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

2009-07-16 Thread Eric Benard
CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII mode. Signed-off-by: Eric Benard --- MAINTAINERS |6 +- MAKEALL |3 +- Makefile|