Re: [U-Boot] [PATCH 1/1] Adding MSCC PHY-VSC8530-VSC8531-VSC8540-VSC8541

Brodkin <alexey.brod...@synopsys.com> >> Cc: john.haech...@microsemi.com; u-boot@lists.denx.de; joe.hershber...@ni.com >> Subject: Re: [U-Boot] [PATCH 1/1] Adding MSCC >> PHY-VSC8530-VSC8531-VSC8540-VSC8541 >> >> Hi Alexey, >> >> Thanks for the review. I a

Re: [U-Boot] [PATCH 1/1] Adding MSCC PHY-VSC8530-VSC8531-VSC8540-VSC8541

gt; Subject: Re: [U-Boot] [PATCH 1/1] Adding MSCC > PHY-VSC8530-VSC8531-VSC8540-VSC8541 > > Hi Alexey, > > Thanks for the review. I agree with most of your comments, but I'll > note where I don't. > > On Thu, Dec 8, 2016 at 6:24 AM, Alexey Brodkin > <alexey.bro

Re: [U-Boot] [PATCH 1/1] Adding MSCC PHY-VSC8530-VSC8531-VSC8540-VSC8541

Hi John, I have some additional comments beyond Alexey's. On Wed, Dec 7, 2016 at 11:11 AM, John Haechten wrote: > From 127c5fb9ef390cad5cf58e446110a696cf111345 Mon Sep 17 00:00:00 2001 > From: John Haechten > Date: Wed, 7 Dec 2016

Re: [U-Boot] [PATCH 1/1] Adding MSCC PHY-VSC8530-VSC8531-VSC8540-VSC8541

Hi Alexey, Thanks for the review. I agree with most of your comments, but I'll note where I don't. On Thu, Dec 8, 2016 at 6:24 AM, Alexey Brodkin wrote: ... >> +static int mscc_vsc8531_vsc8541_init_scripts(struct phy_device *phydev) >> +{ >> + u16 reg_val17;

Re: [U-Boot] [PATCH 1/1] Adding MSCC PHY-VSC8530-VSC8531-VSC8540-VSC8541

Hi John, First of all I'm wondering if there was a real need to add that many people in Cc? Normally sybsystem maintainer and active contributors to code you modified are good options here. Then have you run your patch through checkpatch? Obviously it was not the case because it says me:

[U-Boot] [PATCH 1/1] Adding MSCC PHY-VSC8530-VSC8531-VSC8540-VSC8541

>From 127c5fb9ef390cad5cf58e446110a696cf111345 Mon Sep 17 00:00:00 2001 From: John Haechten Date: Wed, 7 Dec 2016 07:51:37 -0800 Subject: [PATCH] Adding MSCC PHY-VSC8530-VSC8531-VSC8540-VSC8541 (C) Copyright 2016 Microsemi Corporation, MIT License (MIT) Author:John