The folowing patch tries to fix all defects of the previous patch.
The new led command is _not_ limited to 3 LEDs any more, but it
is still restricted to at91 architectures.
Best regards,
Daniel Gorsulowski
___
U-Boot mailing list
U-Boot@lists.denx.de
Hi Daniel,
On Friday 08 May 2009, Daniel Gorsulowski wrote:
I suggest to use something like this here:
led_nr = simple_strtoul(argv[1], NULL, 10);
if (led_nr CONFIG_LED_MAX) {
printf (Usage:\n%s\n, cmdtp-usage);
return 1;
}
if
Dear Wolfgang Denk,
Wolfgang Denk wrote:
Dear Daniel Gorsulowski,
In message 1241619669338-git-send-email-daniel.gorsulow...@esd.eu you wrote:
This patch allows any at91 board, implementing the GPIO LED API,
to control the LEDs from the console.
led [ 1 | 2 | 3 | all ] [ on | off ]
Hi Daniel,
On Wednesday 06 May 2009, Daniel Gorsulowski wrote:
This patch allows any at91 board, implementing the GPIO LED API,
to control the LEDs from the console.
led [ 1 | 2 | 3 | all ] [ on | off ]
Why limit this to a max of 3 LED's? If this is a generic command (which I like
btw)
Dear Daniel Gorsulowski,
In message 4a02792b.8060...@esd.eu you wrote:
Ummm... common is for, well, for common stuff. If this code is
specific to AT91 only, it should not go into common.
IMHO this code is not specific to AT91 only. Well, other architectures does
not
support the
Hi Stefan,
Stefan Roese wrote:
Hi Daniel,
On Wednesday 06 May 2009, Daniel Gorsulowski wrote:
This patch allows any at91 board, implementing the GPIO LED API,
to control the LEDs from the console.
led [ 1 | 2 | 3 | all ] [ on | off ]
Why limit this to a max of 3 LED's? If this is a
Wolfgang Denk schrieb:
Dear Daniel Gorsulowski,
In message 4a02792b.8060...@esd.eu you wrote:
Ummm... common is for, well, for common stuff. If this code is
specific to AT91 only, it should not go into common.
IMHO this code is not specific to AT91 only. Well, other architectures does
This patch allows any at91 board, implementing the GPIO LED API,
to control the LEDs from the console.
led [ 1 | 2 | 3 | all ] [ on | off ]
Adding configuration items CONFIG_AT91_LED and CONFIG_CMD_LED
enables the command.
Moreover the GPIO Pins have to be defined by CONFIG_USER1_LED ...
Dear Daniel Gorsulowski,
In message 1241619669338-git-send-email-daniel.gorsulow...@esd.eu you wrote:
This patch allows any at91 board, implementing the GPIO LED API,
to control the LEDs from the console.
led [ 1 | 2 | 3 | all ] [ on | off ]
Adding configuration items CONFIG_AT91_LED and
On Wednesday 06 May 2009 16:37:28 Wolfgang Denk wrote:
In message Daniel Gorsulowski wrote:
--- a/common/Makefile
+++ b/common/Makefile
+COBJS-$(CONFIG_CMD_LED) += cmd_led.o
Ummm... common is for, well, for common stuff. If this code is
specific to AT91 only, it should not go into
10 matches
Mail list logo
