[U-Boot] [PATCH 1/2]: common: Add a watchdog CLI command

2009-10-28 Thread Simon Kagstrom
A watchdog command to enable the watchdog with a timeout or disable it can sometimes be useful. Add that. This also adds a common API for enabling or disabling watchdogs. The API is simple: void watchdog_enable(unsigned int timeout); void watchdog_disable(void); disabling the

Re: [U-Boot] [PATCH 1/2]: common: Add a watchdog CLI command

2009-10-28 Thread Prafulla Wadaskar
-Original Message- From: Simon Kagstrom [mailto:simon.kagst...@netinsight.net] Sent: Wednesday, October 28, 2009 7:44 PM To: U-Boot ML; Prafulla Wadaskar Subject: [PATCH 1/2]: common: Add a watchdog CLI command A watchdog command to enable the watchdog with a timeout or disable

Re: [U-Boot] [PATCH 1/2]: common: Add a watchdog CLI command

2009-10-28 Thread Simon Kagstrom
On Wed, 28 Oct 2009 07:29:35 -0700 Prafulla Wadaskar prafu...@marvell.com wrote: +static int do_watchdog(cmd_tbl_t *cmdtp, int flag, int argc, + if (timeout 0) + goto usage; How about passing zero value here, will it be a correct input for watchdog_enable? Good point,

Re: [U-Boot] [PATCH 1/2]: common: Add a watchdog CLI command

2009-10-28 Thread Wolfgang Denk
Dear Simon Kagstrom, In message 20091028154925.1dd1a...@marrow.netinsight.se you wrote: Can we check for some error code here from lower layer and dump some error message? For ex. Specified timeout value may be invalid for specific h/w We could, but I'd like to keep the interface