Re: [U-Boot] [PATCH 1/2] common/console: coding style cleanup

Dear Jean-Christophe PLAGNIOL-VILLARD, In message <20090201130727.gf9...@game.jcrosoft.org> you wrote: > > > > -static int iomux_getc(void) > > > +static int iomux_getc (void) > > ... > > > -static int iomux_tstc(int file) > > > +static int iomux_tstc (int file) > > > > NAK. > > > > This Linux k

Re: [U-Boot] [PATCH 1/2] common/console: coding style cleanup

On 12:32 Sun 01 Feb , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <1233486771-10411-1-git-send-email-plagn...@jcrosoft.com> you > wrote: > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > --- > > common/console.c | 97 > >

Re: [U-Boot] [PATCH 1/2] common/console: coding style cleanup

Dear Jean-Christophe PLAGNIOL-VILLARD, I wrote: > This Linux kernel coding style does NOT insert spaces between > function names; your patch makes the style worse, not better. I meant: ...between function names and opening paren. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: [U-Boot] [PATCH 1/2] common/console: coding style cleanup

Dear Jean-Christophe PLAGNIOL-VILLARD, In message <1233486771-10411-1-git-send-email-plagn...@jcrosoft.com> you wrote: > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > --- > common/console.c | 97 > -- > 1 files changed, 50 insertions(+),

[U-Boot] [PATCH 1/2] common/console: coding style cleanup

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD --- common/console.c | 97 -- 1 files changed, 50 insertions(+), 47 deletions(-) diff --git a/common/console.c b/common/console.c index 89aeab6..851b0f8 100644 --- a/common/console.c +++ b/commo