Re: [U-Boot] [PATCH 1/2] drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver

2013-01-24 Thread Frank Dols
Hi Vipin, On Wed, 23 Jan 2013 15:46:31 +0530, Vipin Kumar vipin.ku...@st.com wrote: My first feeling is that the descriptors are allocated as Normal Cachabale memory and it would not help to access them using readl/writel ... And no, we don't need to allocate them non-cacheable,

Re: [U-Boot] [PATCH 1/2] drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver

2013-01-23 Thread Vipin Kumar
On 1/23/2013 12:25 PM, Albert ARIBAUD wrote: Hi Vipin, My first feeling is that the descriptors are allocated as Normal Cachabale memory and it would not help to access them using readl/writel Should the desciptors be allocated as non-cachable memory. If yes then how to do that in u-boot I

Re: [U-Boot] [PATCH 1/2] drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver

2013-01-23 Thread Albert ARIBAUD
Hi Vipin, On Wed, 23 Jan 2013 15:46:31 +0530, Vipin Kumar vipin.ku...@st.com wrote: On 1/23/2013 12:25 PM, Albert ARIBAUD wrote: Hi Vipin, My first feeling is that the descriptors are allocated as Normal Cachabale memory and it would not help to access them using readl/writel Should

[U-Boot] [PATCH 1/2] drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver able

2013-01-22 Thread Frank Dols
Signed-off-by: Frank Dols frank.d...@synopsys.com --- drivers/net/designware.c | 108 +++--- drivers/net/designware.h |4 +- 2 files changed, 66 insertions(+), 46 deletions(-) diff --git a/drivers/net/designware.c b/drivers/net/designware.c index

Re: [U-Boot] [PATCH 1/2] drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver

2013-01-22 Thread Vipin Kumar
Provide a short patch title and a longer description in the patch itself. that would be much more readable On 1/22/2013 7:40 PM, Frank Dols wrote: Signed-off-by: Frank Dolsfrank.d...@synopsys.com --- drivers/net/designware.c | 108 +++---

Re: [U-Boot] [PATCH 1/2] drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver

2013-01-22 Thread Albert ARIBAUD
Hi Vipin, My first feeling is that the descriptors are allocated as Normal Cachabale memory and it would not help to access them using readl/writel Should the desciptors be allocated as non-cachable memory. If yes then how to do that in u-boot I suppose the rest of the code would be