Re: [U-Boot] [PATCH 1/2] env: Don't print "Failed" error message

2018-07-20 Thread Sam Protsenko
On Fri, Jul 20, 2018 at 4:29 PM, Wolfgang Denk wrote: > Dear Sam, > > In message <20180720131421.7136-2-semen.protse...@linaro.org> you wrote: >> >> + if (!ret) >> printf("OK\n"); >> >> if (!ret) > > Now we have two "if (!ret)" in sequence. Make thi

Re: [U-Boot] [PATCH 1/2] env: Don't print "Failed" error message

2018-07-20 Thread Wolfgang Denk
Dear Sam, In message <20180720131421.7136-2-semen.protse...@linaro.org> you wrote: > > + if (!ret) > printf("OK\n"); > > if (!ret) Now we have two "if (!ret)" in sequence. Make this one block, please. Best regards, Wolfgang Denk -- DENX Softw

[U-Boot] [PATCH 1/2] env: Don't print "Failed" error message

2018-07-20 Thread Sam Protsenko
"Failed" error message from env_load() only clutters the log with unnecessary details, as we already have all needed warnings by that time. Example: Loading Environment from FAT... MMC: no card present ** Bad device mmc 0 ** Failed (-5) Remove this "Failed" message to keep log short a