Re: [U-Boot] [PATCH 1/2] fit: Support FDT compression

2019-04-18 Thread Julius Werner
> Hmm, I think we might want to use the lmb functions here to allocate a > buffer instead of relyling on malloc? The malloc pool might be large > enough for an uncompressed devicetree, but not for an 8 MByte FPGA image... > > But starting with malloc might be ok. Okay, that sounds like a good poss

Re: [U-Boot] [PATCH 1/2] fit: Support FDT compression

2019-04-18 Thread Simon Goldschmidt
On 18.04.19 22:36, Julius Werner wrote: My approach was to uncompress all compressed images on-the-fly in fit_image_load(). Right, that's essentially what this patch is doing too. Cool. I'm sorry I haven't found the time to dig into your patch for details (too much day-to-day work right no

Re: [U-Boot] [PATCH 1/2] fit: Support FDT compression

2019-04-18 Thread Julius Werner
> My approach was to uncompress all compressed images on-the-fly in > fit_image_load(). Right, that's essentially what this patch is doing too. > Or I could dig up my patches from October and we'll see how far you get > with those? I think I found your patch: https://lists.denx.de/pipermail/u-bo

Re: [U-Boot] [PATCH 1/2] fit: Support FDT compression

2019-04-18 Thread Simon Goldschmidt
On 18.04.19 21:59, Julius Werner wrote: Hi Simon, Is your approach similar to what I did here (decompressing transparently as part of fit_image_load())? I think I could easily expand this to other image types, I just don't always know how to test those. Really, the only thing that can't be dec

Re: [U-Boot] [PATCH 1/2] fit: Support FDT compression

2019-04-18 Thread Julius Werner
Hi Simon, Is your approach similar to what I did here (decompressing transparently as part of fit_image_load())? I think I could easily expand this to other image types, I just don't always know how to test those. Really, the only thing that can't be decompressed there is the kernel image (because

Re: [U-Boot] [PATCH 1/2] fit: Support FDT compression

2019-04-18 Thread Simon Goldschmidt
Hi Julius, On Thu, Apr 18, 2019 at 10:13 AM Julius Werner wrote: > > This patch adds support for compressing FDT image nodes in a FIT image > (equivalent to how kernel nodes can already be compressed). This can > reduce the size of FIT images (and therefore improve boot times). FDTs > will automa

[U-Boot] [PATCH 1/2] fit: Support FDT compression

2019-04-18 Thread Julius Werner
This patch adds support for compressing FDT image nodes in a FIT image (equivalent to how kernel nodes can already be compressed). This can reduce the size of FIT images (and therefore improve boot times). FDTs will automatically get decompressed on load. This patch does not support extracting com