Re: [U-Boot] [PATCH 1/2] lib_generic: gunzip: New function zunzip

2009-04-27 Thread Ricardo Ribalda Delgado
Hi Wolfgang > > In such a situation it would have been much better if you has reposted > a new patch series consisting of 3 parts (1/3, 2/3 and 3/3). Just sent a new patch series consisting 3 parts. Sorry for the top posting... -- Ricardo Ribalda http://www.eps.uam.es/~rribalda/

Re: [U-Boot] [PATCH 1/2] lib_generic: gunzip: New function zunzip

2009-04-27 Thread Stefan Roese
On Monday 27 April 2009, Ricardo Ribalda Delgado wrote: > There were 2 patch > > 1/2 ->: BUG realpath string must be ended with NULL" posting? > > 2/2 ->ubifs: BUG: Blocks commpressed with zlib" > > Since 1/2 has been applied. And 2/2 needed to be separated in two patches Just to clarify: Patch 1/

Re: [U-Boot] [PATCH 1/2] lib_generic: gunzip: New function zunzip

2009-04-27 Thread Wolfgang Denk
Dear Ricardo Ribalda Delgado, In message you wrote: > Sorry for the mess. > > > There were 2 patch > > 1/2 ->: BUG realpath string must be ended with NULL" posting? > > 2/2 ->ubifs: BUG: Blocks commpressed with zlib" > > Since 1/2 has been applied. And 2/2 needed to be separated in two patc

Re: [U-Boot] [PATCH 1/2] lib_generic: gunzip: New function zunzip

2009-04-27 Thread Wolfgang Denk
Dear Ricardo Ribalda Delgado, In message you wrote: > > > > Then please write this in the commit message of the patch. > > It is already written in the ubifs patch (#2) Shall I also add this to > this patch (#1), that only touches the gunzip file? How should anybody know why the gunzip file

Re: [U-Boot] [PATCH 1/2] lib_generic: gunzip: New function zunzip

2009-04-27 Thread Ricardo Ribalda Delgado
Sorry for the mess. There were 2 patch 1/2 ->: BUG realpath string must be ended with NULL" posting? 2/2 ->ubifs: BUG: Blocks commpressed with zlib" Since 1/2 has been applied. And 2/2 needed to be separated in two patches 1/2 -> lib_generic: gunzip: New function zunzip 2/2 -> ubifs: BUG: Blo

Re: [U-Boot] [PATCH 1/2] lib_generic: gunzip: New function zunzip

2009-04-27 Thread Wolfgang Denk
Dear Ricardo, In message you wrote: > > UBI fs blocks can be compresed in lzo, zlib or no-compression. The > current implementation of u-boot supported all the compressions but > there was a bug in the implementation of zlib. > UBIFS's Zlib blocks do not have header but they were compressed usi

Re: [U-Boot] [PATCH 1/2] lib_generic: gunzip: New function zunzip

2009-04-27 Thread Ricardo Ribalda Delgado
Hello > Then please write this in the commit message of the patch. It is already written in the ubifs patch (#2) Shall I also add this to this patch (#1), that only touches the gunzip file? Regards > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH,     MD: Wolfgang De

Re: [U-Boot] [PATCH 1/2] lib_generic: gunzip: New function zunzip

2009-04-27 Thread Wolfgang Denk
Dear Ricardo Ribalda Delgado, In message you wrote: > > UBI fs blocks can be compresed in lzo, zlib or no-compression. The > current implementation of u-boot supported all the compressions but > there was a bug in the implementation of zlib. > UBIFS's Zlib blocks do not have header but they wer

Re: [U-Boot] [PATCH 1/2] lib_generic: gunzip: New function zunzip

2009-04-27 Thread Ricardo Ribalda Delgado
Hello Wolfgang UBI fs blocks can be compresed in lzo, zlib or no-compression. The current implementation of u-boot supported all the compressions but there was a bug in the implementation of zlib. UBIFS's Zlib blocks do not have header but they were compressed using gunzip, a function used to deco

Re: [U-Boot] [PATCH 1/2] lib_generic: gunzip: New function zunzip

2009-04-27 Thread Wolfgang Denk
Dear Ricardo Ribalda Delgado, In message <1240823996-10418-1-git-send-email-ricardo.riba...@uam.es> you wrote: > Separate gunzip in > > gunzip: Find the end of the header and call zunzip. > zunzip: Inflate gunzip block without header. What is the needed for? Maybe you should provide a use case s

[U-Boot] [PATCH 1/2] lib_generic: gunzip: New function zunzip

2009-04-27 Thread Ricardo Ribalda Delgado
Separate gunzip in gunzip: Find the end of the header and call zunzip. zunzip: Inflate gunzip block without header. Signed-off-by: Ricardo Ribalda Delgado --- lib_generic/gunzip.c | 27 --- 1 files changed, 20 insertions(+), 7 deletions(-) diff --git a/lib_generic/gun