Re: [U-Boot] [PATCH 1/2] mpc85xx gpio related header files changes to compile common cmd_gpio.c

2015-03-27 Thread Oleksandr G Zhadan
Extra gpio bank argument at low level may be discussable, but IMPO we should not brake standard int gpio_set_value(unsigned gpio, int value) definition. And the reason of this patch is to fix: 1. Incompatibility in functions gpio_free() and gpio_set_value() definitions between asm/gpio.h and

Re: [U-Boot] [PATCH 1/2] mpc85xx gpio related header files changes to compile common cmd_gpio.c

2015-03-27 Thread Oleksandr G Zhadan
Yes, here locally we have some additional changes/fixes in some places as well. And if talk about mpc85xx gpio support it's better to have driver in drivers/gpio vs static definitions in header file and I have it. But currently I need this minimal patch to be accepted to send our board support

Re: [U-Boot] [PATCH 1/2] mpc85xx gpio related header files changes to compile common cmd_gpio.c

2015-03-27 Thread Joakim Tjernlund
On Fri, 2015-03-27 at 10:51 -0400, Oleksandr G Zhadan wrote: Extra gpio bank argument at low level may be discussable, but IMPO we should not brake standard int gpio_set_value(unsigned gpio, int value) definition. And the reason of this patch is to fix: 1. Incompatibility in functions

Re: [U-Boot] [PATCH 1/2] mpc85xx gpio related header files changes to compile common cmd_gpio.c

2015-03-27 Thread York Sun
On 03/27/2015 11:27 AM, Oleksandr G Zhadan wrote: Hi York, I add explanation and re-send the same patch. Whenever you make changes to the patch, please add a change log under the --- line. Please also see my comments on previous patch sent 5 minutes before this. York

Re: [U-Boot] [PATCH 1/2] mpc85xx gpio related header files changes to compile common cmd_gpio.c

2015-03-27 Thread Oleksandr G Zhadan
Hi York, I add explanation and re-send the same patch. On 03/26/2015 05:20 PM, York Sun wrote: On 03/26/2015 02:16 PM, Oleksandr G Zhadan wrote: From: Oleksandr Zhadan ol...@arcturusnetworks.com Please add commit message to explain why and what you are changing. Signed-off-by:

Re: [U-Boot] [PATCH 1/2] mpc85xx gpio related header files changes to compile common cmd_gpio.c

2015-03-26 Thread Joakim Tjernlund
On Thu, 2015-03-26 at 17:16 -0400, Oleksandr G Zhadan wrote: From: Oleksandr Zhadan ol...@arcturusnetworks.com Signed-off-by: Oleksandr Zhadan ol...@arcturusnetworks.com Signed-off-by: Michael Durrant mdurr...@arcturusnetworks.com --- arch/powerpc/include/asm/arch-mpc85xx/gpio.h |2

Re: [U-Boot] [PATCH 1/2] mpc85xx gpio related header files changes to compile common cmd_gpio.c

2015-03-26 Thread York Sun
On 03/26/2015 02:16 PM, Oleksandr G Zhadan wrote: From: Oleksandr Zhadan ol...@arcturusnetworks.com Please add commit message to explain why and what you are changing. Signed-off-by: Oleksandr Zhadan ol...@arcturusnetworks.com Signed-off-by: Michael Durrant mdurr...@arcturusnetworks.com

[U-Boot] [PATCH 1/2] mpc85xx gpio related header files changes to compile common cmd_gpio.c

2015-03-26 Thread Oleksandr G Zhadan
From: Oleksandr Zhadan ol...@arcturusnetworks.com Signed-off-by: Oleksandr Zhadan ol...@arcturusnetworks.com Signed-off-by: Michael Durrant mdurr...@arcturusnetworks.com --- arch/powerpc/include/asm/arch-mpc85xx/gpio.h |2 ++ arch/powerpc/include/asm/mpc85xx_gpio.h |6 -- 2