Re: [U-Boot] [PATCH 1/2] net: mvpp2: fix polarity of PHY reset signal

2018-10-22 Thread Stefan Roese
On 15.10.18 12:16, Baruch Siach wrote: The dm_gpio_set_value() call sets the logical level of the GPIO signal. That is, it takes the GPIO_ACTIVE_{LOW,HIGH} property into account. The driver needs to assert the reset, and then deassert it. Not the other way around. Cc: Stefan Chulski Signed-off-

Re: [U-Boot] [PATCH 1/2] net: mvpp2: fix polarity of PHY reset signal

2018-10-15 Thread Joe Hershberger
On Mon, Oct 15, 2018 at 5:18 AM Baruch Siach wrote: > > The dm_gpio_set_value() call sets the logical level of the GPIO signal. > That is, it takes the GPIO_ACTIVE_{LOW,HIGH} property into account. The > driver needs to assert the reset, and then deassert it. Not the other > way around. > > Cc: St

[U-Boot] [PATCH 1/2] net: mvpp2: fix polarity of PHY reset signal

2018-10-15 Thread Baruch Siach
The dm_gpio_set_value() call sets the logical level of the GPIO signal. That is, it takes the GPIO_ACTIVE_{LOW,HIGH} property into account. The driver needs to assert the reset, and then deassert it. Not the other way around. Cc: Stefan Chulski Signed-off-by: Baruch Siach --- drivers/net/mvpp2.