Re: [U-Boot] [PATCH 1/2 v4] ARM : Add GPIO Driver and IOMUX definition for S3C2440

2012-05-02 Thread Minkyu Kang
Dear Marek, On 2 May 2012 11:44, Marek Vasut ma...@denx.de wrote: +int gpio_set_value(unsigned gpio, int value) +{ +       unsigned l = readl(GPIO_FULLPORT(gpio)); +       unsigned port = GPIO_FULLPORT(gpio); + +       /* +        * All GPIO Port have a configuration on +        *

Re: [U-Boot] [PATCH 1/2 v4] ARM : Add GPIO Driver and IOMUX definition for S3C2440

2012-05-02 Thread Scott Wood
On 05/02/2012 01:16 AM, Minkyu Kang wrote: Dear Marek, On 2 May 2012 11:44, Marek Vasut ma...@denx.de wrote: +int gpio_set_value(unsigned gpio, int value) +{ + unsigned l = readl(GPIO_FULLPORT(gpio)); + unsigned port = GPIO_FULLPORT(gpio); + + /* +* All GPIO

Re: [U-Boot] [PATCH 1/2 v4] ARM : Add GPIO Driver and IOMUX definition for S3C2440

2012-05-02 Thread Gabriel Huau
On Wed, May 02, 2012 at 01:40:35PM -0500, Scott Wood wrote: On 05/02/2012 01:16 AM, Minkyu Kang wrote: Dear Marek, On 2 May 2012 11:44, Marek Vasut ma...@denx.de wrote: +int gpio_set_value(unsigned gpio, int value) +{ + unsigned l = readl(GPIO_FULLPORT(gpio)); +

Re: [U-Boot] [PATCH 1/2 v4] ARM : Add GPIO Driver and IOMUX definition for S3C2440

2012-05-02 Thread Scott Wood
On 05/02/2012 03:16 PM, Gabriel Huau wrote: On Wed, May 02, 2012 at 01:40:35PM -0500, Scott Wood wrote: On 05/02/2012 01:16 AM, Minkyu Kang wrote: Dear Marek, On 2 May 2012 11:44, Marek Vasut ma...@denx.de wrote: +int gpio_set_value(unsigned gpio, int value) +{ + unsigned l =

Re: [U-Boot] [PATCH 1/2 v4] ARM : Add GPIO Driver and IOMUX definition for S3C2440

2012-05-01 Thread Minkyu Kang
Dear Gabriel Huau, On 30 April 2012 23:11, Gabriel Huau cont...@huau-gabriel.fr wrote: It's now possible to use the gpio driver interface for s3c2440. This patch add iomux definitions too. Signed-off-by: Gabriel Huau cont...@huau-gabriel.fr --- Changes for v2:        - Modification of the

Re: [U-Boot] [PATCH 1/2 v4] ARM : Add GPIO Driver and IOMUX definition for S3C2440

2012-05-01 Thread Marek Vasut
Dear Minkyu Kang, Dear Gabriel Huau, On 30 April 2012 23:11, Gabriel Huau cont...@huau-gabriel.fr wrote: It's now possible to use the gpio driver interface for s3c2440. This patch add iomux definitions too. Signed-off-by: Gabriel Huau cont...@huau-gabriel.fr --- Changes for v2:

[U-Boot] [PATCH 1/2 v4] ARM : Add GPIO Driver and IOMUX definition for S3C2440

2012-04-30 Thread Gabriel Huau
It's now possible to use the gpio driver interface for s3c2440. This patch add iomux definitions too. Signed-off-by: Gabriel Huau cont...@huau-gabriel.fr --- Changes for v2: - Modification of the coding style - Add my email address to copyright - Remove a typedef -

Re: [U-Boot] [PATCH 1/2 v4] ARM : Add GPIO Driver and IOMUX definition for S3C2440

2012-04-30 Thread Marek Vasut
Dear Gabriel Huau, It's now possible to use the gpio driver interface for s3c2440. This patch add iomux definitions too. All right, I guess I can't rub my sadistic reviewing pleasures on you anymore ;-) Acked-by: Marek Vasut ma...@denx.de Signed-off-by: Gabriel Huau