Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-07-21 Thread Stephen Warren
On 07/02/2014 10:34 PM, Heiko Schocher wrote: Hello Stephen, Am 02.07.2014 20:37, schrieb Stephen Warren: On 06/25/2014 10:57 AM, Stephen Warren wrote: From: Stephen Warrenswar...@nvidia.com I2C read transactions are typically implemented as follows: START(write) address

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-07-02 Thread Stephen Warren
On 06/25/2014 10:57 AM, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com I2C read transactions are typically implemented as follows: START(write) address REPEATED_START(read) data... STOP However, Tegra's I2C driver currently implements reads as follows: START(write)

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-07-02 Thread Heiko Schocher
Hello Stephen, Am 02.07.2014 20:37, schrieb Stephen Warren: On 06/25/2014 10:57 AM, Stephen Warren wrote: From: Stephen Warrenswar...@nvidia.com I2C read transactions are typically implemented as follows: START(write) address REPEATED_START(read) data... STOP However, Tegra's I2C driver

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-26 Thread Joakim Tjernlund
From: Stephen Warren swar...@wwwdotorg.org To: u-boot@lists.denx.de, Heiko Schocher h...@denx.de, Cc: Stephen Warren swar...@nvidia.com, Tom Warren twar...@nvidia.com Date: 2014/06/25 19:05 Subject: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads Sent by: u-boot-boun

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-26 Thread Stephen Warren
On 06/26/2014 02:11 AM, Joakim Tjernlund wrote: From: Stephen Warren swar...@wwwdotorg.org To: u-boot@lists.denx.de, Heiko Schocher h...@denx.de, Cc: Stephen Warren swar...@nvidia.com, Tom Warren twar...@nvidia.com Date: 2014/06/25 19:05 Subject: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-26 Thread Joakim Tjernlund
Date: 2014/06/25 19:05 Subject: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads Sent by: u-boot-boun...@lists.denx.de From: Stephen Warren swar...@nvidia.com I2C read transactions are typically implemented as follows: START(write) address REPEATED_START(read) data... STOP

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-26 Thread Stephen Warren
...@nvidia.com, Tom Warren twar...@nvidia.com Date: 2014/06/25 19:05 Subject: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads Sent by: u-boot-boun...@lists.denx.de From: Stephen Warren swar...@nvidia.com I2C read transactions are typically implemented as follows: START(write

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-26 Thread Stephen Warren
h...@denx.de, Cc: Stephen Warren swar...@nvidia.com, Tom Warren twar...@nvidia.com Date: 2014/06/25 19:05 Subject: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads Sent by: u-boot-boun...@lists.denx.de From: Stephen Warren swar...@nvidia.com I2C read transactions

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-26 Thread Joakim Tjernlund
@lists.denx.de, Heiko Schocher h...@denx.de, Cc: Stephen Warren swar...@nvidia.com, Tom Warren twar...@nvidia.com Date: 2014/06/25 19:05 Subject: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads Sent by: u-boot-boun...@lists.denx.de From: Stephen Warren swar

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-26 Thread Joakim Tjernlund
: Stephen Warren swar...@wwwdotorg.org To: u-boot@lists.denx.de, Heiko Schocher h...@denx.de, Cc: Stephen Warren swar...@nvidia.com, Tom Warren twar...@nvidia.com Date: 2014/06/25 19:05 Subject: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads Sent by: u-boot-boun

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-26 Thread Stephen Warren
On 06/26/2014 02:01 PM, Joakim Tjernlund wrote: ... Strange, I had a look at the driver and I have a hard time figuring out how/when START/STOP is generated. However I don't think the current driver's wait_for_transfer_complete() waits for the START/STOP. I guess it waits until all data

[U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-25 Thread Stephen Warren
From: Stephen Warren swar...@nvidia.com I2C read transactions are typically implemented as follows: START(write) address REPEATED_START(read) data... STOP However, Tegra's I2C driver currently implements reads as follows: START(write) address STOP START(read) data... STOP This sequence

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-25 Thread Yen Lin
Hi Stephen, Subject: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads From: Stephen Warren swar...@nvidia.com I2C read transactions are typically implemented as follows: START(write) address REPEATED_START(read) data... STOP However, Tegra's I2C driver currently

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-25 Thread Simon Glass
Hi Stephen, On 25 June 2014 10:57, Stephen Warren swar...@wwwdotorg.org wrote: From: Stephen Warren swar...@nvidia.com I2C read transactions are typically implemented as follows: START(write) address REPEATED_START(read) data... STOP However, Tegra's I2C driver currently implements reads

Re: [U-Boot] [PATCH 1/3] i2c: tegra: use repeated start for reads

2014-06-25 Thread Stephen Warren
On 06/25/2014 08:12 PM, Simon Glass wrote: Hi Stephen, On 25 June 2014 10:57, Stephen Warren swar...@wwwdotorg.org wrote: From: Stephen Warren swar...@nvidia.com I2C read transactions are typically implemented as follows: START(write) address REPEATED_START(read) data... STOP However,