Re: [U-Boot] [PATCH 1/3] mtd: onenand: Fix unaligned access

2014-01-01 Thread Marek Vasut
On Tuesday, December 31, 2013 at 11:43:48 AM, Lukasz Majewski wrote: > Hi Marek, > > > On Saturday, December 28, 2013 at 05:06:28 PM, Lukasz Majewski wrote: > > > Hi Marek, > > > > > > > On Thursday, December 26, 2013 at 01:01:24 AM, Marek Vasut wrote: > > > > > Fix unaligned access in OneNAND co

Re: [U-Boot] [PATCH 1/3] mtd: onenand: Fix unaligned access

2013-12-31 Thread Lukasz Majewski
Hi Marek, > On Saturday, December 28, 2013 at 05:06:28 PM, Lukasz Majewski wrote: > > Hi Marek, > > > > > On Thursday, December 26, 2013 at 01:01:24 AM, Marek Vasut wrote: > > > > Fix unaligned access in OneNAND core. The problem is that the > > > > ffchars[] array is an array of "unsigned char",

Re: [U-Boot] [PATCH 1/3] mtd: onenand: Fix unaligned access

2013-12-29 Thread Marek Vasut
On Saturday, December 28, 2013 at 05:06:28 PM, Lukasz Majewski wrote: > Hi Marek, > > > On Thursday, December 26, 2013 at 01:01:24 AM, Marek Vasut wrote: > > > Fix unaligned access in OneNAND core. The problem is that the > > > ffchars[] array is an array of "unsigned char", but in > > > onenand_w

Re: [U-Boot] [PATCH 1/3] mtd: onenand: Fix unaligned access

2013-12-28 Thread Lukasz Majewski
Hi Marek, > On Thursday, December 26, 2013 at 01:01:24 AM, Marek Vasut wrote: > > Fix unaligned access in OneNAND core. The problem is that the > > ffchars[] array is an array of "unsigned char", but in > > onenand_write_ops_nolock() can be passed to the memcpy_16() > > function. The memcpy_16() f

Re: [U-Boot] [PATCH 1/3] mtd: onenand: Fix unaligned access

2013-12-27 Thread Marek Vasut
On Thursday, December 26, 2013 at 01:01:24 AM, Marek Vasut wrote: > Fix unaligned access in OneNAND core. The problem is that the ffchars[] > array is an array of "unsigned char", but in onenand_write_ops_nolock() > can be passed to the memcpy_16() function. The memcpy_16() function will > treat th

Re: [U-Boot] [PATCH 1/3] mtd: onenand: Fix unaligned access

2013-12-27 Thread Scott Wood
On Thu, 2013-12-26 at 01:01 +0100, Marek Vasut wrote: > Fix unaligned access in OneNAND core. The problem is that the ffchars[] array > is an array of "unsigned char", but in onenand_write_ops_nolock() can be > passed > to the memcpy_16() function. The memcpy_16() function will treat the buffer as

Re: [U-Boot] [PATCH 1/3] mtd: onenand: Fix unaligned access

2013-12-26 Thread Rommel G Custodio
Dear Marek Vasut, Marek Vasut denx.de> writes: > +/* > + * Warning! This array is used with the memcpy_16() function, thus > + * it must be aligned to 2 bytes. GCC can make this array unaligned > + * as the array is made of unsigned char, which memcpy16() doesn't > + * like and will cause unalig

[U-Boot] [PATCH 1/3] mtd: onenand: Fix unaligned access

2013-12-25 Thread Marek Vasut
Fix unaligned access in OneNAND core. The problem is that the ffchars[] array is an array of "unsigned char", but in onenand_write_ops_nolock() can be passed to the memcpy_16() function. The memcpy_16() function will treat the buffer as an array of "unsigned short", thus triggering unaligned access