[U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-21 Thread Ajay Bhargav
This patch adds support for Fast Ethernet Controller driver for Armada100 series. Signed-off-by: Ajay Bhargav --- arch/arm/include/asm/arch-armada100/armada100.h |1 + drivers/net/Makefile|1 + drivers/net/armada100_fec.c | 802 +++

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-22 Thread Marek Vasut
On Monday, August 22, 2011 07:11:57 AM Ajay Bhargav wrote: > This patch adds support for Fast Ethernet Controller driver for > Armada100 series. > > Signed-off-by: Ajay Bhargav > --- > arch/arm/include/asm/arch-armada100/armada100.h |1 + > drivers/net/Makefile|

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-22 Thread Mike Frysinger
On Monday, August 22, 2011 01:11:57 Ajay Bhargav wrote: > + writel((u32) darmdfec->htpr, ®s->htpr); do you really need to cast it yourself ? seems to show up a lot in this file. > +#ifdef ETH_DUMP_REGS > + eth_dump_regs(dev); > +#endif use #ifdef DEBUG > + while (cmd_sts & BUF_OWNE

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-22 Thread Marek Vasut
On Monday, August 22, 2011 06:02:26 PM Mike Frysinger wrote: > On Monday, August 22, 2011 01:11:57 Ajay Bhargav wrote: > > + writel((u32) darmdfec->htpr, ®s->htpr); > > do you really need to cast it yourself ? seems to show up a lot in this > file. > [...] > make the reg base a parameter to

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-22 Thread Mike Frysinger
On Monday, August 22, 2011 12:07:26 Marek Vasut wrote: > On Monday, August 22, 2011 06:02:26 PM Mike Frysinger wrote: > > On Monday, August 22, 2011 01:11:57 Ajay Bhargav wrote: > > > + darmdfec = malloc(sizeof(struct armdfec_device)); > > > > sizeof(*darmdfec) > > Why are you against sizeof(stru

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-22 Thread Marek Vasut
On Monday, August 22, 2011 06:42:33 PM Mike Frysinger wrote: > On Monday, August 22, 2011 12:07:26 Marek Vasut wrote: > > On Monday, August 22, 2011 06:02:26 PM Mike Frysinger wrote: > > > On Monday, August 22, 2011 01:11:57 Ajay Bhargav wrote: > > > > + darmdfec = malloc(sizeof(struct armdfe

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-22 Thread Mike Frysinger
On Monday, August 22, 2011 12:45:06 Marek Vasut wrote: > On Monday, August 22, 2011 06:42:33 PM Mike Frysinger wrote: > > On Monday, August 22, 2011 12:07:26 Marek Vasut wrote: > > > On Monday, August 22, 2011 06:02:26 PM Mike Frysinger wrote: > > > > On Monday, August 22, 2011 01:11:57 Ajay Bharga

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-22 Thread jason . hobbs
On Monday, August 22, 2011 12:11pm, "Mike Frysinger" said: > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > On Monday, August 22, 2011 12:45:06 Marek Vasut wrote: >> On Monday, August 22, 2011 06:42:33

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-22 Thread Ajay Bhargav
- "Marek Vasut" wrote: > On Monday, August 22, 2011 07:11:57 AM Ajay Bhargav wrote: > > This patch adds support for Fast Ethernet Controller driver for > > Armada100 series. > > > > Signed-off-by: Ajay Bhargav > > --- > > arch/arm/include/asm/arch-armada100/armada100.h |1 + > > drive

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-22 Thread Ajay Bhargav
- "Mike Frysinger" wrote: > On Monday, August 22, 2011 01:11:57 Ajay Bhargav wrote: > > + writel((u32) darmdfec->htpr, ®s->htpr); > > do you really need to cast it yourself ? seems to show up a lot in > this file. > > > +#ifdef ETH_DUMP_REGS > > + eth_dump_regs(dev); > > +#endif > >

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-22 Thread Ajay Bhargav
- "Marek Vasut" wrote: > On Monday, August 22, 2011 07:11:57 AM Ajay Bhargav wrote: > > This patch adds support for Fast Ethernet Controller driver for > > Armada100 series. > > > > Signed-off-by: Ajay Bhargav > > --- > > arch/arm/include/asm/arch-armada100/armada100.h |1 + > > drive

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Marek Vasut
On Tuesday, August 23, 2011 08:11:57 AM Ajay Bhargav wrote: > - "Marek Vasut" wrote: > > On Monday, August 22, 2011 07:11:57 AM Ajay Bhargav wrote: > > > This patch adds support for Fast Ethernet Controller driver for > > > Armada100 series. > > > > > > Signed-off-by: Ajay Bhargav > > > ---

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Ajay Bhargav
- "Marek Vasut" wrote: > On Tuesday, August 23, 2011 08:11:57 AM Ajay Bhargav wrote: > > - "Marek Vasut" wrote: > > > On Monday, August 22, 2011 07:11:57 AM Ajay Bhargav wrote: > > > > This patch adds support for Fast Ethernet Controller driver for > > > > Armada100 series. > > > > > >

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Wolfgang Denk
Dear Ajay Bhargav, In message <1058764603.122757.1314095393033.javamail.r...@ahm.einfochips.com> you wrote: > > > I think someone NAKed this whole part with MAC randomisation and he was > > right > > about it ... you're supposed to configure the MAC properly yourself. ... > MAC randomization i

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Ajay Bhargav
- "Wolfgang Denk" wrote: > Dear Ajay Bhargav, > > In message > <1058764603.122757.1314095393033.javamail.r...@ahm.einfochips.com> you > wrote: > > > > > I think someone NAKed this whole part with MAC randomisation and > he was right > > > about it ... you're supposed to configure the MAC

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Ajay Bhargav
- "Wolfgang Denk" wrote: > Dear Ajay Bhargav, > > In message > <1058764603.122757.1314095393033.javamail.r...@ahm.einfochips.com> you > wrote: > > > > > I think someone NAKed this whole part with MAC randomisation and > he was right > > > about it ... you're supposed to configure the MAC

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Wolfgang Denk
Dear Ajay Bhargav, In message <1570238601.123783.1314104389736.javamail.r...@ahm.einfochips.com> you wrote: > > ok I just wanted to clear myself.. I do not have a dedicated hardware > storage in my ethernet controller so I will just look into environment > variable ethaddr, if its set I will jus

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Ralph Metzler
Wolfgang Denk writes: > > ok I just wanted to clear myself.. I do not have a dedicated hardware > > storage in my ethernet controller so I will just look into environment > > variable ethaddr, if its set I will just copy it to driver layer and > > if it is not set, I let the user set it. He/She

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Mike Frysinger
On Tuesday, August 23, 2011 11:30:38 Ralph Metzler wrote: > Wolfgang Denk writes: > > > ok I just wanted to clear myself.. I do not have a dedicated hardware > > > storage in my ethernet controller so I will just look into environment > > > variable ethaddr, if its set I will just copy it to dri

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Wolfgang Denk
Dear Ralph Metzler, In message <20051.51102.404246.81248@morden.metzler> you wrote: > > So, I introduced "pxa168_mac" as Linux command line argument to pass > ethaddr to pxa168_eth. Or does anybody have a better solution? Add device tree support for your board, and pass the MAC address in the dev

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-23 Thread Ajay Bhargav
- "Wolfgang Denk" wrote: > Dear Ajay Bhargav, > > In message > <1570238601.123783.1314104389736.javamail.r...@ahm.einfochips.com> you > wrote: > > > > ok I just wanted to clear myself.. I do not have a dedicated > hardware > > storage in my ethernet controller so I will just look into > en