Hi Prafulla,
Thank you so much for comments. I am already working on it.
Regards,
Ajay Bhargav
- Original Message -
From: "Prafulla Wadaskar"
To: "Ajay Bhargav"
Cc: u-boot@lists.denx.de, "Ashish Karkare" , "Prabhanjan
Sarnaik"
Sent: Friday, July 8, 2011 8:49:00 PM
Subject: RE: [PATCH
> -Original Message-
> From: Ajay Bhargav [mailto:ajay.bhar...@einfochips.com]
> Sent: Friday, July 08, 2011 11:53 AM
> To: Prafulla Wadaskar
> Cc: u-boot@lists.denx.de; Ajay Bhargav
> Subject: [PATCH 1/4] Armada100: Ethernet support for Marvell gplugD
>
> This patch adds ethernet suppor
> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Friday, July 08, 2011 3:48 PM
> To: Ajay Bhargav
> Cc: Prafulla Wadaskar; u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH 1/4] Armada100: Ethernet support for
> Marvell gplugD
>
>
> -Original Message-
> From: Ajay Bhargav [mailto:ajay.bhar...@einfochips.com]
> Sent: Friday, July 08, 2011 6:19 PM
> To: Wolfgang Denk
> Cc: Prafulla Wadaskar; u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH 1/4] Armada100: Ethernet support for
> Marvell gplu
Dear Wolfgang,
> Bad examples are no excuse for adding more bad code.
got it :)
> Some things only get noticed when they already exist. But once
> noticed, we should not repeat the same mistakes.
I wouldn't have tried making that mistake if it was mentioned that
earlier implementations are wron
Dear Ajay Bhargav,
In message <107544326.47582.1310126592414.javamail.r...@ahm.einfochips.com> you
wrote:
>
> I did get your point sir, but...
...
> asm/arch-kirkwood/gpio.h)>
Bad examples are no excuse for adding more bad code.
Some things only get noticed when they already exist. But once
n
Dear Wolfdang,
I did get your point sir, but...
> To me this looks different.
> - Do not use a "base address + offset" notation (with a declartion of
> register offsets in your header files), but use C structs instead to
> describe the regioster layout, and then use proper I/O accessor
> func
Dear Ajay Bhargav,
In message <867041231.46865.1310120597114.javamail.r...@ahm.einfochips.com> you
wrote:
>
> Thanks for info, I have seen that. But i am not adding support for GPIO
> commands.
Like the gpio command, your code should use the same generic gpio API.
> In reference to
>
> >> +
Dear Wolfgang,
Thanks for info, I have seen that. But i am not adding support for GPIO
commands.
In reference to
>> +#define GPLR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x00)
>> +#define GPDR(x) GPIO_REG(BANK_OFF((x) >> 5) + 0x0c)
>> +#define GPSR(x) GPIO_REG(BANK_OFF((x) >>
ot@lists.denx.de
> Sent: Friday, July 8, 2011 1:17:50 PM
> Subject: Re: [U-Boot] [PATCH 1/4] Armada100: Ethernet support for Marvell
> gplugD
...
And *please* STOP top posting / full quoting!!!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk &
easy to make out that they are
actually GPIO registers.
Regards,
Ajay Bhargav
- Original Message -
From: "Wolfgang Denk"
To: "Ajay Bhargav"
Cc: prafu...@marvell.com, u-boot@lists.denx.de
Sent: Friday, July 8, 2011 1:17:50 PM
Subject: Re: [U-Boot] [PATCH 1/4] Armada1
17:50 PM
Subject: Re: [U-Boot] [PATCH 1/4] Armada100: Ethernet support for Marvell gplugD
Dear Ajay Bhargav,
In message <1310106168-17166-1-git-send-email-ajay.bhar...@einfochips.com> you
wrote:
> This patch adds ethernet support for GuruPlug-Display. tftpboot and
> and othe
Dear Ajay Bhargav,
In message <1310106168-17166-1-git-send-email-ajay.bhar...@einfochips.com> you
wrote:
> This patch adds ethernet support for GuruPlug-Display. tftpboot and
> and other network related commands now works.
>
> Signed-off-by: Ajay Bhargav
> ---
> .gitignore
This patch adds ethernet support for GuruPlug-Display. tftpboot and
and other network related commands now works.
Signed-off-by: Ajay Bhargav
---
.gitignore |1 +
arch/arm/include/asm/arch-armada100/armada100.h | 39 ++
arch/arm/include/asm/arch-armada1
14 matches
Mail list logo
