Hi Marek,
2017-08-17 20:56 GMT+09:00 Marek Vasut :
> On 08/17/2017 09:01 AM, Masahiro Yamada wrote:
>> 2017-08-17 15:39 GMT+09:00 Jaehoon Chung :
>>> On 08/13/2017 01:55 AM, Marek Vasut wrote:
On 08/10/2017 09:49 AM, Masahiro Yamada wrote:
On 08/17/2017 09:01 AM, Masahiro Yamada wrote:
> 2017-08-17 15:39 GMT+09:00 Jaehoon Chung :
>> On 08/13/2017 01:55 AM, Marek Vasut wrote:
>>> On 08/10/2017 09:49 AM, Masahiro Yamada wrote:
Hi.
2017-08-07 17:30 GMT+09:00 Marek Vasut
2017-08-17 15:39 GMT+09:00 Jaehoon Chung :
> On 08/13/2017 01:55 AM, Marek Vasut wrote:
>> On 08/10/2017 09:49 AM, Masahiro Yamada wrote:
>>> Hi.
>>>
>>>
>>> 2017-08-07 17:30 GMT+09:00 Marek Vasut :
On 08/07/2017 04:30 AM, Masahiro Yamada wrote:
2017-08-13 1:55 GMT+09:00 Marek Vasut :
> On 08/10/2017 09:49 AM, Masahiro Yamada wrote:
>> Hi.
>>
>>
>> 2017-08-07 17:30 GMT+09:00 Marek Vasut :
>>> On 08/07/2017 04:30 AM, Masahiro Yamada wrote:
Hi Marek,
>>>
>>> Hi Masahiro,
>>>
>>> This is
Hi,
On 07/22/2017 06:24 AM, Marek Vasut wrote:
> This patch prepares the driver to support controller(s) with registers
> at locations shifted by constant. Pull out the readl()/writel() from
> the driver into separate functions, where the adjustment of the register
> offset can be easily
On 08/13/2017 01:55 AM, Marek Vasut wrote:
> On 08/10/2017 09:49 AM, Masahiro Yamada wrote:
>> Hi.
>>
>>
>> 2017-08-07 17:30 GMT+09:00 Marek Vasut :
>>> On 08/07/2017 04:30 AM, Masahiro Yamada wrote:
Hi Marek,
>>>
>>> Hi Masahiro,
>>>
>>> This is gonna be a great
On 08/10/2017 09:49 AM, Masahiro Yamada wrote:
> Hi.
>
>
> 2017-08-07 17:30 GMT+09:00 Marek Vasut :
>> On 08/07/2017 04:30 AM, Masahiro Yamada wrote:
>>> Hi Marek,
>>
>> Hi Masahiro,
>>
>> This is gonna be a great discussion, let's wrestle about consts and ints :-)
>>
>>>
Hi.
2017-08-07 17:30 GMT+09:00 Marek Vasut :
> On 08/07/2017 04:30 AM, Masahiro Yamada wrote:
>> Hi Marek,
>
> Hi Masahiro,
>
> This is gonna be a great discussion, let's wrestle about consts and ints :-)
>
>> 2017-08-06 4:23 GMT+09:00 Marek Vasut :
On 08/07/2017 04:30 AM, Masahiro Yamada wrote:
> Hi Marek,
Hi Masahiro,
This is gonna be a great discussion, let's wrestle about consts and ints :-)
> 2017-08-06 4:23 GMT+09:00 Marek Vasut :
>> On 08/03/2017 02:36 PM, Masahiro Yamada wrote:
>>> Hi Marek,
>>
>> Hi,
>>
>>
Hi Marek,
2017-08-06 4:23 GMT+09:00 Marek Vasut :
> On 08/03/2017 02:36 PM, Masahiro Yamada wrote:
>> Hi Marek,
>
> Hi,
>
> [...]
>
>>> +static u32 uniphier_sd_readl(struct uniphier_sd_priv *priv, const u32 reg)
>>
>> "const" is unneeded here.
>
> Why? The function should
On 08/03/2017 02:36 PM, Masahiro Yamada wrote:
> Hi Marek,
Hi,
[...]
>> +static u32 uniphier_sd_readl(struct uniphier_sd_priv *priv, const u32 reg)
>
> "const" is unneeded here.
Why? The function should not modify reg , so it is const.
> Also, could you use "unsigned int" or "int" for reg?
Hi Marek,
Very sorry for my late reply.
I agree we should share the driver
to avoid code duplication.
I tested the series on my board and working.
Basically, I'd say "go for it".
A little minor comments below.
2017-07-22 6:24 GMT+09:00 Marek Vasut :
> This patch
This patch prepares the driver to support controller(s) with registers
at locations shifted by constant. Pull out the readl()/writel() from
the driver into separate functions, where the adjustment of the register
offset can be easily contained.
Signed-off-by: Marek Vasut
13 matches
Mail list logo