Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-06-01 Thread Albert ARIBAUD
Hi Christoffer, On Fri, 31 May 2013 16:50:09 -0700, Christoffer Dall cd...@cs.columbia.edu wrote: On Fri, May 31, 2013 at 11:23:16AM +0200, Andre Przywara wrote: On 05/31/2013 03:02 AM, Christoffer Dall wrote: This is added later in 5/6. For reviewing purposes I split the patches up to

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-06-01 Thread Albert ARIBAUD
On Sat, 1 Jun 2013 12:06:24 +0200, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Hi Christoffer, On Fri, 31 May 2013 16:50:09 -0700, Christoffer Dall cd...@cs.columbia.edu wrote: On Fri, May 31, 2013 at 11:23:16AM +0200, Andre Przywara wrote: On 05/31/2013 03:02 AM, Christoffer Dall

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-31 Thread Andre Przywara
On 05/31/2013 03:02 AM, Christoffer Dall wrote: Christoffer, thanks a lot for the thorough review. Comments inline. On Mon, May 06, 2013 at 03:17:45PM +0200, Andre Przywara wrote: A prerequisite for using virtualization is to be in HYP mode, which requires the CPU to be in non-secure state.

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-31 Thread Albert ARIBAUD
Hi Andre, On Fri, 31 May 2013 11:23:16 +0200, Andre Przywara andre.przyw...@linaro.org wrote: software_interrupt is currently a panic routine. So it is not actually used by u-boot, it's just there to dump some state and eventually call reset_cpu(). So I feel that since I am now the only

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-31 Thread Christoffer Dall
On Fri, May 31, 2013 at 11:23:16AM +0200, Andre Przywara wrote: On 05/31/2013 03:02 AM, Christoffer Dall wrote: Christoffer, thanks a lot for the thorough review. Comments inline. On Mon, May 06, 2013 at 03:17:45PM +0200, Andre Przywara wrote: A prerequisite for using virtualization is

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-30 Thread Christoffer Dall
On Mon, May 06, 2013 at 03:17:45PM +0200, Andre Przywara wrote: A prerequisite for using virtualization is to be in HYP mode, which requires the CPU to be in non-secure state. Introduce a monitor handler routine which switches the CPU to non-secure state by setting the NS and associated bits.

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-26 Thread Andre Przywara
On 05/23/2013 12:52 PM, Albert ARIBAUD wrote: Hi Andre, On Mon, 6 May 2013 15:17:45 +0200, Andre Przywara andre.przyw...@linaro.org wrote: A prerequisite for using virtualization is to be in HYP mode, which requires the CPU to be in non-secure state. Introduce a monitor handler routine which

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-23 Thread Albert ARIBAUD
Hi Andre, On Mon, 6 May 2013 15:17:45 +0200, Andre Przywara andre.przyw...@linaro.org wrote: A prerequisite for using virtualization is to be in HYP mode, which requires the CPU to be in non-secure state. Introduce a monitor handler routine which switches the CPU to non-secure state by

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-23 Thread Albert ARIBAUD
Hi Marc, On Thu, 23 May 2013 13:14:01 +0100, Marc Zyngier marc.zyng...@arm.com wrote: On 23/05/13 11:52, Albert ARIBAUD wrote: Hi Andre, On Mon, 6 May 2013 15:17:45 +0200, Andre Przywara andre.przyw...@linaro.org wrote: A prerequisite for using virtualization is to be in HYP

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-23 Thread Albert ARIBAUD
On Thu, 23 May 2013 14:34:38 +0200, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Hi Marc, So if you don't want to use 'TRM' (which I can understand), then at least please replace 'ARM ARM' with 'ARMv7-AR Reference Manual'. Stating the DDI* reference is not a must, unless you want to

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-23 Thread Albert ARIBAUD
On Thu, 23 May 2013 14:40:09 +0200, Albert ARIBAUD albert.u.b...@aribaud.net wrote: My bad: this last paragraph was actually directed at Andrew Make that Andre. Apologies, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-23 Thread Peter Maydell
On 23 May 2013 13:34, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Well -- if you form the acronym, you do end with 'A R M' indeed, but this is quite unfortunate, as 'ARM ARM' is redundant (as the acronym's A already has ARM in it), confusion (as 'ARM' already bears a quite established

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-23 Thread Albert ARIBAUD
Hi Peter, (sorry for the duplicate; first reply sent was missing recipients, and I had a fix to do anyway) On Thu, 23 May 2013 14:00:17 +0100, Peter Maydell peter.mayd...@linaro.org wrote: On 23 May 2013 13:34, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Well -- if you form the acronym,

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-23 Thread Albert ARIBAUD
On Thu, 23 May 2013 16:08:35 +0200, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Since a git comment is there for a reason, which includes helping its readers understand the commit, I consider ARMv7-AR Reference Manual to help them much more than 'ARM ARM', as it points them unambiguously

Re: [U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-23 Thread Marc Zyngier
On 23/05/13 11:52, Albert ARIBAUD wrote: Hi Andre, On Mon, 6 May 2013 15:17:45 +0200, Andre Przywara andre.przyw...@linaro.org wrote: A prerequisite for using virtualization is to be in HYP mode, which requires the CPU to be in non-secure state. Introduce a monitor handler routine which

[U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

2013-05-06 Thread Andre Przywara
A prerequisite for using virtualization is to be in HYP mode, which requires the CPU to be in non-secure state. Introduce a monitor handler routine which switches the CPU to non-secure state by setting the NS and associated bits. According to the ARM ARM this should not be done in SVC mode, so we