Re: [U-Boot] [PATCH 1/6] ARM: tegra: deduplicate MASK_BITS_xxx clock mux enum

2014-01-24 Thread Stephen Warren
On 01/24/2014 06:54 AM, Thierry Reding wrote: > On Wed, Jan 22, 2014 at 01:20:31PM -0700, Stephen Warren wrote: ... > With the few small comments addressed, the series: > > Reviewed-by: Thierry Reding > > I've also given these a spin together with your reworked Tegra124 > patches and it al

Re: [U-Boot] [PATCH 1/6] ARM: tegra: deduplicate MASK_BITS_xxx clock mux enum

2014-01-24 Thread Thierry Reding
On Wed, Jan 22, 2014 at 01:20:31PM -0700, Stephen Warren wrote: > From: Tom Warren > > The enum used to define the set of register bits used to represent a > clock's input mux, MUX_BITS_*, is defined separately for each SoC at > present. Move this definition to a common location to ease fixing up

Re: [U-Boot] [PATCH 1/6] ARM: tegra: deduplicate MASK_BITS_xxx clock mux enum

2014-01-22 Thread Tom Warren
On Wed, Jan 22, 2014 at 2:54 PM, Stephen Warren wrote: > On 01/22/2014 02:35 PM, Tom Warren wrote: > ... > > Thanks for doing these patches - nice job. LGTM. > > > > Applies cleanly to u-boot-tegra/next after applying Alban's 2 patches, > > your other 3 patches, and then this series of 6. Building

Re: [U-Boot] [PATCH 1/6] ARM: tegra: deduplicate MASK_BITS_xxx clock mux enum

2014-01-22 Thread Stephen Warren
On 01/22/2014 02:35 PM, Tom Warren wrote: ... > Thanks for doing these patches - nice job. LGTM. > > Applies cleanly to u-boot-tegra/next after applying Alban's 2 patches, > your other 3 patches, and then this series of 6. Building all now, I'll > test later. Great! Just FYI, I tested MMC and DHC

Re: [U-Boot] [PATCH 1/6] ARM: tegra: deduplicate MASK_BITS_xxx clock mux enum

2014-01-22 Thread Tom Warren
Stephen, On Wed, Jan 22, 2014 at 1:20 PM, Stephen Warren wrote: > From: Tom Warren > > The enum used to define the set of register bits used to represent a > clock's input mux, MUX_BITS_*, is defined separately for each SoC at > present. Move this definition to a common location to ease fixing

[U-Boot] [PATCH 1/6] ARM: tegra: deduplicate MASK_BITS_xxx clock mux enum

2014-01-22 Thread Stephen Warren
From: Tom Warren The enum used to define the set of register bits used to represent a clock's input mux, MUX_BITS_*, is defined separately for each SoC at present. Move this definition to a common location to ease fixing up some issues with the definition, and the code that uses it. Signed-off-b