Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-12 Thread Simon Glass
Hi Stephen, On Mon, Dec 12, 2011 at 10:18 AM, Stephen Warren wrote: > On 12/08/2011 02:24 PM, Simon Glass wrote: >> On Wed, Dec 7, 2011 at 3:46 PM, Stephen Warren wrote: >>> On 12/06/2011 02:23 PM, Simon Glass wrote: > ... >>> I think the best implementation would be to enumerate everything sole

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-12 Thread Stephen Warren
On 12/08/2011 02:24 PM, Simon Glass wrote: > On Wed, Dec 7, 2011 at 3:46 PM, Stephen Warren wrote: >> On 12/06/2011 02:23 PM, Simon Glass wrote: ... >> I think the best implementation would be to enumerate everything solely >> based on compatible flags, and allowing "usb start" to accept either an

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-08 Thread Simon Glass
Hi Stephen, On Wed, Dec 7, 2011 at 3:46 PM, Stephen Warren wrote: > On 12/06/2011 02:23 PM, Simon Glass wrote: >> Hi Stephen, >> >> On Tue, Dec 6, 2011 at 12:42 PM, Stephen Warren wrote: >>> On 12/05/2011 06:14 PM, Simon Glass wrote: Hi Stephen, On Mon, Dec 5, 2011 at 4:17 PM, Ste

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-07 Thread Stephen Warren
On 12/06/2011 02:23 PM, Simon Glass wrote: > Hi Stephen, > > On Tue, Dec 6, 2011 at 12:42 PM, Stephen Warren wrote: >> On 12/05/2011 06:14 PM, Simon Glass wrote: >>> Hi Stephen, >>> >>> On Mon, Dec 5, 2011 at 4:17 PM, Stephen Warren wrote: On 12/05/2011 04:35 PM, Simon Glass wrote: ...

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-06 Thread Simon Glass
Hi Stephen, On Tue, Dec 6, 2011 at 12:42 PM, Stephen Warren wrote: > On 12/05/2011 06:14 PM, Simon Glass wrote: >> Hi Stephen, >> >> On Mon, Dec 5, 2011 at 4:17 PM, Stephen Warren wrote: >>> On 12/05/2011 04:35 PM, Simon Glass wrote: > ... >>> I'd really like to avoid adding stuff to the .dts fi

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-06 Thread Stephen Warren
On 12/05/2011 06:14 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, Dec 5, 2011 at 4:17 PM, Stephen Warren wrote: >> On 12/05/2011 04:35 PM, Simon Glass wrote: ... >> I'd really like to avoid adding stuff to the .dts file when we know we >> going to rip it out again ASAP. I'd prefer to increment

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-05 Thread Simon Glass
Hi Stephen, On Mon, Dec 5, 2011 at 4:17 PM, Stephen Warren wrote: > On 12/05/2011 04:35 PM, Simon Glass wrote: >> Hi Stephen, >> >> On Mon, Dec 5, 2011 at 2:15 PM, Stephen Warren wrote: >>> On 12/05/2011 02:46 PM, Simon Glass wrote: Hi Stephen, On Mon, Dec 5, 2011 at 1:33 PM, Step

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-05 Thread Stephen Warren
On 12/05/2011 04:35 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, Dec 5, 2011 at 2:15 PM, Stephen Warren wrote: >> On 12/05/2011 02:46 PM, Simon Glass wrote: >>> Hi Stephen, >>> >>> On Mon, Dec 5, 2011 at 1:33 PM, Stephen Warren wrote: On 12/02/2011 05:59 PM, Simon Glass wrote: > Hi

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-05 Thread Simon Glass
Hi Stephen, On Mon, Dec 5, 2011 at 2:15 PM, Stephen Warren wrote: > On 12/05/2011 02:46 PM, Simon Glass wrote: >> Hi Stephen, >> >> On Mon, Dec 5, 2011 at 1:33 PM, Stephen Warren wrote: >>> On 12/02/2011 05:59 PM, Simon Glass wrote: Hi Stephen, Here are my comments on the rest of

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-05 Thread Stephen Warren
On 12/05/2011 02:46 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, Dec 5, 2011 at 1:33 PM, Stephen Warren wrote: >> On 12/02/2011 05:59 PM, Simon Glass wrote: >>> Hi Stephen, >>> >>> Here are my comments on the rest of your email. >>> >>> On Mon, Nov 28, 2011 at 11:21 AM, Stephen Warren wrote:

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-05 Thread Simon Glass
Hi Stephen, On Mon, Dec 5, 2011 at 1:33 PM, Stephen Warren wrote: > On 12/02/2011 05:59 PM, Simon Glass wrote: >> Hi Stephen, >> >> Here are my comments on the rest of your email. >> >> On Mon, Nov 28, 2011 at 11:21 AM, Stephen Warren wrote: >>> On 11/23/2011 08:54 PM, Simon Glass wrote: Th

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-05 Thread Stephen Warren
On 12/02/2011 05:59 PM, Simon Glass wrote: > Hi Stephen, > > Here are my comments on the rest of your email. > > On Mon, Nov 28, 2011 at 11:21 AM, Stephen Warren wrote: >> On 11/23/2011 08:54 PM, Simon Glass wrote: >>> This adds basic support for the Tegra2 USB controller. Board files should >>>

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-02 Thread Simon Glass
Hi Stephen, Here are my comments on the rest of your email. On Mon, Nov 28, 2011 at 11:21 AM, Stephen Warren wrote: > On 11/23/2011 08:54 PM, Simon Glass wrote: >> This adds basic support for the Tegra2 USB controller. Board files should >> call board_usb_init() to set things up. > > Just a very

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-02 Thread Simon Glass
Hi Stephen, On Fri, Dec 2, 2011 at 12:40 PM, Stephen Warren wrote: > On 12/02/2011 10:00 AM, Simon Glass wrote: >> On Fri, Dec 2, 2011 at 8:10 AM, Stephen Warren wrote: >>> On 12/01/2011 06:51 PM, Simon Glass wrote: On Mon, Nov 28, 2011 at 11:21 AM, Stephen Warren wrote: > On 11/

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-02 Thread Stephen Warren
On 12/02/2011 10:00 AM, Simon Glass wrote: > On Fri, Dec 2, 2011 at 8:10 AM, Stephen Warren wrote: >> On 12/01/2011 06:51 PM, Simon Glass wrote: >>> On Mon, Nov 28, 2011 at 11:21 AM, Stephen Warren wrote: On 11/23/2011 08:54 PM, Simon Glass wrote: > This adds basic support for the Tegra2

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-02 Thread Simon Glass
Hi Stephen, On Fri, Dec 2, 2011 at 8:10 AM, Stephen Warren wrote: > On 12/01/2011 06:51 PM, Simon Glass wrote: >> Hi Stephen, >> >> On Mon, Nov 28, 2011 at 11:21 AM, Stephen Warren wrote: >>> On 11/23/2011 08:54 PM, Simon Glass wrote: This adds basic support for the Tegra2 USB controller. B

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-02 Thread Stephen Warren
On 12/01/2011 06:51 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, Nov 28, 2011 at 11:21 AM, Stephen Warren wrote: >> On 11/23/2011 08:54 PM, Simon Glass wrote: >>> This adds basic support for the Tegra2 USB controller. Board files should >>> call board_usb_init() to set things up. >>> +#ifdef

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-12-01 Thread Simon Glass
Hi Stephen, On Mon, Nov 28, 2011 at 11:21 AM, Stephen Warren wrote: > On 11/23/2011 08:54 PM, Simon Glass wrote: >> This adds basic support for the Tegra2 USB controller. Board files should >> call board_usb_init() to set things up. > > Just a very brief review: Thank you. I will tidy up the co

Re: [U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-11-28 Thread Stephen Warren
On 11/23/2011 08:54 PM, Simon Glass wrote: > This adds basic support for the Tegra2 USB controller. Board files should > call board_usb_init() to set things up. Just a very brief review: > +/* Put the port into host mode (this only works for USB1) */ > +static void set_host_mode(struct usb_ctlr *

[U-Boot] [PATCH 10/14] tegra: usb: Add support for USB peripheral

2011-11-23 Thread Simon Glass
This adds basic support for the Tegra2 USB controller. Board files should call board_usb_init() to set things up. Configuration through FDT and CONFIG is supported. For FDT, the device tree aliases set the order of the port, like this fragment: aliases { /* This defines th