Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-16 Thread Detlev Zundel
Hi, >> How about amending the U-Boot design principles with > > Go for it - it's a wiki. Thinking about it, I turned it not into a rule, but into a Lemma from the 10 rules: Lemmas from the golden rules 1. Generic Code is Good Code New code shall be as generic as possible and added t

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-10 Thread Joe Hershberger
Hi Prafulla, On Mon, Jul 9, 2012 at 3:42 PM, Prafulla Wadaskar wrote: > > >> -Original Message- >> From: Holger Brunck [mailto:holger.bru...@keymile.com] >> Sent: 09 July 2012 17:34 >> To: Prafulla Wadaskar >> Cc: Detlev Zundel; Valentin Longchamp; u-boot@lists.denx.de >> Subject: Re: [PA

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-10 Thread Prafulla Wadaskar
> -Original Message- > From: Detlev Zundel [mailto:d...@denx.de] > Sent: 09 July 2012 20:02 > To: Prafulla Wadaskar > Cc: Valentin Longchamp; u-boot@lists.denx.de; > holger.bru...@keymile.com > Subject: Re: [U-Boot] [PATCH 12/20] arm/km: add support for external

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-09 Thread Prafulla Wadaskar
> -Original Message- > From: Holger Brunck [mailto:holger.bru...@keymile.com] > Sent: 09 July 2012 17:34 > To: Prafulla Wadaskar > Cc: Detlev Zundel; Valentin Longchamp; u-boot@lists.denx.de > Subject: Re: [PATCH 12/20] arm/km: add support for external > switchconfiguration > ...snip...

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-09 Thread Wolfgang Denk
Dear Holger, In message <4ffaee4f.3090...@keymile.com> you wrote: > > shouldn't be there an exception for strictly board specific peripheral drivers > like an custom-made FPGA? I see two situations: 1) We are talking about code to load a bitstream into the FPGA, i. e. to "program it". Such

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-09 Thread Wolfgang Denk
Dear Detlev, In message you wrote: > > I just read through our documentation on the Wiki and found nothing > relavant to such a topic. If we make this a requirement, we should add > it so people know about it beforehand. You know all too well that our wiki suffers from a mismatch of what peopl

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-09 Thread Wolfgang Denk
Dear Detlev, In message you wrote: > > > I agree that even very simple and uncomplete implementations can co in should read: ...can go in... > > if the fulfil some purpose, and can form a basis for future > > extensions. > > > > To make sure everybody sees such code, we should really add it t

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-09 Thread Holger Brunck
Hi Detlev, On 07/09/2012 03:06 PM, Detlev Zundel wrote: >> If we place the driver in your board diretory, the chances are huge it >> will simply sit there and rot, and the next one who needs something >> similar will reinvent the wheel because he did not find your copy. >> >> I agree that even ver

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-09 Thread Valentin Longchamp
Hi Detlev, On 07/09/2012 04:31 PM, Detlev Zundel wrote: > Hi Prafulla, > > [...] > >> Hi Detlev >> Clear NAK for this patch > > Do you mean clear NAK for "the patch" or "for the location of the > files"? > >> Let's put it in drivers/net/phy/ >> FYI: there are several drivers used by just one b

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-09 Thread Detlev Zundel
Hi Prafulla, [...] > Hi Detlev > Clear NAK for this patch Do you mean clear NAK for "the patch" or "for the location of the files"? > Let's put it in drivers/net/phy/ > FYI: there are several drivers used by just one board, > [prafulla@pe-dt061 u-boot-marvell.git (master)]$ vim > drivers/net/ph

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-09 Thread Detlev Zundel
Hi Wolfgang, [...] > If we place the driver in your board diretory, the chances are huge it > will simply sit there and rot, and the next one who needs something > similar will reinvent the wheel because he did not find your copy. > > I agree that even very simple and uncomplete implementations c

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-09 Thread Detlev Zundel
Hi Wolfgang, [...] > Sorry, but I disagree. How many board directories are there in > U-Boot? Several hundreds... How many board directories did you check > to make sure none of them contains any driver that is similar to what > you implement here? > > If we place the driver in your board dire

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-09 Thread Wolfgang Denk
Dear Holger, In message <4ffac8c9.1020...@keymile.com> you wrote: > > > Anyways peripheral driver should go in drivers/ > > yes there are maybe drivers which proof your concept, but there are many > others > in the board related code which do the opposite. Yes, but bad examples are not a good

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-09 Thread Holger Brunck
Hi, On 07/04/2012 11:20 AM, Prafulla Wadaskar wrote: >>> Sure it would be great if we had the time and resources to >> contribute a generic >>> driver for these switches. Unfortunately it is not the case and we >> have only >>> developed a simple driver with limited features that suits our >> curr

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-04 Thread Prafulla Wadaskar
> -Original Message- > From: Detlev Zundel [mailto:d...@denx.de] > Sent: 04 July 2012 13:38 > To: Valentin Longchamp > Cc: Prafulla Wadaskar; u-boot@lists.denx.de; holger.bru...@keymile.com > Subject: Re: [U-Boot] [PATCH 12/20] arm/km: add support for external >

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-04 Thread Detlev Zundel
Hi Valentin and Prafulla, [...] >> Dear Valentin >> We must keep develop it as generic driver. >> >> Regards... >> Prafulla . . . >> > > Sure it would be great if we had the time and resources to contribute a > generic > driver for these switches. Unfortunately it is not the case and we have o

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-03 Thread Valentin Longchamp
.com; u- >> b...@lists.denx.de >> Subject: Re: [U-Boot] [PATCH 12/20] arm/km: add support for external >> switchconfiguration >> >> Hi Prafulla, >> >> On 06/12/2012 06:39 AM, Prafulla Wadaskar wrote: >>> >>> >>>> -Origin

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-07-03 Thread Prafulla Wadaskar
> -Original Message- > From: Valentin Longchamp [mailto:valentin.longch...@keymile.com] > Sent: 21 June 2012 18:40 > To: Prafulla Wadaskar > Cc: prafu...@mavell.com; holger.bru...@keymile.com; u- > b...@lists.denx.de > Subject: Re: [U-Boot] [PATCH 12/20] arm/km: add

Re: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration

2012-06-21 Thread Valentin Longchamp
Hi Prafulla, On 06/12/2012 06:39 AM, Prafulla Wadaskar wrote: > > >> -Original Message- >> From: u-boot-boun...@lists.denx.de [mailto:u-boot- >> boun...@lists.denx.de] On Behalf Of Valentin Longchamp >> Sent: 07 June 2012 15:37 >> To: prafu...@mavell.com >> Cc: Valentin Longchamp; holger