Re: [U-Boot] [PATCH 12/25] tpm: tpm_tis_i2c: Simplify init code

2015-08-11 Thread christophe.ricard
Hi Simon, Nothing much to say on tpm_tis_i2c, however this could be even more generic if providing init ops to be specified by TPM driver developers. For example: +struct dm_tpm_ops { + int (*init)(struct udevice *); + int (*open)(struct udevice *); + int (*close)(struct

[U-Boot] [PATCH 12/25] tpm: tpm_tis_i2c: Simplify init code

2015-08-11 Thread Simon Glass
Move all the init and uninit code into one place. Signed-off-by: Simon Glass s...@chromium.org --- drivers/tpm/tpm_tis_i2c.c | 33 ++--- 1 file changed, 10 insertions(+), 23 deletions(-) diff --git a/drivers/tpm/tpm_tis_i2c.c b/drivers/tpm/tpm_tis_i2c.c index