Re: [U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board

2011-12-14 Thread Tom Rini
On Tue, Dec 13, 2011 at 12:18 PM, Ilya Yanok wrote: > Hi Tom, > > On 12.12.2011 20:22, Tom Rini wrote: > +#if defined(CONFIG_GENERIC_MMC) && defined(CONFIG_OMAP_HSMMC) && \ > +    !defined(CONFIG_SPL_BUILD) > +int board_mmc_init(bd_t *bis) > +{ > +    omap_mmc_init(0); > +

Re: [U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board

2011-12-13 Thread Ilya Yanok
Hi Tom, On 12.12.2011 20:22, Tom Rini wrote: +#if defined(CONFIG_GENERIC_MMC) && defined(CONFIG_OMAP_HSMMC) && \ +!defined(CONFIG_SPL_BUILD) +int board_mmc_init(bd_t *bis) +{ +omap_mmc_init(0); +return 0; >>> >>> return omap_mmc_init(0); >>> >>> I would al

Re: [U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board

2011-12-12 Thread Tom Rini
On Mon, Dec 12, 2011 at 8:39 AM, Ilya Yanok wrote: > Hi Igor, > > thanks for your comments. > > On 30.11.2011 12:21, Igor Grinberg wrote: >>> +#if defined(CONFIG_GENERIC_MMC) && defined(CONFIG_OMAP_HSMMC) && \ >>> +    !defined(CONFIG_SPL_BUILD) >>> +int board_mmc_init(bd_t *bis) >>> +{ >>> +    o

Re: [U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board

2011-12-12 Thread Ilya Yanok
Hi Igor, thanks for your comments. On 30.11.2011 12:21, Igor Grinberg wrote: >> +#if defined(CONFIG_GENERIC_MMC) && defined(CONFIG_OMAP_HSMMC) && \ >> +!defined(CONFIG_SPL_BUILD) >> +int board_mmc_init(bd_t *bis) >> +{ >> +omap_mmc_init(0); >> +return 0; > > return omap_mmc_init(0);

Re: [U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board

2011-11-30 Thread Wolfgang Denk
Dear Andy Fleming, In message you wrote: > >> +#define CONFIG_SPL_MAX_SIZE =A0 =A0 =A0 =A0 =A0 =A00xB400 =A0/* 45 K */ > > > > Better as (45 << 10). > > Maybe 45 * 1024? Matter of taste... For KiB it makes not much difference, but for MiB a "45 << 20" is way easier to write and read than a "45

Re: [U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board

2011-11-30 Thread Tom Rini
On Wed, Nov 30, 2011 at 6:49 AM, Andy Fleming wrote: >>> +#define CONFIG_SPL_MAX_SIZE            0xB400  /* 45 K */ >> >> Better as (45 << 10). > > Maybe 45 * 1024? I swear I saw Wolfgang say (45 << 10) for another board (and we do N << 10 in other places in the config files) but either way. --

Re: [U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board

2011-11-30 Thread Andy Fleming
>> +#define CONFIG_SPL_MAX_SIZE            0xB400  /* 45 K */ > > Better as (45 << 10). Maybe 45 * 1024? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board

2011-11-30 Thread Igor Grinberg
Several comments in addition to Tom's comments below. On 11/28/11 18:37, Ilya Yanok wrote: > This patch adds support for the HTKW mcx AM3517-based board. > Serial, Ethernet, NAND, MMC, RTC, EHCI USB host and both > NAND and MMC SPLs are supported. > > Requires updated mach-types file. > > Signed

Re: [U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board

2011-11-29 Thread Tom Rini
On Mon, Nov 28, 2011 at 9:37 AM, Ilya Yanok wrote: > This patch adds support for the HTKW mcx AM3517-based board. > Serial, Ethernet, NAND, MMC, RTC, EHCI USB host and both > NAND and MMC SPLs are supported. [snip] > +#if defined(CONFIG_GENERIC_MMC) && defined(CONFIG_OMAP_HSMMC) && \ > +       !de

[U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board

2011-11-28 Thread Ilya Yanok
This patch adds support for the HTKW mcx AM3517-based board. Serial, Ethernet, NAND, MMC, RTC, EHCI USB host and both NAND and MMC SPLs are supported. Requires updated mach-types file. Signed-off-by: Ilya Yanok --- MAINTAINERS |4 + board/htkw/mcx/Makefile | 38 + board/ht

[U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board

2011-11-10 Thread Ilya Yanok
This patch adds support for the HTKW mcx AM3517-based board. Serial, Ethernet, NAND, MMC, RTC, EHCI USB host and both NAND and MMC SPLs are supported. Requires updated mach-types file. Signed-off-by: Ilya Yanok --- MAINTAINERS |4 + board/htkw/mcx/Makefile | 38 + board/ht