Re: [U-Boot] [PATCH 2/2] [v3] net: abort network initialization if the PHY driver fails

2012-07-10 Thread Joe Hershberger
Hi Timur Tabi, On Mon, Jul 9, 2012 at 1:52 PM, Timur Tabi ti...@freescale.com wrote: Now that phy_startup() can return an actual error code, check for that error code and abort network initialization if the PHY fails. Signed-off-by: Timur Tabi ti...@freescale.com Acked-by: Nobuhiro

Re: [U-Boot] [PATCH 2/2] [v3] net: abort network initialization if the PHY driver fails

2012-07-10 Thread Timur Tabi
Joe Hershberger wrote: diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index eee41d7..5700552 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -510,7 +510,13 @@ static int fec_open(struct eth_device *edev) fec_eth_phy_config(edev); if

Re: [U-Boot] [PATCH 2/2] [v3] net: abort network initialization if the PHY driver fails

2012-07-10 Thread Joe Hershberger
Hi Timur Tabi, On Tue, Jul 10, 2012 at 11:15 AM, Timur Tabi ti...@freescale.com wrote: Joe Hershberger wrote: diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index eee41d7..5700552 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -510,7 +510,13 @@ static int

Re: [U-Boot] [PATCH 2/2] [v3] net: abort network initialization if the PHY driver fails

2012-07-10 Thread Timur Tabi
Joe Hershberger wrote: @@ -384,7 +387,11 @@ static int fm_eth_open(struct eth_device *dev, bd_t *bd) fmc_tx_port_graceful_stop_disable(fm_eth); #ifdef CONFIG_PHYLIB - phy_startup(fm_eth-phydev); + ret = phy_startup(fm_eth-phydev); + if (ret) { +

Re: [U-Boot] [PATCH 2/2] [v3] net: abort network initialization if the PHY driver fails

2012-07-10 Thread Joe Hershberger
On Tue, Jul 10, 2012 at 1:35 PM, Timur Tabi ti...@freescale.com wrote: Joe Hershberger wrote: diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c index bb57e4d..268d884 100644 --- a/drivers/net/sh_eth.c +++ b/drivers/net/sh_eth.c @@ -415,7 +415,11 @@ static int sh_eth_config(struct

[U-Boot] [PATCH 2/2] [v3] net: abort network initialization if the PHY driver fails

2012-07-09 Thread Timur Tabi
Now that phy_startup() can return an actual error code, check for that error code and abort network initialization if the PHY fails. Signed-off-by: Timur Tabi ti...@freescale.com Acked-by: Nobuhiro Iwamamatsu nobuhiro.iwamatsu...@renesas.com (sh_eth part) Acked-by: Stephan Linz l...@li-pro.net

Re: [U-Boot] [PATCH 2/2] [v3] net: abort network initialization if the PHY driver fails

2012-07-09 Thread Marek Vasut
Dear Timur Tabi, Now that phy_startup() can return an actual error code, check for that error code and abort network initialization if the PHY fails. Signed-off-by: Timur Tabi ti...@freescale.com Acked-by: Nobuhiro Iwamamatsu nobuhiro.iwamatsu...@renesas.com (sh_eth part) Acked-by: Stephan