Re: [U-Boot] [PATCH 2/2] dm: mmc: dwmmc: use the callback functions as static

2016-07-07 Thread Simon Glass
Hi Minkyu, On 6 July 2016 at 20:14, Minkyu Kang wrote: > Hi, > > On 01/07/16 04:53, Simon Glass wrote: >> Hi Jaehoon, >> >> On 28 June 2016 at 20:47, Jaehoon Chung wrote: >>> Hi Simon, >>> >>> On 06/29/2016 12:28 PM, Simon Glass wrote: Hi Jaehoon, On 27 June 2016 at 23:52, Jaehoon

Re: [U-Boot] [PATCH 2/2] dm: mmc: dwmmc: use the callback functions as static

2016-07-06 Thread Minkyu Kang
Hi, On 01/07/16 04:53, Simon Glass wrote: > Hi Jaehoon, > > On 28 June 2016 at 20:47, Jaehoon Chung wrote: >> Hi Simon, >> >> On 06/29/2016 12:28 PM, Simon Glass wrote: >>> Hi Jaehoon, >>> >>> On 27 June 2016 at 23:52, Jaehoon Chung wrote: There are no places to call these functions.

Re: [U-Boot] [PATCH 2/2] dm: mmc: dwmmc: use the callback functions as static

2016-06-30 Thread Simon Glass
Hi Jaehoon, On 28 June 2016 at 20:47, Jaehoon Chung wrote: > Hi Simon, > > On 06/29/2016 12:28 PM, Simon Glass wrote: >> Hi Jaehoon, >> >> On 27 June 2016 at 23:52, Jaehoon Chung wrote: >>> There are no places to call these functions. >>> It should be used the callback function. >>> Then it can

Re: [U-Boot] [PATCH 2/2] dm: mmc: dwmmc: use the callback functions as static

2016-06-28 Thread Jaehoon Chung
Hi Simon, On 06/29/2016 12:28 PM, Simon Glass wrote: > Hi Jaehoon, > > On 27 June 2016 at 23:52, Jaehoon Chung wrote: >> There are no places to call these functions. >> It should be used the callback function. >> Then it can be used as static functions. >> >> Signed-off-by: Jaehoon Chung >> ---

Re: [U-Boot] [PATCH 2/2] dm: mmc: dwmmc: use the callback functions as static

2016-06-28 Thread Simon Glass
Hi Jaehoon, On 27 June 2016 at 23:52, Jaehoon Chung wrote: > There are no places to call these functions. > It should be used the callback function. > Then it can be used as static functions. > > Signed-off-by: Jaehoon Chung > --- > drivers/mmc/dw_mmc.c | 4 ++-- > include/dwmmc.h | 3 ---

[U-Boot] [PATCH 2/2] dm: mmc: dwmmc: use the callback functions as static

2016-06-27 Thread Jaehoon Chung
There are no places to call these functions. It should be used the callback function. Then it can be used as static functions. Signed-off-by: Jaehoon Chung --- drivers/mmc/dw_mmc.c | 4 ++-- include/dwmmc.h | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/