Re: [U-Boot] [PATCH 2/2] gpio: tegra: use named constants

2015-10-03 Thread Stephen Warren
On 10/03/2015 08:14 AM, Simon Glass wrote: > Hi Stephen, > > On 2 October 2015 at 00:29, Stephen Warren wrote: >> On 10/01/2015 05:00 PM, Simon Glass wrote: >>> >>> On Friday, 25 September 2015, Stephen Warren >>> wrote: From: Stephen Warren In order to make it clear what th

Re: [U-Boot] [PATCH 2/2] gpio: tegra: use named constants

2015-10-03 Thread Simon Glass
Hi Stephen, On 2 October 2015 at 00:29, Stephen Warren wrote: > On 10/01/2015 05:00 PM, Simon Glass wrote: >> >> On Friday, 25 September 2015, Stephen Warren >> wrote: >>> >>> From: Stephen Warren >>> >>> In order to make it clear what the parameters to set_config() and >>> set_direction() mean

Re: [U-Boot] [PATCH 2/2] gpio: tegra: use named constants

2015-10-01 Thread Stephen Warren
On 10/01/2015 05:00 PM, Simon Glass wrote: On Friday, 25 September 2015, Stephen Warren wrote: From: Stephen Warren In order to make it clear what the parameters to set_config() and set_direction() mean, and similarly for the return values from the respective get_*(), define named constants f

Re: [U-Boot] [PATCH 2/2] gpio: tegra: use named constants

2015-10-01 Thread Simon Glass
Hi Stephen. On Friday, 25 September 2015, Stephen Warren wrote: > > From: Stephen Warren > > In order to make it clear what the parameters to set_config() and > set_direction() mean, and similarly for the return values from the > respective get_*(), define named constants for these values. > > D

[U-Boot] [PATCH 2/2] gpio: tegra: use named constants

2015-09-25 Thread Stephen Warren
From: Stephen Warren In order to make it clear what the parameters to set_config() and set_direction() mean, and similarly for the return values from the respective get_*(), define named constants for these values. Disassembly shows no diff in the generated code, except that the order of the cod