Re: [U-Boot] [PATCH 2/2] net: dwc_et_qos: update weak function board_interface_eth_init

2019-09-03 Thread Joe Hershberger
On Thu, Aug 1, 2019 at 4:32 AM Patrick Delaunay wrote: > > Align the board and driver prototype for board_interface_eth_init > to avoid execution issue (the interface_type parameter is defined > as int or phy_interface_t). > > To have a generic weak function (it should be reused by other driver)

Re: [U-Boot] [PATCH 2/2] net: dwc_et_qos: update weak function board_interface_eth_init

2019-08-08 Thread Christophe Roullier
Hi Ramon, No need to write specific phy driver, uboot phy generic driver is working fine. The goal of board_interface_eth_init function is only to configure syscfg register with good value in function of interface type (MII, RMII, GMII ...). And this syscfg value is specific for each platform.

Re: [U-Boot] [PATCH 2/2] net: dwc_et_qos: update weak function board_interface_eth_init

2019-08-03 Thread Ramon Fried
On Thu, Aug 1, 2019 at 12:32 PM Patrick Delaunay wrote: > > Align the board and driver prototype for board_interface_eth_init > to avoid execution issue (the interface_type parameter is defined > as int or phy_interface_t). > > To have a generic weak function (it should be reused by other driver)

[U-Boot] [PATCH 2/2] net: dwc_et_qos: update weak function board_interface_eth_init

2019-08-01 Thread Patrick Delaunay
Align the board and driver prototype for board_interface_eth_init to avoid execution issue (the interface_type parameter is defined as int or phy_interface_t). To have a generic weak function (it should be reused by other driver) I change the prototype to use directly udevice. This prototype is