Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
On Thu, 19 May 2022, Peter Geis wrote: > On Thu, May 19, 2022 at 1:36 PM Peter Geis wrote: > > > > On Thu, May 19, 2022 at 1:23 PM Lee Jones wrote: > > > > > > On Thu, 19 May 2022, Lee Jones wrote: > > > > > > > On Thu, 19 May 2022, Peter Geis wrote: > > > > > > > > > On Thu, May 19, 2022 at 11:

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Peter Geis
On Thu, May 19, 2022 at 1:36 PM Peter Geis wrote: > > On Thu, May 19, 2022 at 1:23 PM Lee Jones wrote: > > > > On Thu, 19 May 2022, Lee Jones wrote: > > > > > On Thu, 19 May 2022, Peter Geis wrote: > > > > > > > On Thu, May 19, 2022 at 11:47 AM Lee Jones wrote: > > > > > > > > > > On Thu, 19 May

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Peter Geis
On Thu, May 19, 2022 at 1:23 PM Lee Jones wrote: > > On Thu, 19 May 2022, Lee Jones wrote: > > > On Thu, 19 May 2022, Peter Geis wrote: > > > > > On Thu, May 19, 2022 at 11:47 AM Lee Jones wrote: > > > > > > > > On Thu, 19 May 2022, Lee Jones wrote: > > > > > > > > > On Thu, 19 May 2022, Peter Ge

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
On Thu, 19 May 2022, Lee Jones wrote: > On Thu, 19 May 2022, Peter Geis wrote: > > > On Thu, May 19, 2022 at 11:47 AM Lee Jones wrote: > > > > > > On Thu, 19 May 2022, Lee Jones wrote: > > > > > > > On Thu, 19 May 2022, Peter Geis wrote: > > > > > > > > > On Thu, May 19, 2022 at 10:56 AM Lee Jon

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
On Thu, 19 May 2022, Peter Geis wrote: > On Thu, May 19, 2022 at 11:47 AM Lee Jones wrote: > > > > On Thu, 19 May 2022, Lee Jones wrote: > > > > > On Thu, 19 May 2022, Peter Geis wrote: > > > > > > > On Thu, May 19, 2022 at 10:56 AM Lee Jones wrote: > > > > > > > > > > > > > > It's not clear how

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Peter Geis
On Thu, May 19, 2022 at 11:47 AM Lee Jones wrote: > > On Thu, 19 May 2022, Lee Jones wrote: > > > On Thu, 19 May 2022, Peter Geis wrote: > > > > > On Thu, May 19, 2022 at 10:56 AM Lee Jones wrote: > > > > > > > > > > > > It's not clear how this issue (present 3 years ago) was finally > > > > > >

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
On Thu, 19 May 2022, Lee Jones wrote: > On Thu, 19 May 2022, Peter Geis wrote: > > > On Thu, May 19, 2022 at 10:56 AM Lee Jones wrote: > > > > > > > > > > It's not clear how this issue (present 3 years ago) was finally > > > > > > > resolved. From the thread, it looks as if the fix might have

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
On Thu, 19 May 2022, Peter Geis wrote: > On Thu, May 19, 2022 at 10:56 AM Lee Jones wrote: > > > > > > > > It's not clear how this issue (present 3 years ago) was finally > > > > > > resolved. From the thread, it looks as if the fix might have made > > > > > > its > > > > > > way into ATF, but

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Peter Geis
On Thu, May 19, 2022 at 10:56 AM Lee Jones wrote: > > > > > > It's not clear how this issue (present 3 years ago) was finally > > > > > resolved. From the thread, it looks as if the fix might have made its > > > > > way into ATF, but I'm 87.6% sure ATF is not running on this platform > > > > > (y

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
> > > > It's not clear how this issue (present 3 years ago) was finally > > > > resolved. From the thread, it looks as if the fix might have made its > > > > way into ATF, but I'm 87.6% sure ATF is not running on this platform > > > > (yet). > > > > > > The rk3399 SoC has a hardware bug where the

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
On Wed, 18 May 2022, Peter Geis wrote: > On Wed, May 18, 2022 at 7:56 AM Lee Jones wrote: > > > > Looping int a few relevant/active kernel people/lists for full coverage. > > > > On Sun, 01 Dec 2019, Hugh Cole-Baker wrote: > > > > On 29 Nov 2019, at 01:06, Vasily Khoruzhick wrote: > > > > On Thu,

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Peter Geis
On Thu, May 19, 2022 at 4:17 AM Lee Jones wrote: > > On Wed, 18 May 2022, Peter Geis wrote: > > On Wed, May 18, 2022 at 7:56 AM Lee Jones wrote: > > > > > > Looping int a few relevant/active kernel people/lists for full coverage. > > > > > > On Sun, 01 Dec 2019, Hugh Cole-Baker wrote: > > > > > O

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-18 Thread Peter Geis
On Wed, May 18, 2022 at 7:56 AM Lee Jones wrote: > > Looping int a few relevant/active kernel people/lists for full coverage. > > On Sun, 01 Dec 2019, Hugh Cole-Baker wrote: > > > On 29 Nov 2019, at 01:06, Vasily Khoruzhick wrote: > > > On Thu, Nov 28, 2019 at 4:59 PM Kever Yang > > > wrote: >

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-18 Thread Lee Jones
Looping int a few relevant/active kernel people/lists for full coverage. On Sun, 01 Dec 2019, Hugh Cole-Baker wrote: > > On 29 Nov 2019, at 01:06, Vasily Khoruzhick wrote: > > On Thu, Nov 28, 2019 at 4:59 PM Kever Yang > > wrote: > >> > >> Hi Vasily, > >> > >> On 2019/11/28 下午11:51, Vasily Kh

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2019-12-01 Thread Kever Yang
Hi Huge Cole-Baker, On 2019/12/1 下午10:12, Hugh Cole-Baker wrote: Hi Vasily, On 29 Nov 2019, at 01:06, Vasily Khoruzhick wrote: On Thu, Nov 28, 2019 at 4:59 PM Kever Yang wrote: Hi Vasily, On 2019/11/28 下午11:51, Vasily Khoruzhick wrote: On Thu, Nov 28, 2019 at 1:23 AM Kever Yang wrote:

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2019-12-01 Thread Hugh Cole-Baker
Hi Vasily, > On 29 Nov 2019, at 01:06, Vasily Khoruzhick wrote: > > On Thu, Nov 28, 2019 at 4:59 PM Kever Yang wrote: >> >> Hi Vasily, >> >> On 2019/11/28 下午11:51, Vasily Khoruzhick wrote: >>> On Thu, Nov 28, 2019 at 1:23 AM Kever Yang >>> wrote: Hi Vasily, I think this

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2019-12-01 Thread Kever Yang
On 2019/11/28 下午2:14, Vasily Khoruzhick wrote: Rockpro64 doesn't boot reliably after soft reset, so let's force power on reset by asserting sysreset pin if we detected soft reset. Signed-off-by: Vasily Khoruzhick Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3399-rockpro64-u

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2019-11-28 Thread Vasily Khoruzhick
On Thu, Nov 28, 2019 at 4:59 PM Kever Yang wrote: > > Hi Vasily, > > On 2019/11/28 下午11:51, Vasily Khoruzhick wrote: > > On Thu, Nov 28, 2019 at 1:23 AM Kever Yang > > wrote: > >> Hi Vasily, > >> > >> I think this should not be needed, see comments below. > > Hi Kever, > > > > I've spent 2

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2019-11-28 Thread Kever Yang
Hi Vasily, On 2019/11/28 下午11:51, Vasily Khoruzhick wrote: On Thu, Nov 28, 2019 at 1:23 AM Kever Yang wrote: Hi Vasily, I think this should not be needed, see comments below. Hi Kever, I've spent 2 weeks of my evenings debugging this issue but I can understand you work pretty hard o

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2019-11-28 Thread Vasily Khoruzhick
On Thu, Nov 28, 2019 at 1:23 AM Kever Yang wrote: > > Hi Vasily, > > I think this should not be needed, see comments below. Hi Kever, I've spent 2 weeks of my evenings debugging this issue but unfortunately I don't have a proper fix. This is the only solution that makes my rockpro64 reboot

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2019-11-28 Thread Kever Yang
Hi Vasily,     I think this should not be needed, see comments below. Hi Philipp, Klaus and Christoph:     Could you help to check why do you need below patch for your board? ae0d33a729 rockchip: rk3399-puma: add code to allow forcing a power-on reset     I think we don't need this workarou

[U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2019-11-27 Thread Vasily Khoruzhick
Rockpro64 doesn't boot reliably after soft reset, so let's force power on reset by asserting sysreset pin if we detected soft reset. Signed-off-by: Vasily Khoruzhick --- arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 8 configs/rockpro64-rk3399_defconfig| 1 + 2 files changed, 9 in