Re: [U-Boot] [PATCH 2/2] usb: phy: omap_usb_phy: implement usb_phy_power() for AM437x

2014-07-10 Thread Marek Vasut
On Thursday, July 10, 2014 at 06:06:06 AM, Felipe Balbi wrote: > On Wed, Jul 09, 2014 at 11:02:43PM -0500, Felipe Balbi wrote: > > Newer AM437x silicon requires us to explicitly power up > > the USB2 PHY. By implementing usb_phy_power() we can > > achieve that. > > > > Signed-off-by: Felipe Balbi

Re: [U-Boot] [PATCH 2/2] usb: phy: omap_usb_phy: implement usb_phy_power() for AM437x

2014-07-09 Thread Felipe Balbi
On Wed, Jul 09, 2014 at 11:02:43PM -0500, Felipe Balbi wrote: > Newer AM437x silicon requires us to explicitly power up > the USB2 PHY. By implementing usb_phy_power() we can > achieve that. > > Signed-off-by: Felipe Balbi > --- the only change here is the use of {set,clr}bits_le32() > arch/ar

[U-Boot] [PATCH 2/2] usb: phy: omap_usb_phy: implement usb_phy_power() for AM437x

2014-07-09 Thread Felipe Balbi
Newer AM437x silicon requires us to explicitly power up the USB2 PHY. By implementing usb_phy_power() we can achieve that. Signed-off-by: Felipe Balbi --- arch/arm/include/asm/arch-am33xx/hardware_am43xx.h | 5 + drivers/usb/phy/omap_usb_phy.c | 11 ++- 2 files c

Re: [U-Boot] [PATCH 2/2] usb: phy: omap_usb_phy: implement usb_phy_power() for AM437x

2014-06-23 Thread Michael Trimarchi
Hi Il 23/giu/2014 23:58 "Felipe Balbi" ha scritto: > > Hi, > > On Mon, Jun 23, 2014 at 11:28:30PM +0200, Michael Trimarchi wrote: > > > @@ -222,7 +222,22 @@ static void am437x_enable_usb2_phy2(struct omap_xhci > > *omap) > > > > > > void usb_phy_power(int on) > > > { > > > - return; > > >

Re: [U-Boot] [PATCH 2/2] usb: phy: omap_usb_phy: implement usb_phy_power() for AM437x

2014-06-23 Thread Felipe Balbi
Hi, On Mon, Jun 23, 2014 at 11:28:30PM +0200, Michael Trimarchi wrote: > > @@ -222,7 +222,22 @@ static void am437x_enable_usb2_phy2(struct omap_xhci > *omap) > > > > void usb_phy_power(int on) > > { > > - return; > > + u32 val; > > + > > + /* USB1_CTRL */ > > + val = read

Re: [U-Boot] [PATCH 2/2] usb: phy: omap_usb_phy: implement usb_phy_power() for AM437x

2014-06-23 Thread Michael Trimarchi
Hi Il 23/giu/2014 23:26 "Felipe Balbi" ha scritto: > > Newer AM437x silicon requires us to explicitly power up > the USB2 PHY. By implementing usb_phy_power() we can > achieve that. > > Signed-off-by: Felipe Balbi > --- > drivers/usb/phy/omap_usb_phy.c | 17 - > 1 file changed,

[U-Boot] [PATCH 2/2] usb: phy: omap_usb_phy: implement usb_phy_power() for AM437x

2014-06-23 Thread Felipe Balbi
Newer AM437x silicon requires us to explicitly power up the USB2 PHY. By implementing usb_phy_power() we can achieve that. Signed-off-by: Felipe Balbi --- drivers/usb/phy/omap_usb_phy.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/omap_usb