Re: [U-Boot] [PATCH 2/2] usb: sunxi: sun50i: enable OHCI0 clock when OHCI1 is in use

2018-06-06 Thread Vasily Khoruzhick
On Wed, Jun 6, 2018 at 9:36 AM, Jagan Teki wrote: Why is the SoC / compatible information not coming from DT instead ? Why is the driver polluted by more ifdefs ? >>> >>> Because this platform doesn't have DM clock driver yet. This code will >>> be removed once this driver is implemented

Re: [U-Boot] [PATCH 2/2] usb: sunxi: sun50i: enable OHCI0 clock when OHCI1 is in use

2018-06-06 Thread Vasily Khoruzhick
On Wed, Jun 6, 2018 at 9:35 AM, Jagan Teki wrote: > On Wed, Jun 6, 2018 at 8:43 PM, Vasily Khoruzhick wrote: >> extra_usb_gate_mask isn't shifted later and thus >> CCM_USB_CTRL_OHCI0_CLK and CCM_USB_CTRL_OHCI1_CLK will be enabled for >> phy 1 on A64. > > Where are you checking phy 1? and you sti

Re: [U-Boot] [PATCH 2/2] usb: sunxi: sun50i: enable OHCI0 clock when OHCI1 is in use

2018-06-06 Thread Jagan Teki
On Wed, Jun 6, 2018 at 8:43 PM, Marek Vasut wrote: > On 06/06/2018 05:12 PM, Vasily Khoruzhick wrote: >> On Wed, Jun 6, 2018 at 2:02 AM, Marek Vasut wrote: >>> On 06/06/2018 05:38 AM, Vasily Khoruzhick wrote: On A64 OHCI1 clock source is OHCI0 clock, so we need to enable OHCI0 clock whe

Re: [U-Boot] [PATCH 2/2] usb: sunxi: sun50i: enable OHCI0 clock when OHCI1 is in use

2018-06-06 Thread Jagan Teki
On Wed, Jun 6, 2018 at 8:43 PM, Vasily Khoruzhick wrote: > On Wed, Jun 6, 2018 at 6:56 AM, Jagan Teki wrote: >> On Wed, Jun 6, 2018 at 9:08 AM, Vasily Khoruzhick wrote: >>> On A64 OHCI1 clock source is OHCI0 clock, so we need to enable OHCI0 >>> clock when OHCI1 is in use. >>> >>> Fixes commit d

Re: [U-Boot] [PATCH 2/2] usb: sunxi: sun50i: enable OHCI0 clock when OHCI1 is in use

2018-06-06 Thread Marek Vasut
On 06/06/2018 05:12 PM, Vasily Khoruzhick wrote: > On Wed, Jun 6, 2018 at 2:02 AM, Marek Vasut wrote: >> On 06/06/2018 05:38 AM, Vasily Khoruzhick wrote: >>> On A64 OHCI1 clock source is OHCI0 clock, so we need to enable OHCI0 >>> clock when OHCI1 is in use. >>> >>> Fixes commit dd3228170ad7 ("usb

Re: [U-Boot] [PATCH 2/2] usb: sunxi: sun50i: enable OHCI0 clock when OHCI1 is in use

2018-06-06 Thread Vasily Khoruzhick
On Wed, Jun 6, 2018 at 6:56 AM, Jagan Teki wrote: > On Wed, Jun 6, 2018 at 9:08 AM, Vasily Khoruzhick wrote: >> On A64 OHCI1 clock source is OHCI0 clock, so we need to enable OHCI0 >> clock when OHCI1 is in use. >> >> Fixes commit dd3228170ad7 ("usb: sunxi: Switch to use generic-phy") >> >> Signe

Re: [U-Boot] [PATCH 2/2] usb: sunxi: sun50i: enable OHCI0 clock when OHCI1 is in use

2018-06-06 Thread Vasily Khoruzhick
On Wed, Jun 6, 2018 at 2:02 AM, Marek Vasut wrote: > On 06/06/2018 05:38 AM, Vasily Khoruzhick wrote: >> On A64 OHCI1 clock source is OHCI0 clock, so we need to enable OHCI0 >> clock when OHCI1 is in use. >> >> Fixes commit dd3228170ad7 ("usb: sunxi: Switch to use generic-phy") >> >> Signed-off-by

Re: [U-Boot] [PATCH 2/2] usb: sunxi: sun50i: enable OHCI0 clock when OHCI1 is in use

2018-06-06 Thread Jagan Teki
On Wed, Jun 6, 2018 at 9:08 AM, Vasily Khoruzhick wrote: > On A64 OHCI1 clock source is OHCI0 clock, so we need to enable OHCI0 > clock when OHCI1 is in use. > > Fixes commit dd3228170ad7 ("usb: sunxi: Switch to use generic-phy") > > Signed-off-by: Vasily Khoruzhick > --- > drivers/usb/host/ohci

Re: [U-Boot] [PATCH 2/2] usb: sunxi: sun50i: enable OHCI0 clock when OHCI1 is in use

2018-06-06 Thread Marek Vasut
On 06/06/2018 05:38 AM, Vasily Khoruzhick wrote: > On A64 OHCI1 clock source is OHCI0 clock, so we need to enable OHCI0 > clock when OHCI1 is in use. > > Fixes commit dd3228170ad7 ("usb: sunxi: Switch to use generic-phy") > > Signed-off-by: Vasily Khoruzhick > --- > drivers/usb/host/ohci-sunxi.

[U-Boot] [PATCH 2/2] usb: sunxi: sun50i: enable OHCI0 clock when OHCI1 is in use

2018-06-05 Thread Vasily Khoruzhick
On A64 OHCI1 clock source is OHCI0 clock, so we need to enable OHCI0 clock when OHCI1 is in use. Fixes commit dd3228170ad7 ("usb: sunxi: Switch to use generic-phy") Signed-off-by: Vasily Khoruzhick --- drivers/usb/host/ohci-sunxi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) di