[U-Boot] [PATCH 2/3] common/memsize.c: correctly restore all modified memory loations

2014-10-21 Thread Wolfgang Denk
The original memory sizing code in get_ram_size clobbers the word at the base address, but forgets to restore it. Unlike the (reverted) commit b8496cced856ff411f1eb2e4eff20f5abe7080b0 we save and restore the base address value at the start resp. at the end of the function. It needs to stay

Re: [U-Boot] [PATCH 2/3] common/memsize.c: correctly restore all modified memory loations

2014-10-21 Thread Wolfgang Denk
Note: there is no patch 3/3 in his series. It was originally [PATCH] powerpc: TQM5200: convert to generic board but this is actually not related to these changes here, so I decided to post it independently. Sorry for the confusion. Best regards, Wolfgang Denk -- DENX Software

Re: [U-Boot] [PATCH 2/3] common/memsize.c: correctly restore all modified memory loations

2014-10-21 Thread Gerd Hoffmann
Hi, Signed-off-by: Gerd Hoffmann kra...@redhat.com No, I didn't signed this patch off. And I will not because it is broken. for (cnt = (maxsize / sizeof(long)) 1; cnt 0; cnt = 1) { addr = base + cnt; /* pointer arith! */ @@ -44,6 +44,7 @@ long get_ram_size(long