Re: [U-Boot] [PATCH 2/3] net: add higmacv300 Ethernet driver for HiSilicon platform

2019-02-13 Thread Shawn Guo
Hi Joe, Thanks for spending time to review the patch. On Mon, Feb 04, 2019 at 11:48:40PM +, Joe Hershberger wrote: > On Mon, Jan 28, 2019 at 3:16 AM Shawn Guo wrote: > > > > It adds the driver for HIGMACV300 Ethernet controller found on HiSilicon > > SoCs like Hi3798CV200. It's based on a d

Re: [U-Boot] [PATCH 2/3] net: add higmacv300 Ethernet driver for HiSilicon platform

2019-02-04 Thread Joe Hershberger
On Mon, Jan 28, 2019 at 3:16 AM Shawn Guo wrote: > > It adds the driver for HIGMACV300 Ethernet controller found on HiSilicon > SoCs like Hi3798CV200. It's based on a downstream U-Boot driver, but > quite a lot of code gets rewritten and cleaned up to adopt driver model > and PHY API. > > Signed-

Re: [U-Boot] [PATCH 2/3] net: add higmacv300 Ethernet driver for HiSilicon platform

2019-01-31 Thread Shawn Guo
Hi Igor, On Tue, Jan 29, 2019 at 11:50:33PM +0200, Igor Opaniuk wrote: > Hi Shawn, > > Please see inline comments (mostly minor stuff). > I'll also test the driver a bit later and leave my T-b. Thanks. I appreciate the effort of testing. > > On Mon, 28 Jan 2019 at 11:15, Shawn Guo wrote: > >

Re: [U-Boot] [PATCH 2/3] net: add higmacv300 Ethernet driver for HiSilicon platform

2019-01-29 Thread Igor Opaniuk
Hi Shawn, Please see inline comments (mostly minor stuff). I'll also test the driver a bit later and leave my T-b. On Mon, 28 Jan 2019 at 11:15, Shawn Guo wrote: > > It adds the driver for HIGMACV300 Ethernet controller found on HiSilicon > SoCs like Hi3798CV200. It's based on a downstream U-Bo

[U-Boot] [PATCH 2/3] net: add higmacv300 Ethernet driver for HiSilicon platform

2019-01-28 Thread Shawn Guo
It adds the driver for HIGMACV300 Ethernet controller found on HiSilicon SoCs like Hi3798CV200. It's based on a downstream U-Boot driver, but quite a lot of code gets rewritten and cleaned up to adopt driver model and PHY API. Signed-off-by: Shawn Guo --- drivers/net/Kconfig | 9 + drive